You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2024/01/23 08:44:06 UTC
[I] "cargo msrv verify" in CI [arrow-datafusion]
mustafasrepo opened a new issue, #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961
### Describe the bug
I am not sure here is the correct place to ask this. I am asking here in case someone experienced or someone who encountered similar problem can help me.
While working in a PR, CI fails during `cargo msrv verify` with error
```sql
Using check command cargo check
Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.70.0', as defined in '/__w/arrow-datafusion/arrow-datafusion/datafusion/core/Cargo.toml'
```
However, it doesn't really say what is the problem. In the PR I didn't change any `Cargo.toml` file. I am not sure, how I triggerred it. Is there anyone with suggestions?
### To Reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo closed issue #8961: "cargo msrv verify" in CI
URL: https://github.com/apache/arrow-datafusion/issues/8961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on issue #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961#issuecomment-1905713435
Thanks @haohuaijin It seems that `ahash=0.8.7` has features from `rust=1.75.0`. It seems to be the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961#issuecomment-1909994469
> > What PR caused the problem?
>
> It was this [PR](https://github.com/synnada-ai/arrow-datafusion/pull/270) in synnada repo. However, upgrading dependencies fixed it. It no longer has this problem. I asked here, in case someone could help me understand better the root cause. Closing this issue now it is not relevant with datafusion per se. @haohuaijin for the suggestion again
I filed https://github.com/apache/arrow-datafusion/pull/8995 to add some comments to try and help anyone else who may encounter this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961#issuecomment-1908315325
What PR caused the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on issue #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961#issuecomment-1909412636
> What PR caused the problem?
It was this [PR](https://github.com/synnada-ai/arrow-datafusion/pull/270) in synnada repo. However, upgrading dependencies fixed it. It no longer has this problem. I asked here, in case someone could help me understand better the root cause.
Closing this issue now it is not relevant with datafusion per se. @haohuaijin for the suggestion again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] "cargo msrv verify" in CI [arrow-datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on issue #8961:
URL: https://github.com/apache/arrow-datafusion/issues/8961#issuecomment-1905617247
It seems like you use the rust feature that rust version > `1.70.0`.
`cargo msrv verify` check datafusion should work for `1.70.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org