You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 23:15:22 UTC
[GitHub] [helix] xyuanlu opened a new issue #1590: Lock contention in CallbackHandler.enqueueTask
xyuanlu opened a new issue #1590:
URL: https://github.com/apache/helix/issues/1590
### Describe the bug
During investigation and debugging, we found that a lot time is spent on waiting for the `synchronized` in CallbackHandler.enqueueTask.
```
public void enqueueTask(NotificationContext changeContext) throws Exception {
// async mode only applicable to CALLBACK from ZK, During INIT and FINALIZE invoke the
// callback's immediately.
if (_batchModeEnabled && changeContext.getType() == NotificationContext.Type.CALLBACK) {
.....
synchronized (this) { <<<<<---------
if (_batchCallbackProcessor != null) {
_batchCallbackProcessor.queueEvent(changeContext.getType(), changeContext);
} else {
}
```
### Expected behavior
We would like to reduce the lock scope for CallbackHandler.enqueueTask
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu closed issue #1590: Lock contention in CallbackHandler.enqueueTask
Posted by GitBox <gi...@apache.org>.
xyuanlu closed issue #1590:
URL: https://github.com/apache/helix/issues/1590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org