You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/01/10 21:29:40 UTC

Re: svn commit: rev 4323 - trunk/subversion/clients/cmdline

You inserted some tabs into (at least) feedback.c.

Cheers,
-g

/me thinks about a pre-commit hook to disallow .[ch] files with tabs... :-)


On Fri, Jan 10, 2003 at 12:54:04PM -0600, kraai@tigris.org wrote:
> Author: kraai
> Date: 2003-01-10 12:53:51 -0600 (Fri, 10 Jan 2003)
> New Revision: 4323
> 
> Modified:
>    trunk/subversion/clients/cmdline/add-cmd.c
>    trunk/subversion/clients/cmdline/checkout-cmd.c
>    trunk/subversion/clients/cmdline/cl.h
>    trunk/subversion/clients/cmdline/commit-cmd.c
>    trunk/subversion/clients/cmdline/copy-cmd.c
>    trunk/subversion/clients/cmdline/delete-cmd.c
>    trunk/subversion/clients/cmdline/export-cmd.c
>    trunk/subversion/clients/cmdline/feedback.c
>    trunk/subversion/clients/cmdline/import-cmd.c
>    trunk/subversion/clients/cmdline/merge-cmd.c
>    trunk/subversion/clients/cmdline/mkdir-cmd.c
>    trunk/subversion/clients/cmdline/move-cmd.c
>    trunk/subversion/clients/cmdline/resolve-cmd.c
>    trunk/subversion/clients/cmdline/revert-cmd.c
>    trunk/subversion/clients/cmdline/status-cmd.c
>    trunk/subversion/clients/cmdline/switch-cmd.c
>    trunk/subversion/clients/cmdline/update-cmd.c
> Log:
> * subversion/clients/cmdline/feedback.c
>   (struct notify_baton): Add is_export field and...
>   (notify): ...use it for the summary message.
>   (svn_cl__get_notifier): Add is_export parameter and update all callers.
>...

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4323 - trunk/subversion/clients/cmdline

Posted by Matt Kraai <kr...@alumni.cmu.edu>.
On Fri, Jan 10, 2003 at 01:29:40PM -0800, Greg Stein wrote:
> You inserted some tabs into (at least) feedback.c.

Fixed (and configured my editor to prevent me from doing so in the
future).

Matt

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4323 - trunk/subversion/clients/cmdline

Posted by Michael Price <mp...@atl.lmco.com>.
Greg Stein writes:
 > You inserted some tabs into (at least) feedback.c.
 > 
 > Cheers,
 > -g
 > 
 > /me thinks about a pre-commit hook to disallow .[ch] files with tabs... :-)

I've enforced an indentation policy before with emacs in batch mode
doing roughly the following on each file:

      (find-file source)
      (untabify (point-min) (point-max))
      (indent-region (point-min) (point-max) nil)
      (delete-trailing-whitespace)
      (write-file source))

Slow but works.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Precommit hook preventing tabs, WAS: RE: svn commit: rev 4323 - trunk/subversion/clients/cmdline

Posted by Sander Striker <st...@apache.org>.
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Friday, January 10, 2003 10:30 PM

> You inserted some tabs into (at least) feedback.c.
> 
> Cheers,
> -g
> 
> /me thinks about a pre-commit hook to disallow .[ch] files with tabs... :-)

+1 !!

Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org