[GitHub] [cassandra] bschoening commented on pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

[GitBox <gi...@apache.org>]

bschoening commented on PR #1973:
URL: https://github.com/apache/cassandra/pull/1973#issuecomment-1371413472

   Yeah, that's inconsistent.  Jira 18006 was closed as a duplicate, however.
   It looks like this PR just wasn't closed.
   
   Btw, I'd like to upgrade CQLSH from optparse to argparse, but I've tried
   twice and the code is just too convoluted for me to figure it out thus far.
   
   On Wed, Jan 4, 2023 at 3:30 PM Jeff Widman ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In pylib/cqlshlib/cqlshhandling.py
   > <https://github.com/apache/cassandra/pull/1973#discussion_r1061858463>:
   >
   > > @@ -141,7 +141,7 @@ def registrator(f):
   >  '''
   >
   >  cqlsh_capture_cmd_syntax_rules = r'''
   > -<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral> | "OFF" ) )?
   > +<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral>) | "OFF" )?
   >
   > The spaces between parens are inconsistent here: ( <stringLiteral>)
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/cassandra/pull/1973#pullrequestreview-1236442070>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABMHGVELXC46JLBSOYGAEZ3WQXMVRANCNFSM6AAAAAARXPBHSI>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org