You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2012/04/29 22:56:18 UTC
svn commit: r1331995 - /ofbiz/trunk/build.xml
Author: jleroux
Date: Sun Apr 29 20:56:17 2012
New Revision: 1331995
URL: http://svn.apache.org/viewvc?rev=1331995&view=rev
Log:
-XX:+HeapDumpOnOutOfMemoryError may turn useful sometimes
Modified:
ofbiz/trunk/build.xml
Modified: ofbiz/trunk/build.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1331995&r1=1331994&r2=1331995&view=diff
==============================================================================
--- ofbiz/trunk/build.xml (original)
+++ ofbiz/trunk/build.xml Sun Apr 29 20:56:17 2012
@@ -383,6 +383,7 @@ under the License.
<jvmarg value="${memory.initial.param}"/>
<jvmarg value="${pos.memory.max.param}"/>
<jvmarg value="${memory.maxpermsize.param}"/>
+ <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
</java>
</target>
<target name="start-batch"
@@ -391,6 +392,7 @@ under the License.
<jvmarg value="${memory.initial.param}"/>
<jvmarg value="${pos.memory.max.param}"/>
<jvmarg value="${memory.maxpermsize.param}"/>
+ <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
</java>
</target>
<target name="start-debug"
@@ -403,6 +405,7 @@ under the License.
<jvmarg value="-Djava.compiler=NONE"/>
<jvmarg value="-Xdebug"/>
<jvmarg value="-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8091"/>
+ <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
</java>
</target>
<target name="start-pos"
@@ -411,6 +414,7 @@ under the License.
<jvmarg value="${memory.initial.param}"/>
<jvmarg value="${memory.max.param}"/>
<jvmarg value="${memory.maxpermsize.param}"/>
+ <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
<arg value="pos"/>
</java>
</target>
Re: svn commit: r1331995 - /ofbiz/trunk/build.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
OK you are both right (though I don't think this one does not put any harms on performance or ressources).
Then we need a mean to pass parameters through ant start target : http://ant.apache.org/manual/Tasks/property.html
Jacques
From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
> Yeah,
>
> there are several -XX parameters that are useful when you analyze issues or memory leaks etc... but it doesn't mean that they have
> to be enabled by default.
>
> Jacopo
>
> On Apr 29, 2012, at 11:36 PM, Pierre Smits wrote:
>
>> Jacques,
>>
>> I agree that setting the HeadDumpOnOutOfMemmoryError occasionally can
>> prove usefull, but shouldn't an update of document be enough to create
>> the awareness?
>>
>> Adding the code change kinda contradicts your statement and makes it
>> permanent and always on
>>
>> Regards,
>>
>> Pierre
>>
>> 2012/4/29 <jl...@apache.org>:
>>> Author: jleroux
>>> Date: Sun Apr 29 20:56:17 2012
>>> New Revision: 1331995
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1331995&view=rev
>>> Log:
>>> -XX:+HeapDumpOnOutOfMemoryError may turn useful sometimes
>>>
>>> Modified:
>>> ofbiz/trunk/build.xml
>>>
>>> Modified: ofbiz/trunk/build.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1331995&r1=1331994&r2=1331995&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/build.xml (original)
>>> +++ ofbiz/trunk/build.xml Sun Apr 29 20:56:17 2012
>>> @@ -383,6 +383,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${pos.memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-batch"
>>> @@ -391,6 +392,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${pos.memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-debug"
>>> @@ -403,6 +405,7 @@ under the License.
>>> <jvmarg value="-Djava.compiler=NONE"/>
>>> <jvmarg value="-Xdebug"/>
>>> <jvmarg value="-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8091"/>
>>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-pos"
>>> @@ -411,6 +414,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> <arg value="pos"/>
>>> </java>
>>> </target>
>>>
>>>
>
>
Re: svn commit: r1331995 - /ofbiz/trunk/build.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
From my perspective, this is the same concept as the port settings -
provide some basic defaults and let users change them with patches. If I
want to enable memory dumps on my local copy, then I can apply a patch
that turns them on.
Indeed, I have a patch called local-dev that configures a number of
things to make my job easier. But that patch represents my personal
preferences, so it is not something that I would commit to the trunk.
-Adrian
On 4/30/2012 6:26 AM, Jacopo Cappellato wrote:
> Yeah,
>
> there are several -XX parameters that are useful when you analyze issues or memory leaks etc... but it doesn't mean that they have to be enabled by default.
>
> Jacopo
>
> On Apr 29, 2012, at 11:36 PM, Pierre Smits wrote:
>
>> Jacques,
>>
>> I agree that setting the HeadDumpOnOutOfMemmoryError occasionally can
>> prove usefull, but shouldn't an update of document be enough to create
>> the awareness?
>>
>> Adding the code change kinda contradicts your statement and makes it
>> permanent and always on
>>
>> Regards,
>>
>> Pierre
>>
>> 2012/4/29<jl...@apache.org>:
>>> Author: jleroux
>>> Date: Sun Apr 29 20:56:17 2012
>>> New Revision: 1331995
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1331995&view=rev
>>> Log:
>>> -XX:+HeapDumpOnOutOfMemoryError may turn useful sometimes
>>>
>>> Modified:
>>> ofbiz/trunk/build.xml
>>>
>>> Modified: ofbiz/trunk/build.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1331995&r1=1331994&r2=1331995&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/build.xml (original)
>>> +++ ofbiz/trunk/build.xml Sun Apr 29 20:56:17 2012
>>> @@ -383,6 +383,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${pos.memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> +<jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-batch"
>>> @@ -391,6 +392,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${pos.memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> +<jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-debug"
>>> @@ -403,6 +405,7 @@ under the License.
>>> <jvmarg value="-Djava.compiler=NONE"/>
>>> <jvmarg value="-Xdebug"/>
>>> <jvmarg value="-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8091"/>
>>> +<jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> </java>
>>> </target>
>>> <target name="start-pos"
>>> @@ -411,6 +414,7 @@ under the License.
>>> <jvmarg value="${memory.initial.param}"/>
>>> <jvmarg value="${memory.max.param}"/>
>>> <jvmarg value="${memory.maxpermsize.param}"/>
>>> +<jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>>> <arg value="pos"/>
>>> </java>
>>> </target>
>>>
>>>
Re: svn commit: r1331995 - /ofbiz/trunk/build.xml
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Yeah,
there are several -XX parameters that are useful when you analyze issues or memory leaks etc... but it doesn't mean that they have to be enabled by default.
Jacopo
On Apr 29, 2012, at 11:36 PM, Pierre Smits wrote:
> Jacques,
>
> I agree that setting the HeadDumpOnOutOfMemmoryError occasionally can
> prove usefull, but shouldn't an update of document be enough to create
> the awareness?
>
> Adding the code change kinda contradicts your statement and makes it
> permanent and always on
>
> Regards,
>
> Pierre
>
> 2012/4/29 <jl...@apache.org>:
>> Author: jleroux
>> Date: Sun Apr 29 20:56:17 2012
>> New Revision: 1331995
>>
>> URL: http://svn.apache.org/viewvc?rev=1331995&view=rev
>> Log:
>> -XX:+HeapDumpOnOutOfMemoryError may turn useful sometimes
>>
>> Modified:
>> ofbiz/trunk/build.xml
>>
>> Modified: ofbiz/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1331995&r1=1331994&r2=1331995&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/build.xml (original)
>> +++ ofbiz/trunk/build.xml Sun Apr 29 20:56:17 2012
>> @@ -383,6 +383,7 @@ under the License.
>> <jvmarg value="${memory.initial.param}"/>
>> <jvmarg value="${pos.memory.max.param}"/>
>> <jvmarg value="${memory.maxpermsize.param}"/>
>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>> </java>
>> </target>
>> <target name="start-batch"
>> @@ -391,6 +392,7 @@ under the License.
>> <jvmarg value="${memory.initial.param}"/>
>> <jvmarg value="${pos.memory.max.param}"/>
>> <jvmarg value="${memory.maxpermsize.param}"/>
>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>> </java>
>> </target>
>> <target name="start-debug"
>> @@ -403,6 +405,7 @@ under the License.
>> <jvmarg value="-Djava.compiler=NONE"/>
>> <jvmarg value="-Xdebug"/>
>> <jvmarg value="-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8091"/>
>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>> </java>
>> </target>
>> <target name="start-pos"
>> @@ -411,6 +414,7 @@ under the License.
>> <jvmarg value="${memory.initial.param}"/>
>> <jvmarg value="${memory.max.param}"/>
>> <jvmarg value="${memory.maxpermsize.param}"/>
>> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
>> <arg value="pos"/>
>> </java>
>> </target>
>>
>>
Re: svn commit: r1331995 - /ofbiz/trunk/build.xml
Posted by Pierre Smits <pi...@gmail.com>.
Jacques,
I agree that setting the HeadDumpOnOutOfMemmoryError occasionally can
prove usefull, but shouldn't an update of document be enough to create
the awareness?
Adding the code change kinda contradicts your statement and makes it
permanent and always on
Regards,
Pierre
2012/4/29 <jl...@apache.org>:
> Author: jleroux
> Date: Sun Apr 29 20:56:17 2012
> New Revision: 1331995
>
> URL: http://svn.apache.org/viewvc?rev=1331995&view=rev
> Log:
> -XX:+HeapDumpOnOutOfMemoryError may turn useful sometimes
>
> Modified:
> ofbiz/trunk/build.xml
>
> Modified: ofbiz/trunk/build.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1331995&r1=1331994&r2=1331995&view=diff
> ==============================================================================
> --- ofbiz/trunk/build.xml (original)
> +++ ofbiz/trunk/build.xml Sun Apr 29 20:56:17 2012
> @@ -383,6 +383,7 @@ under the License.
> <jvmarg value="${memory.initial.param}"/>
> <jvmarg value="${pos.memory.max.param}"/>
> <jvmarg value="${memory.maxpermsize.param}"/>
> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
> </java>
> </target>
> <target name="start-batch"
> @@ -391,6 +392,7 @@ under the License.
> <jvmarg value="${memory.initial.param}"/>
> <jvmarg value="${pos.memory.max.param}"/>
> <jvmarg value="${memory.maxpermsize.param}"/>
> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
> </java>
> </target>
> <target name="start-debug"
> @@ -403,6 +405,7 @@ under the License.
> <jvmarg value="-Djava.compiler=NONE"/>
> <jvmarg value="-Xdebug"/>
> <jvmarg value="-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8091"/>
> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
> </java>
> </target>
> <target name="start-pos"
> @@ -411,6 +414,7 @@ under the License.
> <jvmarg value="${memory.initial.param}"/>
> <jvmarg value="${memory.max.param}"/>
> <jvmarg value="${memory.maxpermsize.param}"/>
> + <jvmarg value="-XX:+HeapDumpOnOutOfMemoryError"/>
> <arg value="pos"/>
> </java>
> </target>
>
>