[jira] [Commented] (BOOKKEEPER-747) Implement register/unregister LedgerMetadataListener in MSLedgerManagerFactory

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990974#comment-13990974 ] 

Rakesh R commented on BOOKKEEPER-747:
-------------------------------------

Thanks [~fpj]. Patch looks fine. I've few minor comments, please see:
# Should we synchronize 'listenerSet' iteration ?
{code}
+                            public void run() {
+                                for (LedgerMetadataListener listener : listenerSet) {
+                                    listener.onChanged(ledgerId, result);
+                                }
+                            }
{code}
# Missing thread name
{code}
new ReadLedgerMetadataTask(key2LedgerId(e.getKey())).run();
{code}
# Remove spaces in new lines. Following are few of them, pls remove all such cases.
{code}
+    static int MS_CONNECT_BACKOFF_MS = 200;
+    
{code}
{code}
         ScheduledExecutorService scheduler;
+        
{code}
{code}
+                new ReadLedgerMetadataTask(key2LedgerId(e.getKey())).run();
+                
{code}

-Rakesh

> Implement register/unregister LedgerMetadataListener in MSLedgerManagerFactory
> ------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-747
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-747
>             Project: Bookkeeper
>          Issue Type: Improvement
>    Affects Versions: 4.3.0, 4.2.3
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 4.3.0, 4.2.3
>
>         Attachments: BOOKKEEPER-747-4.2.patch, BOOKKEEPER-747.patch, BOOKKEEPER-747.patch, BOOKKEEPER-747.patch
>
>
> Check TODOs in MSLedgerManagerFactory.



--
This message was sent by Atlassian JIRA
(v6.2#6252)