You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Riley Patterson (JIRA)" <ji...@apache.org> on 2011/08/19 03:22:27 UTC
[jira] [Created] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
----------------------------------------------------------------
Key: HBASE-4229
URL: https://issues.apache.org/jira/browse/HBASE-4229
Project: HBase
Issue Type: Improvement
Components: wal
Reporter: Riley Patterson
Assignee: Riley Patterson
Priority: Trivial
HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087558#comment-13087558 ]
stack commented on HBASE-4229:
------------------------------
Just to say that all tests pass for me with this patch in place.
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088252#comment-13088252 ]
Andrew Purtell commented on HBASE-4229:
---------------------------------------
+1
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087497#comment-13087497 ]
stack commented on HBASE-4229:
------------------------------
I am +1 on the patch. It looks great. Thanks for going back and retrofitting.
I'm letting this patch hang a while because it would be good if Andrew took a looksee.
Meantime running tests to make sure avro or rest don't barf.
Good one Riley.
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4229:
-------------------------
Fix Version/s: 0.92.0
Status: Patch Available (was: Open)
Marking patch available
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088592#comment-13088592 ]
Hudson commented on HBASE-4229:
-------------------------------
Integrated in HBase-TRUNK #2127 (See [https://builds.apache.org/job/HBase-TRUNK/2127/])
HBASE-4229 Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/bin/add_table.rb
* /hbase/trunk/pom.xml
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4229:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thanks for the patch Riley. Applied to TRUNK.
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4229) Replace Jettison JSON encoding with
Jackson in HLogPrettyPrinter
Posted by "Riley Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Riley Patterson updated HBASE-4229:
-----------------------------------
Attachment: HBASE-4229.patch
Also added jackson directly to our dependencies in pom.xml to guarantee that we get the same versions of the various jars. Avro and Jersey were bringing in different, incompatible versions and causing problems.
> Replace Jettison JSON encoding with Jackson in HLogPrettyPrinter
> ----------------------------------------------------------------
>
> Key: HBASE-4229
> URL: https://issues.apache.org/jira/browse/HBASE-4229
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Riley Patterson
> Assignee: Riley Patterson
> Priority: Trivial
> Attachments: HBASE-4229.patch
>
>
> HBase makes use of both jackson (in the region server) and jettison (in HLogPrettyPrinter) for JSON encoding. Jackson seems to be better maintained, so this patch standardizes by using jackson in HLogPrettyPrinter instead of jettison.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira