You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2016/11/09 15:20:58 UTC
Review Request 53609: HIVE-15168: Flaky test:
TestSparkClient.testJobSubmission (still flaky)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/
-----------------------------------------------------------
Review request for hive, Rui Li and Xuefu Zhang.
Repository: hive-git
Description
-------
HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
Diffs
-----
spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c
spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc
spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b
Diff: https://reviews.apache.org/r/53609/diff/
Testing
-------
Ran modified unit tests / tests of the modified classes.
Ran simple queries with spark as the execution engine.
Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds in the ClientProtocol#submit.
Thanks,
Barna Zsombor Klara
Re: Review Request 53609: HIVE-15168: Flaky test:
TestSparkClient.testJobSubmission (still flaky)
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/#review155572
-----------------------------------------------------------
Ship it!
Thanks for the patch!
- Peter Vary
On nov. 10, 2016, 10:31 de, Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53609/
> -----------------------------------------------------------
>
> (Updated nov. 10, 2016, 10:31 de)
>
>
> Review request for hive, Rui Li and Xuefu Zhang.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
>
>
> Diffs
> -----
>
> spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c
> spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc
> spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b
>
> Diff: https://reviews.apache.org/r/53609/diff/
>
>
> Testing
> -------
>
> Ran modified unit tests / tests of the modified classes.
> Ran simple queries with spark as the execution engine.
> Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds in the ClientProtocol#submit.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 53609: HIVE-15168: Flaky test:
TestSparkClient.testJobSubmission (still flaky)
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/
-----------------------------------------------------------
(Updated Nov. 10, 2016, 10:31 a.m.)
Review request for hive, Rui Li and Xuefu Zhang.
Changes
-------
Javadocs fixed as per review request.
Repository: hive-git
Description
-------
HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
Diffs (updated)
-----
spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c
spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc
spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b
Diff: https://reviews.apache.org/r/53609/diff/
Testing
-------
Ran modified unit tests / tests of the modified classes.
Ran simple queries with spark as the execution engine.
Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds in the ClientProtocol#submit.
Thanks,
Barna Zsombor Klara
Re: Review Request 53609: HIVE-15168: Flaky test:
TestSparkClient.testJobSubmission (still flaky)
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
> On Nov. 9, 2016, 4:48 p.m., Peter Vary wrote:
> > spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java, line 39
> > <https://reviews.apache.org/r/53609/diff/1/?file=1559404#file1559404line39>
> >
> > nit: Is this import is used after this change?
Yes, Future is still being used.
- Barna Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/#review155444
-----------------------------------------------------------
On Nov. 9, 2016, 3:20 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53609/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2016, 3:20 p.m.)
>
>
> Review request for hive, Rui Li and Xuefu Zhang.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
>
>
> Diffs
> -----
>
> spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c
> spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc
> spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b
>
> Diff: https://reviews.apache.org/r/53609/diff/
>
>
> Testing
> -------
>
> Ran modified unit tests / tests of the modified classes.
> Ran simple queries with spark as the execution engine.
> Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds in the ClientProtocol#submit.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 53609: HIVE-15168: Flaky test:
TestSparkClient.testJobSubmission (still flaky)
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/#review155444
-----------------------------------------------------------
Thanks Zsombor for the fix! One more down, but waaaay much to go :)
Just minor nits.
spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java (line 255)
<https://reviews.apache.org/r/53609/#comment225407>
nit: Please change the comment to match the new signature
spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java (line 263)
<https://reviews.apache.org/r/53609/#comment225408>
nit: Please change the comment to match the new signature
spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java (line 280)
<https://reviews.apache.org/r/53609/#comment225410>
nit: Please change the comment to match the new signature
spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java (line 39)
<https://reviews.apache.org/r/53609/#comment225411>
nit: Is this import is used after this change?
- Peter Vary
On Nov. 9, 2016, 3:20 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53609/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2016, 3:20 p.m.)
>
>
> Review request for hive, Rui Li and Xuefu Zhang.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
>
>
> Diffs
> -----
>
> spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c
> spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc
> spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b
>
> Diff: https://reviews.apache.org/r/53609/diff/
>
>
> Testing
> -------
>
> Ran modified unit tests / tests of the modified classes.
> Ran simple queries with spark as the execution engine.
> Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds in the ClientProtocol#submit.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>