You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 22:52:00 UTC
[jira] [Commented] (DRILL-6323) Lateral Join - Initial
implementation
[ https://issues.apache.org/jira/browse/DRILL-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440134#comment-16440134 ]
ASF GitHub Bot commented on DRILL-6323:
---------------------------------------
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1212
DRILL-6323: Lateral Join - Initial implementation
@parthchandra - Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/drill DRILL-6323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1212
----
commit 38b82ce8ebca3b91ba8847229a568daf88f654a3
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-03-06T05:09:16Z
DRILL-6323: Lateral Join - Initial implementation
Refactor Join PopConfigs
commit 0931ac974f7be41cd5ca4516524d04c4e5c6245d
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-02-05T22:46:19Z
DRILL-6323: Lateral Join - Initial implementation
commit 08b7d38e6ffe4fed492a2ea67c3907f0f514717e
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-02-20T22:47:48Z
DRILL-6323: Lateral Join - Initial implementation
Note: Refactor, fix various issues with LATERAL: a)Override prefetch call in BuildSchema phase for LATERAL, b)EMIT handling in buildSchema, c)Issue when in multilevel Lateral case
schema change is observed only on right side of UNNEST, d)Handle SelectionVector in incoming batch, e) Handling Schema change, f) Updating joinIndexes correctly when producing multiple output batches
for current left&right inputs.
Added tests for a)EMIT handling in buildSchema, b)Multiple UNNEST at same level, c)Multilevel Lateral, d)Multilevel Lateral with Schema change on left/right or both branches, e) Left LATERAL join
f)Schema change for UNNEST and Non-UNNEST columns, g)Error outcomes from left&right, h) Producing multiple output batches for given incoming, i) Consuming multiple incoming into single output batch
commit f686877198857a23227031329b2f48c163f85021
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-03-09T23:56:22Z
DRILL-6323: Lateral Join - Initial implementation
Note: Remove codegen and operator template class. Logic to copy data is moved to LateralJoinBatch itself
commit cb47407a8f47e7fc10ac04c438f7e903de92a80c
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-03-13T23:41:03Z
DRILL-6323: Lateral Join - Initial implementation
Note: Add some debug logs for LateralJoinBatch
commit 2ea968e3302ad8bb6d62a8032bd6b6329b900d3a
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-03-14T23:59:29Z
DRILL-6323: Lateral Join - Initial implementation
Note: Refactor BatchMemorySize to put outputBatchSize in abstract class. Created a new JoinBatchMemoryManager to be shared across join record batches.
Changed merge join to use AbstractBinaryRecordBatch instead of AbstractRecordBatch, and use JoinBatchMemoryManager
commit fb521c65f91b69543ae9b5dbb9a727c79f852573
Author: Sorabh Hamirwasia <sh...@...>
Date: 2018-03-19T19:00:22Z
DRILL-6323: Lateral Join - Initial implementation
Note: Lateral Join Batch Memory manager support using the record batch sizer
----
> Lateral Join - Initial implementation
> -------------------------------------
>
> Key: DRILL-6323
> URL: https://issues.apache.org/jira/browse/DRILL-6323
> Project: Apache Drill
> Issue Type: Task
> Reporter: Parth Chandra
> Priority: Major
>
> Implementation of Lateral Join with unit tests using MockRecordBatch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)