You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/16 01:57:06 UTC

[GitHub] [flink] xuyangzhong commented on a change in pull request #17733: [FLINK-24835][table-planner] Fix bug in `RelTimeIndicatorConverter` when materialize time attribute fields of regular join's inputs

xuyangzhong commented on a change in pull request #17733:
URL: https://github.com/apache/flink/pull/17733#discussion_r749839357



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/IntervalJoinUtil.scala
##########
@@ -450,15 +452,26 @@ object IntervalJoinUtil {
    *         else false.
    */
   def satisfyIntervalJoin(join: FlinkLogicalJoin): Boolean = {
+    satisfyIntervalJoin(join, join.getLeft, join.getRight)

Review comment:
       It seems that only one place holds this old function, why not delete it and use the new function format everywhere?

##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowJoinUtil.scala
##########
@@ -60,7 +61,11 @@ object WindowJoinUtil extends Logging {
    *         ends equality of input tables, else false.
    */
   def satisfyWindowJoin(join: FlinkLogicalJoin): Boolean = {
-    excludeWindowStartEqualityAndEndEqualityFromJoinInfoPairs(join) match {
+    satisfyWindowJoin(join, join.getLeft, join.getRight)

Review comment:
       ditto. It is used in two place.

##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/TemporalJoinUtil.scala
##########
@@ -424,10 +425,14 @@ object TemporalJoinUtil {
    *         else false.
    */
   def satisfyTemporalJoin(join: FlinkLogicalJoin): Boolean = {
+    satisfyTemporalJoin(join, join.getLeft, join.getRight)

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org