You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/03 15:19:09 UTC

[GitHub] [pulsar] jiazhai commented on a change in pull request #4866: [Transaction][buffer] Add new commands for the transaction

jiazhai commented on a change in pull request #4866: [Transaction][buffer] Add new commands for the transaction
URL: https://github.com/apache/pulsar/pull/4866#discussion_r310354668
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -23,42 +23,42 @@ option java_package = "org.apache.pulsar.common.api.proto";
 option optimize_for = LITE_RUNTIME;
 
 message Schema {
-	enum Type {
 
 Review comment:
   Seems most of the changes in this file is the code alignment change. I would suggest keep the original format, so it would be easy to find what is really changed for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services