You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/22 16:45:19 UTC
[GitHub] [spark] mridulm commented on a change in pull request #30876: [SPARK-33870][CORE] Enable spark.storage.replication.proactive by default
mridulm commented on a change in pull request #30876:
URL: https://github.com/apache/spark/pull/30876#discussion_r547383304
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -384,7 +384,7 @@ package object config {
"get the replication level of the block to the initial number")
.version("2.2.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review comment:
I am not sure how widely this is used, particularly as it is not enabled by default.
Especially in context of dynamic resource allocation, it can become very chatty when executor's start getting dropped.
Given this, I am not very keen on enabling it atleast for yarn. Thoughts @tgravescs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org