You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by gm...@apache.org on 2017/09/28 18:54:32 UTC

qpid-dispatch git commit: DISPATCH-819 - Added a deliberate void in front of pn_link_send showing that we are not handling the return value

Repository: qpid-dispatch
Updated Branches:
  refs/heads/master 34b202d1a -> 29c53e5e1


DISPATCH-819 - Added a deliberate void in front of pn_link_send showing that we are not handling the return value


Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/29c53e5e
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/29c53e5e
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/29c53e5e

Branch: refs/heads/master
Commit: 29c53e5e12b9234ed3d0e7db59620379fee13175
Parents: 34b202d
Author: Ganesh Murthy <gm...@redhat.com>
Authored: Thu Sep 28 14:54:18 2017 -0400
Committer: Ganesh Murthy <gm...@redhat.com>
Committed: Thu Sep 28 14:54:18 2017 -0400

----------------------------------------------------------------------
 src/message.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/29c53e5e/src/message.c
----------------------------------------------------------------------
diff --git a/src/message.c b/src/message.c
index 8d31c08..6bf5691 100644
--- a/src/message.c
+++ b/src/message.c
@@ -1509,8 +1509,8 @@ void qd_message_send(qd_message_t *in_msg,
         // This will send the remaining data in the buffer if any.
         int num_bytes_to_send = buf_size - (msg->cursor.cursor - qd_buffer_base(buf));
         if (num_bytes_to_send > 0) {
-            pn_link_send(pnl, (const char*)msg->cursor.cursor, num_bytes_to_send);
-            // TODO: DISPATCH-819 check pn_link_send return value
+            // We are deliberately avoiding the return value of pn_link_send because we can't do anything nice with it.
+            (void) pn_link_send(pnl, (const char*)msg->cursor.cursor, num_bytes_to_send);
         }
 
         // If the entire message has already been received,  taking out this lock is not that expensive


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org