You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Joseph Pachod (JIRA)" <ji...@apache.org> on 2010/04/02 23:19:27 UTC

[jira] Updated: (WICKET-2820) change the Checkbox's onSelectionChanged to have a Boolean as the new selection

     [ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joseph Pachod updated WICKET-2820:
----------------------------------

    Attachment: checkBoxOnSelectionChangedBoolean.txt

a (very simple) patch for resolving the issue

> change the Checkbox's onSelectionChanged to have a Boolean as the new selection
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-2820
>                 URL: https://issues.apache.org/jira/browse/WICKET-2820
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Joseph Pachod
>         Attachments: checkBoxOnSelectionChangedBoolean.txt
>
>
> The checkbox is defined as class CheckBox extends FormComponent<Boolean>
> However, onSelectionChanged works with an object.
> It could easily changed to a Boolean, making it clearer.
> I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...).
> On a side note, the Javadoc for "onSelectionChanged" should also be corrected. It currently speaks of "dropdown list".
> thanks in advance
> joseph

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.