[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7892: return 503 response from health check on shut down

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r771018633



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##########
@@ -85,6 +85,8 @@
   protected String _hostname;
   protected int _port;
   protected String _instanceId;
+  private boolean _isStarting = false;

Review comment:
       They might need to be `volatile` as they can be accessed from a different thread

##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -61,7 +61,9 @@ public String getBrokerHealth() {
       return "OK";
     }
     _brokerMetrics.addMeteredGlobalValue(BrokerMeter.HEALTHCHECK_BAD_CALLS, 1);
-    throw new WebApplicationException(String.format("Pinot broker status is %s", status),
-        Response.Status.SERVICE_UNAVAILABLE);
+    Response response =

Review comment:
       Any specific reason for this change? I think we are using the constructor from the original code in a lot of places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org