You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Dinyar Rabady (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 10:15:17 UTC
[jira] [Created] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
In DSNBounce the exception handling is mixed up for setting Remote Address and Host
-----------------------------------------------------------------------------------
Key: MAILETSTANDARD-12
URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
Project: JAMES Standard Mailets
Issue Type: Bug
Affects Versions: 1.0
Reporter: Dinyar Rabady
Assignee: Robert Burrell Donkin
Priority: Trivial
In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
Posted by "Dinyar Rabady (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257501#comment-13257501 ]
Dinyar Rabady commented on MAILETSTANDARD-12:
---------------------------------------------
Hi Eric,
I might be wrong, but the current way the code is written the setRemoveAddr method is passed the host name, while the setRemoteHost method is passed an address. I'm not aware that this leads to any errors, it just struck me while reading the source. The suggestion to swap the lines came after a very quick scan, the patch applies the correct change however by only swapping the method calls in the try blocks.
> In DSNBounce the exception handling is mixed up for setting Remote Address and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Robert Burrell Donkin
> Priority: Trivial
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Updated] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
Posted by "Dinyar Rabady (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dinyar Rabady updated MAILETSTANDARD-12:
----------------------------------------
Attachment: james_patch.diff
It seems I was mistaken about swapping the lines. I think it is only necessary to swap the function calls in the try block.
> In DSNBounce the exception handling is mixed up for setting Remote Address and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Robert Burrell Donkin
> Priority: Trivial
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
Posted by "Eric Charles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258221#comment-13258221 ]
Eric Charles commented on MAILETSTANDARD-12:
--------------------------------------------
Ok, got it Dinyar, you've got good eyes :)
Thx for the explanation, I will commit your patch, Eric
> In DSNBounce the exception handling is mixed up for setting Remote Address and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Robert Burrell Donkin
> Priority: Trivial
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
Posted by "Eric Charles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257467#comment-13257467 ]
Eric Charles commented on MAILETSTANDARD-12:
--------------------------------------------
Hi Dinyar,
Thx for the patch.
Can you tell us more how the line swapping will bring a positive effect?
Eric
> In DSNBounce the exception handling is mixed up for setting Remote Address and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Robert Burrell Donkin
> Priority: Trivial
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Closed] (MAILETSTANDARD-12) In DSNBounce the exception
handling is mixed up for setting Remote Address and Host
Posted by "Eric Charles (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Charles closed MAILETSTANDARD-12.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1
Assignee: Eric Charles (was: Robert Burrell Donkin)
Committed, Thx Dinyar.
> In DSNBounce the exception handling is mixed up for setting Remote Address and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Eric Charles
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org