[GitHub] [hive] b-slim commented on a change in pull request #643: Hive 21785: Add task queue/runtime stats per LLAP daemon to output

[GitBox <gi...@apache.org>]

b-slim commented on a change in pull request #643: Hive 21785: Add task queue/runtime stats per LLAP daemon to output
URL: https://github.com/apache/hive/pull/643#discussion_r288245325
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/counters/WmFragmentCounters.java
 ##########
 @@ -119,6 +123,21 @@ public void dumpToTezCounters(TezCounters tezCounters, boolean isLast) {
     for (int i = 0; i < fixedCounters.length(); ++i) {
       tezCounters.findCounter(LlapWmCounters.values()[i]).setValue(fixedCounters.get(i));
     }
+
+    // add queue and runtime (together with task count) on a "per daemon" level
+    // to the Tez counters.
+    if (addTaskTimeCounters) {
+      String hostName = MetricsUtils.getHostName();
+      long queued = fixedCounters.get(LlapWmCounters.GUARANTEED_QUEUED_NS.ordinal())
+                    + fixedCounters.get(LlapWmCounters.SPECULATIVE_QUEUED_NS.ordinal());
+      long running = fixedCounters.get(LlapWmCounters.GUARANTEED_RUNNING_NS.ordinal())
+                     + fixedCounters.get(LlapWmCounters.SPECULATIVE_RUNNING_NS.ordinal());
+
+      CounterGroup cg =tezCounters.getGroup("LlapTaskRuntimeAgg by daemon");
 
 Review comment:
   i think style is off here i see a missing space after `=`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org