You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ufuk Celebi (JIRA)" <ji...@apache.org> on 2016/02/29 10:20:18 UTC
[jira] [Closed] (FLINK-3461) Remove duplicate condition check in
ZooKeeperLeaderElectionService
[ https://issues.apache.org/jira/browse/FLINK-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ufuk Celebi closed FLINK-3461.
------------------------------
Resolution: Fixed
Fix Version/s: 1.1.0
1.0.1
Fixed in febcb7f, 4906982 (master).
Fixed in 945f25b (release-1.0)
> Remove duplicate condition check in ZooKeeperLeaderElectionService
> ------------------------------------------------------------------
>
> Key: FLINK-3461
> URL: https://issues.apache.org/jira/browse/FLINK-3461
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Priority: Trivial
> Fix For: 1.0.1, 1.1.0
>
>
> In {{ZooKeeperLeaderElectionService}}:
> {code}
> @Override
> public boolean hasLeadership() {
> if(leaderLatch.getState().equals(LeaderLatch.State.STARTED)) {
> return leaderLatch.hasLeadership();
> } else {
> return false;
> }
> }
> {code}
> Looking into the leader {{leaderLatch.hasLeadership()}}, the state gets checked already/again.
> {code}
> return (state.get() == State.STARTED) && hasLeadership.get();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)