You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 12:44:47 UTC
[GitHub] [flink] zentol opened a new pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
zentol opened a new pull request #12172:
URL: https://github.com/apache/flink/pull/12172
Migrates e2e tests relying on flink-container/docker to [flink-docker|https://github.com/apache/flink-docker].
The changes mostly cover how the Docker image is built.
We now first create a custom Dockerfile, by checking out `flink-docker/dev-master` and using the `add-custom.sh` script. This requires the distribution to be accessible from some URL, so we tar the locally built distribution and server it with a local python webserver.
For job clusters, instead of backing in the job artifacts into the image we now use instead mount them into the `usrlib` directory, which is the new default approach.
Some arguments had to be modified, since `flink-docker` closely follows the existing CLI scripts, which flink-container/docker did not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
* 8c64d694ff984b32600338bfe657960e92ad1ee9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14729456edcc4d18f392dde05c5afe20fe787dd9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59d7735635b83251b862eeedef8af62662dd0919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540)
* acad8ebc3f6f4c834a15dab61b7167280d09454f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434)
* 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12172:
URL: https://github.com/apache/flink/pull/12172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426154375
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
My concern is not the cleanup of files; the archive and git clone are placed under `TEST_DATA_DIR` which is cleaned up anyway.
I'm only concerned about the fileserver process; you definitely don't want that one leaking, since it could affect the correctness of subsequent runs.
So as I said, it would need more work to be in a state where I would offer it to other people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425833911
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
maybe, I'm not so sure about it. On the one hand there are some environmental dependencies (see above) and you would need to harden it way more to ensure cleanup of resources (which I'd prefer not to do atm).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629217287
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7 (Fri May 15 12:49:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426154414
##########
File path: flink-end-to-end-tests/test-scripts/container-scripts/docker-compose.test.yml
##########
@@ -16,15 +16,31 @@
# limitations under the License.
################################################################################
-# Extensions to flink-container/docker/docker-compose.yml that mounts volumes needed for tests
+# Docker compose file for a Flink job cluster deployment.
+#
+# Parameters:
+# * FLINK_DOCKER_IMAGE_NAME - Image name to use for the deployment (default: flink-job:latest)
Review comment:
This was also copied as is from `flink-container/docker/docker-compose.yml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425837430
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
Given that we are primarily interested in the running on CI I'm fine with the current state.
For the general case it can blow up in any case since you can't guarantee python (2 or 3) to exist at all; the only safe solution being a pure bash/java version, bash naturally not being realistic option and Java not really being worth the additional effort, and it would also make it way harder to offer a script in that case.
Originally I wanted to serve things via netcat but it didn't quite work.
Dockerizing this one thing seems a bit overkill to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452)
* 73043891f8468782029ce5abe63a3d1ed29ea09e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426154375
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
My concern is not the cleanup of files; the archive and git clone are placed under `TEST_DATA_DIR` which is cleaned up anyway.
I'm only concerned about the fileserver process; you definitely don't want that one leaking since it could affect the correctness of subsequent runs.
So as I said, it would need more work to be in a state where I would offer it to other people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
}, {
"hash" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628",
"triggerID" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da355ac23cca4c125508f661d9d6d16416ced16b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426168609
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
I'd prefer not having to download another 60mb for this menial task; that alone would imo discard it as a viable option as a utility sript.
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
I'd prefer not having to download another 60mb for this menial task; that alone would imo discard it as a viable option as a utility script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425818508
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
This doesn't work with python3 anymore. Python 2 support has been discontinued.
I'm a bit concerned that this blows up at some point. We could add a python version check, and use the equivalent python 3 call (`python3 -m http.server`), download a python binary from somewhere, dockerize it? ...
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
This mechanism is quite useful for developers of Flink. Does it make sense to move this code into a script in "flink-docker.git" and use this here?
```bash
git clone https://github.com/apache/flink-docker.git
cd flink-docker
./build-from-local.sh /path/to/my/build/target username/image:tag
```
##########
File path: flink-end-to-end-tests/test-scripts/container-scripts/docker-compose.test.yml
##########
@@ -16,15 +16,31 @@
# limitations under the License.
################################################################################
-# Extensions to flink-container/docker/docker-compose.yml that mounts volumes needed for tests
+# Docker compose file for a Flink job cluster deployment.
+#
+# Parameters:
+# * FLINK_DOCKER_IMAGE_NAME - Image name to use for the deployment (default: flink-job:latest)
Review comment:
default seems to be `flink-job`, w/o the `:latest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425853356
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
In my suggestion above, we only require docker
For the cleanup, we could build the archive in `/tmp`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59d7735635b83251b862eeedef8af62662dd0919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452)
* 73043891f8468782029ce5abe63a3d1ed29ea09e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
}, {
"hash" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628",
"triggerID" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"triggerType" : "PUSH"
}, {
"hash" : "8b450055a1e9f35a286342105e0da83ed8c74faa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b450055a1e9f35a286342105e0da83ed8c74faa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da355ac23cca4c125508f661d9d6d16416ced16b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628)
* 8b450055a1e9f35a286342105e0da83ed8c74faa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629291908
>Note that you may see a failure in the e2e tests on the second run of Kubernetes (they are now duplicated because of a temporary commit); my guess is that the tests currently don't properly clean up something and we try to pull results from the wrong task manager.
Is it expected that the "Run kubernetes application test" [fails](https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8004&view=logs&j=1f3ed471-1849-5d3c-a34c-19792af4ad16&t=2f5b54d0-1d28-5b01-d344-aa50ffe0cdf8) with a "ErrImagePull" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73043891f8468782029ce5abe63a3d1ed29ea09e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530)
* 59d7735635b83251b862eeedef8af62662dd0919 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59d7735635b83251b862eeedef8af62662dd0919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540)
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426154414
##########
File path: flink-end-to-end-tests/test-scripts/container-scripts/docker-compose.test.yml
##########
@@ -16,15 +16,31 @@
# limitations under the License.
################################################################################
-# Extensions to flink-container/docker/docker-compose.yml that mounts volumes needed for tests
+# Docker compose file for a Flink job cluster deployment.
+#
+# Parameters:
+# * FLINK_DOCKER_IMAGE_NAME - Image name to use for the deployment (default: flink-job:latest)
Review comment:
This was also copie as is from `flink-container/docker/docker-compose.yml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
* 8c64d694ff984b32600338bfe657960e92ad1ee9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606)
* 14729456edcc4d18f392dde05c5afe20fe787dd9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
}, {
"hash" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14729456edcc4d18f392dde05c5afe20fe787dd9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617)
* da355ac23cca4c125508f661d9d6d16416ced16b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
}, {
"hash" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628",
"triggerID" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14729456edcc4d18f392dde05c5afe20fe787dd9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617)
* da355ac23cca4c125508f661d9d6d16416ced16b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629293482
Ah, I guess not :)
```
2020-05-15T14:39:12.3153929Z /home/vsts/work/1/s/flink-end-to-end-tests/test-scripts/test_kubernetes_application.sh: line 37: build_image_with_jar: command not found
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
}, {
"hash" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628",
"triggerID" : "da355ac23cca4c125508f661d9d6d16416ced16b",
"triggerType" : "PUSH"
}, {
"hash" : "8b450055a1e9f35a286342105e0da83ed8c74faa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1641",
"triggerID" : "8b450055a1e9f35a286342105e0da83ed8c74faa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da355ac23cca4c125508f661d9d6d16416ced16b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1628)
* 8b450055a1e9f35a286342105e0da83ed8c74faa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1641)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73043891f8468782029ce5abe63a3d1ed29ea09e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425837430
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
Given that we are primarily interested in the running on CI I'm fine with the current state.
It can blow up in any case since you can't guarantee python (2 or 3) to exist at all; the only safe solution being a pure bash/java version, bash naturally not being realistic option and Java not really being worth the additional effort, and it would also make it way harder to offer a script in that case.
Originally I wanted to serve things via netcat but it didn't quite work.
Dockerizing this one thing seems a bit overkill to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425851670
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
You don't need to create your own docker image.
```
docker run -it -p 9999:9999 -v `pwd`:/data python:3.7.7-slim-buster python -m http.server 9999
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629224512
Note that you _may_ see a failure in the e2e tests on the _second_ run of Kubernetes (they are now duplicated because of a temporary commit); my guess is that the tests currently don't properly clean up _something_ and we try to pull results from the wrong task manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
}, {
"hash" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617",
"triggerID" : "14729456edcc4d18f392dde05c5afe20fe787dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
* 8c64d694ff984b32600338bfe657960e92ad1ee9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606)
* 14729456edcc4d18f392dde05c5afe20fe787dd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
}, {
"hash" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606",
"triggerID" : "8c64d694ff984b32600338bfe657960e92ad1ee9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
* 8c64d694ff984b32600338bfe657960e92ad1ee9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425832746
##########
File path: flink-end-to-end-tests/test-scripts/container-scripts/docker-compose.test.yml
##########
@@ -16,15 +16,31 @@
# limitations under the License.
################################################################################
-# Extensions to flink-container/docker/docker-compose.yml that mounts volumes needed for tests
+# Docker compose file for a Flink job cluster deployment.
+#
+# Parameters:
+# * FLINK_DOCKER_IMAGE_NAME - Image name to use for the deployment (default: flink-job:latest)
Review comment:
:latest is effectively implied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426154375
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name ${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
Review comment:
I don't know about you, but I'm really getting tired of Flink dropping hundreds of files into my /tmp directories.
My bigger concern is the fileserver process anyway; you definitely don't want that one leaking since it could affect the correctness of subsequent runs.
So as I said, it would need more work to be in a state where I would offer it to other people.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r425853551
##########
File path: flink-end-to-end-tests/test-scripts/container-scripts/docker-compose.test.yml
##########
@@ -16,15 +16,31 @@
# limitations under the License.
################################################################################
-# Extensions to flink-container/docker/docker-compose.yml that mounts volumes needed for tests
+# Docker compose file for a Flink job cluster deployment.
+#
+# Parameters:
+# * FLINK_DOCKER_IMAGE_NAME - Image name to use for the deployment (default: flink-job:latest)
Review comment:
Fair point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
}, {
"hash" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596",
"triggerID" : "acad8ebc3f6f4c834a15dab61b7167280d09454f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acad8ebc3f6f4c834a15dab61b7167280d09454f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1596)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1452",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
}, {
"hash" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530",
"triggerID" : "73043891f8468782029ce5abe63a3d1ed29ea09e",
"triggerType" : "PUSH"
}, {
"hash" : "59d7735635b83251b862eeedef8af62662dd0919",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540",
"triggerID" : "59d7735635b83251b862eeedef8af62662dd0919",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73043891f8468782029ce5abe63a3d1ed29ea09e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1530)
* 59d7735635b83251b862eeedef8af62662dd0919 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629336782
The recently added application mode kubernetes e2e test showed up in the rebase right before I opened the PR. May take a bit to port that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629217287
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b450055a1e9f35a286342105e0da83ed8c74faa (Fri Oct 16 10:35:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12172:
URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434",
"triggerID" : "ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7",
"triggerType" : "PUSH"
}, {
"hash" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53535b6bfbf308d4a5e1d209a11ce8cac6265a13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff37e0c1c648d9b80bb7d009f6b559d12ad3aeb7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1434)
* 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org