You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/28 18:15:00 UTC

[jira] [Work logged] (BEAM-14190) Send schema metadata to dataflow

     [ https://issues.apache.org/jira/browse/BEAM-14190?focusedWorklogId=748822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748822 ]

ASF GitHub Bot logged work on BEAM-14190:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Mar/22 18:14
            Start Date: 28/Mar/22 18:14
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #17190:
URL: https://github.com/apache/beam/pull/17190#discussion_r836715152



##########
File path: sdks/python/apache_beam/coders/row_coder.py
##########
@@ -85,6 +87,13 @@ def as_deterministic_coder(self, step_label, error_message=None):
   def to_type_hint(self):
     return self._type_hint
 
+  def as_cloud_object(self, coders_context=None):

Review comment:
       I agree they are pre-portability, I don't know where we are on them being deprecated long term. My understanding is that for portability their generation is moved from the Beam SDK to the Dataflow Service.
   
   This PR is bringing Python up to feature parity with Java. My understanding is that there is no support for Schema metadata in portability yet, but I'll be looking into that next.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 748822)
    Remaining Estimate: 0h
            Time Spent: 10m

> Send schema metadata to dataflow
> --------------------------------
>
>                 Key: BEAM-14190
>                 URL: https://issues.apache.org/jira/browse/BEAM-14190
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-dataflow, sdk-java-core, sdk-py-core
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We currently only send schema metadata in non-portable Java. We should send it for other paths too.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)