You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/25 07:01:38 UTC
[GitHub] [incubator-kyuubi] zwangsheng opened a new pull request, #3334: [KPIP 5][BUG][UI] Fix npm run build fail with js
zwangsheng opened a new pull request, #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
`npm run build` fail with following log
```
error TS6504: File '/Users/yangbinjie01/IdeaProjects/incubator-kyuubi/kyuubi-server/web-ui/src/views/operation/completedJobs/index.vue.__VLS_script.js' is a JavaScript file. Did you mean to enable the 'allowJs' option?
The file is in the program because:
Root file specified for compilation
...
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3334: [Subtask][KPIP-5]Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334#issuecomment-1226859150
cc @pan3793 @tongwl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3334: [Subtask][KPIP-5] Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334#issuecomment-1226909540
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3334: [Subtask][KPIP-5] Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3334: [Subtask][KPIP-5] Fix npm run build fail with js
URL: https://github.com/apache/incubator-kyuubi/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] tongwl commented on pull request #3334: [Subtask][KPIP-5]Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
tongwl commented on PR #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334#issuecomment-1226872522
@zwangsheng
Hi, please also change "dev": "vite --port 9090" to "dev": "vue-tsc --noEmit && vite --port 9090" in package.json, expose the problem of missing "lang=ts" in the dev stage instead of the build stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3334: [Subtask][KPIP-5] Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334#discussion_r954623137
##########
kyuubi-server/web-ui/src/views/contact/index.vue:
##########
@@ -20,7 +20,7 @@
<main>Contact page</main>
</template>
-<script>
+<script lang='ts'>
Review Comment:
nit: "double qoute"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3334: [Subtask][KPIP-5] Fix npm run build fail with js
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3334:
URL: https://github.com/apache/incubator-kyuubi/pull/3334#issuecomment-1226877071
> @zwangsheng Hi, please also change "dev": "vite --port 9090" to "dev": "vue-tsc --noEmit && vite --port 9090" in package.json, expose the problem of missing "lang=ts" in the dev stage instead of the build stage.
OK, nice catch. + 1 for throw exception during dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org