You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/08 03:51:04 UTC
[GitHub] [zookeeper] ZWShuai91 opened a new pull request #1396: ZOOKEEPER-3883:new UncaughtExceptionHandler object with lambda
ZWShuai91 opened a new pull request #1396:
URL: https://github.com/apache/zookeeper/pull/1396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1396: ZOOKEEPER-3883:new UncaughtExceptionHandler object with lambda
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1396:
URL: https://github.com/apache/zookeeper/pull/1396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1396: ZOOKEEPER-3883:new UncaughtExceptionHandler object with lambda
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1396:
URL: https://github.com/apache/zookeeper/pull/1396#issuecomment-670046068
merged to master, thank you @ZWShuai91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1396: ZOOKEEPER-3883:new UncaughtExceptionHandler object with lambda
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1396:
URL: https://github.com/apache/zookeeper/pull/1396#issuecomment-667648905
> Thanks for you contribution.
> I don't see much value in this change.
>
> Why do you want to change to lambdas ?
> Lamdas are cool but they are a tool like the others
@eolivelli I think there's a clear readability value here. The lambda is less code. Less code means more readable. More readable means more maintainable in future.
Even if the advantage is only slight, why not accept the PR for the master branch? If somebody's going through the effort to modernize the code, the ZK committers should support that, I think. It means less technical debt in future, and is a good way to onboard, welcome, and encourage new contributors to the project, even if the code is functionally equivalent.
If there's a technical reason to reject the change, on the other hand, then perhaps a bit more discussion over its merits are worthwhile? I don't see a technical objection to discuss, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org