[jira] [Commented] (DRILL-7828) Refactor Pcap and Pcapng format plugin

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308471#comment-17308471 ] 

ASF GitHub Bot commented on DRILL-7828:
---------------------------------------

vdiravka opened a new pull request #2192:
URL: https://github.com/apache/drill/pull/2192


   # [DRILL-7828](https://issues.apache.org/jira/browse/DRILL-7828): Refactor Pcap and Pcapng format plugin
   
   ## Description
   
   It merges two (PCAP and PCAPNG) format plugins into one and placed it in the `contrib` module. Hence it uses two different readers for them. The decision, which reader to use is based on identifying PCAP file Magic Number
   
   ## Documentation
   An example of setting PCAP Format Plugin
   ```
           "pcap": {
             "type": "pcap",
             "extensions": ["pcap", "pcapng"],
             "stat" : false
           }
   ```
   
   ## Testing
   Added test case for the `pcapng` file, but `pcap` extension
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor Pcap and Pcapng format plugin
> --------------------------------------
>
>                 Key: DRILL-7828
>                 URL: https://issues.apache.org/jira/browse/DRILL-7828
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Cong Luo
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.19.0
>
>
> We can check the file's magic number, If that magic number indicates PCAP then use the existing reader, If the magic number indicates PCAPNG, use the refactored NG reader.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)