You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/16 00:43:19 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache9 commented on a change in pull request #1708:
URL: https://github.com/apache/hbase/pull/1708#discussion_r594784640



##########
File path: bin/hbase
##########
@@ -658,7 +663,10 @@ elif [ "$COMMAND" = "mapredcp" ] ; then
     for f in "${HBASE_HOME}"/lib/client-facing-thirdparty/*.jar; do
       if [[ ! "${f}" =~ ^.*/htrace-core-3.*\.jar$ ]] && \
          [ "${f}" != "htrace-core.jar$" ] && \
-         [[ ! "${f}" =~ ^.*/slf4j-log4j.*$ ]]; then
+         [[ ! "${f}" =~ ^.*/log4j.*$ ]] && \
+         [[ ! "${f}" =~ ^.*/slf4j.*$ ]] && \
+         [[ ! "${f}" =~ ^.*/jcl-over-slf4j.*$ ]] && \
+         [[ ! "${f}" =~ ^.*/jul-to-slf4j.*$ ]]; then

Review comment:
       Let me check this.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org