You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/05/02 15:32:16 UTC
[GitHub] [libcloud] c-w opened a new pull request #1578: Add integration tests for MinIO storage driver
c-w opened a new pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578
## Add integration tests for MinIO storage driver
### Description
This pull requests extends the storage integration test framework to cover the MinIO storage driver.
One of the integration tests failed as the S3 driver from which MinIO derives doesn't pass-through `content_encoding` in `get_object` so this pull request also adds this missing functionality.
### Status
- done, ready for review
### Checklist
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w commented on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
c-w commented on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-830828075
@Kami Do we have any contacts in AWS and/or GCP who'd be willing to get us some cloud credits like we did for Azure? That would enable us to add live tests for those drivers too as they don't seem to have official emulators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w commented on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
c-w commented on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-831290996
Thanks for the review @Kami, and yes, would be great if you could add me to the AWS account as it'll speed up implementation/verification of the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-830843558
@c-w Yeah, we actually already have some AWS OSS credits and secrets are already set up for this repo (``AWS_ACCESS_KEY_ID``, ``AWS_ACCESS_KEY_SECRET``).
If needed, I can also give you access to that AWS account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-830827923
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1578](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec4625b) into [trunk](https://codecov.io/gh/apache/libcloud/commit/38693a4775505364707419447fb9eb788f8f04e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38693a4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1578 +/- ##
=======================================
Coverage 83.00% 83.00%
=======================================
Files 394 394
Lines 84990 84990
Branches 9038 9038
=======================================
Hits 70550 70550
Misses 11373 11373
Partials 3067 3067
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/storage/drivers/s3.py](https://codecov.io/gh/apache/libcloud/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL3MzLnB5) | `89.77% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [38693a4...ec4625b](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-830827923
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1578](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158611f) into [trunk](https://codecov.io/gh/apache/libcloud/commit/38693a4775505364707419447fb9eb788f8f04e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38693a4) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1578 +/- ##
==========================================
- Coverage 83.00% 83.00% -0.01%
==========================================
Files 394 394
Lines 84990 84992 +2
Branches 9038 9039 +1
==========================================
Hits 70550 70550
- Misses 11373 11374 +1
- Partials 3067 3068 +1
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/storage/drivers/s3.py](https://codecov.io/gh/apache/libcloud/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL3MzLnB5) | `89.46% <0.00%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [38693a4...158611f](https://codecov.io/gh/apache/libcloud/pull/1578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami edited a comment on pull request #1578: Add integration tests for MinIO storage driver
Posted by GitBox <gi...@apache.org>.
Kami edited a comment on pull request #1578:
URL: https://github.com/apache/libcloud/pull/1578#issuecomment-830843558
@c-w Yeah, we actually already have some AWS OSS credits and secrets are already set up for this repo (``AWS_ACCESS_KEY_ID``, ``AWS_ACCESS_KEY_SECRET``).
If needed, I can also give you access to that AWS account.
EDIT: I just checked. We still have 500$ left till beginning of August. If needed, I can request more credits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org