You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/01/16 21:31:36 UTC

Review Request: Unit test for common module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8974/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

Unit test cases for Sqoop2 Common module


This addresses bug SQOOP-831.
    https://issues.apache.org/jira/browse/SQOOP-831


Diffs
-----

  common/src/test/java/org/apache/sqoop/common/TestMapContext.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/common/TestSqoopResponseCode.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMConnection.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMConnector.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMForm.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMJob.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMJobForms.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMMapInput.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMStringInput.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/submission/counter/TestCounter.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/validation/TestValidation.java PRE-CREATION 

Diff: https://reviews.apache.org/r/8974/diff/


Testing
-------

Executed test cases


Thanks,

vasanthkumar


Re: Review Request: Unit test for common module

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8974/#review15451
-----------------------------------------------------------

Ship it!


Hi Vasanth,
this is totally awesome! Thank you very much for doing all the hard work! 

Jarcec

- Jarek Cecho


On Jan. 16, 2013, 8:31 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8974/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 8:31 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Unit test cases for Sqoop2 Common module
> 
> 
> This addresses bug SQOOP-831.
>     https://issues.apache.org/jira/browse/SQOOP-831
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/sqoop/common/TestMapContext.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/common/TestSqoopResponseCode.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMConnection.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMConnector.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMForm.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMJob.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMJobForms.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMMapInput.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMStringInput.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounter.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8974/diff/
> 
> 
> Testing
> -------
> 
> Executed test cases
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>