You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/03/13 10:11:08 UTC
Review Request 19180: cli: only add local bin direcotry to PATH at first
through
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description
-------
cli: only add local bin direcotry to PATH at first through
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
Diffs
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review39551
-----------------------------------------------------------
src/cli/mesos.cpp
<https://reviews.apache.org/r/19180/#comment71957>
There isn't consensus around the solution. Have you taken a look at Adams comment? Still don't think firstThrough adds much context to the problem at hand.
- Niklas Nielsen
On March 31, 2014, 10:53 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 10:53 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
> On May 16, 2014, 7:32 a.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
>
> Niklas Nielsen wrote:
> Can you point me review there 2) landed? If that's is in, why bother with 1)?
> I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
> If you want to push for that fix still, I suggest we find another shepherd for this RR.
>
Sorry, I didn't aware that patch is still in your branch, not the official mesos repo. Do you submit that patch recently? Even we have your patch merged, the issue (directory added into $PATH more than once) is still here. I'll align this patch with your vision soon.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 16, 2014, 6:48 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
> On May 16, 2014, 7:32 a.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
>
> Niklas Nielsen wrote:
> Can you point me review there 2) landed? If that's is in, why bother with 1)?
> I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
> If you want to push for that fix still, I suggest we find another shepherd for this RR.
>
>
> Chengwei Yang wrote:
> Sorry, I didn't aware that patch is still in your branch, not the official mesos repo. Do you submit that patch recently? Even we have your patch merged, the issue (directory added into $PATH more than once) is still here. I'll align this patch with your vision soon.
>
> Niklas Nielsen wrote:
> Hi Chengwei - do you still want this to go in?
>
> Chengwei Yang wrote:
> I'll revisite this patch this week, just have one week holiday last week.
>
> Niklas Nielsen wrote:
> Chengwei, do you still want this in?
Sorry, Niklas, please take it over and go ahead.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 16, 2014, 6:48 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
> On May 16, 2014, 7:32 a.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
Hi Niklas,
Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 16, 2014, 6:48 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Niklas Nielsen <ni...@qni.dk>.
> On May 15, 2014, 4:32 p.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
>
> Niklas Nielsen wrote:
> Can you point me review there 2) landed? If that's is in, why bother with 1)?
> I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
> If you want to push for that fix still, I suggest we find another shepherd for this RR.
>
>
> Chengwei Yang wrote:
> Sorry, I didn't aware that patch is still in your branch, not the official mesos repo. Do you submit that patch recently? Even we have your patch merged, the issue (directory added into $PATH more than once) is still here. I'll align this patch with your vision soon.
Hi Chengwei - do you still want this to go in?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 15, 2014, 3:48 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 3:48 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Niklas Nielsen <ni...@qni.dk>.
> On May 15, 2014, 4:32 p.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
Can you point me review there 2) landed? If that's is in, why bother with 1)?
I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
If you want to push for that fix still, I suggest we find another shepherd for this RR.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 15, 2014, 3:48 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 3:48 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Niklas Nielsen <ni...@qni.dk>.
> On May 15, 2014, 4:32 p.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
>
> Niklas Nielsen wrote:
> Can you point me review there 2) landed? If that's is in, why bother with 1)?
> I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
> If you want to push for that fix still, I suggest we find another shepherd for this RR.
>
>
> Chengwei Yang wrote:
> Sorry, I didn't aware that patch is still in your branch, not the official mesos repo. Do you submit that patch recently? Even we have your patch merged, the issue (directory added into $PATH more than once) is still here. I'll align this patch with your vision soon.
>
> Niklas Nielsen wrote:
> Hi Chengwei - do you still want this to go in?
>
> Chengwei Yang wrote:
> I'll revisite this patch this week, just have one week holiday last week.
Chengwei, do you still want this in?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 15, 2014, 3:48 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 3:48 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Adam B <ad...@mesosphere.io>.
> On May 15, 2014, 4:32 p.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
+1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
"mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 15, 2014, 3:48 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 3:48 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
> On May 16, 2014, 7:32 a.m., Niklas Nielsen wrote:
> > Hey Chengwei - sorry for the tardy turnaround time on this review request.
> >
> > To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
> > The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
> >
> > Two things we could do:
> > 1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
> > 2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
> > https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
> >
> > Thoughts?
>
> Adam B wrote:
> +1 Love the 'set'. Calling "mesos help foo" will still recurse into main and dirname will still be prepended to PATH multiple times, but the commands will not be printed multiple times.
> "mesos help help" will give a weird error ("Not expecting --help before command") instead of calling usage, but I think that's a pretty contrived case.
>
> Chengwei Yang wrote:
> Hi Niklas,
>
> Sorry for late reply, so since the 2) improvement landed into usage(), so anyway we can't get duplicated commands in usage now though the 1) thing is still left to take. Do you like the first version of this patch? Which just do the small fix, add directory to PATH in the first through.
>
> Niklas Nielsen wrote:
> Can you point me review there 2) landed? If that's is in, why bother with 1)?
> I am still _not_ in favor of a notion of firstThrough with a static variable - if anything, it should be firstPass and I already enumerated other ways of doing it.
> If you want to push for that fix still, I suggest we find another shepherd for this RR.
>
>
> Chengwei Yang wrote:
> Sorry, I didn't aware that patch is still in your branch, not the official mesos repo. Do you submit that patch recently? Even we have your patch merged, the issue (directory added into $PATH more than once) is still here. I'll align this patch with your vision soon.
>
> Niklas Nielsen wrote:
> Hi Chengwei - do you still want this to go in?
I'll revisite this patch this week, just have one week holiday last week.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
On May 16, 2014, 6:48 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review43181
-----------------------------------------------------------
Hey Chengwei - sorry for the tardy turnaround time on this review request.
To me, it still seems like we are treating the symptoms of the real issue: PATH is appended multiple times and the subsequent globbing adds the available commands to same number of times.
The reason I am saying this is because the fix is difficult to understand (it is not immediate that this is the problem it solves) and seems very specialized for the "mesos help --help" and "mesos help help" case.
Two things we could do:
1) Don't add the new path unconditionally to the PATH variable i.e. check if it is already there.
2) In usage(), don't add duplicates to the commands from the globbed list of candidates. This can be done pretty easy and local by using a set instead of a list. Try to take a look at:
https://github.com/nqn/mesos/commit/01f77a1ab6d96f48765cc3539da1a1ebd4ba1d56
Thoughts?
- Niklas Nielsen
On May 15, 2014, 3:48 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 3:48 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
(Updated May 15, 2014, 3:48 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
I'll shepherd this one.
-- Niklas
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description
-------
Fix mesos command parsing help
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
The root cause is the directory contains available mesos commands are
added more than one times when recursive to main() again.
Idea comes from Adam B.
Review: https://reviews.apache.org/r/19180
Diffs
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang
Re: Review Request 19180: Fix mesos command parsing help
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review40255
-----------------------------------------------------------
Bad patch!
Reviews applied: [19180]
Failed command: make check
Error:
Making check in .
make[1]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make[1]: Nothing to be done for `check-am'.
make[1]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot'
Making check in 3rdparty
make[1]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make check-recursive
make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
Making check in libprocess
make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
Making check in 3rdparty
make[4]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-recursive
make[5]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
Making check in stout
make[6]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Nothing to be done for `check'.
make[6]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make libgmock.la stout-tests
make[7]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[7]: `libgmock.la' is up to date.
make[7]: `stout-tests' is up to date.
make[7]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-local
make[7]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
./stout-tests
[==========] Running 121 tests from 24 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from Stout
[ RUN ] Stout.Bytes
[ OK ] Stout.Bytes (0 ms)
[ RUN ] Stout.Set
[ OK ] Stout.Set (0 ms)
[ RUN ] Stout.Some
[ OK ] Stout.Some (0 ms)
[----------] 3 tests from Stout (0 ms total)
[----------] 4 tests from Cache
[ RUN ] Cache.Insert
[ OK ] Cache.Insert (0 ms)
[ RUN ] Cache.Update
[ OK ] Cache.Update (0 ms)
[ RUN ] Cache.Erase
[ OK ] Cache.Erase (0 ms)
[ RUN ] Cache.LRUEviction
[ OK ] Cache.LRUEviction (0 ms)
[----------] 4 tests from Cache (0 ms total)
[----------] 4 tests from DurationTest
[ RUN ] DurationTest.Comparison
[ OK ] DurationTest.Comparison (0 ms)
[ RUN ] DurationTest.ParseAndTry
[ OK ] DurationTest.ParseAndTry (0 ms)
[ RUN ] DurationTest.Arithmetic
[ OK ] DurationTest.Arithmetic (0 ms)
[ RUN ] DurationTest.OutputFormat
[ OK ] DurationTest.OutputFormat (0 ms)
[----------] 4 tests from DurationTest (0 ms total)
[----------] 1 test from ErrorTest
[ RUN ] ErrorTest.Test
[ OK ] ErrorTest.Test (0 ms)
[----------] 1 test from ErrorTest (0 ms total)
[----------] 12 tests from FlagsTest
[ RUN ] FlagsTest.Load
[ OK ] FlagsTest.Load (0 ms)
[ RUN ] FlagsTest.Add
[ OK ] FlagsTest.Add (0 ms)
[ RUN ] FlagsTest.Flags
[ OK ] FlagsTest.Flags (0 ms)
[ RUN ] FlagsTest.LoadFromEnvironment
[ OK ] FlagsTest.LoadFromEnvironment (0 ms)
[ RUN ] FlagsTest.LoadFromCommandLine
[ OK ] FlagsTest.LoadFromCommandLine (1 ms)
[ RUN ] FlagsTest.LoadFromCommandLineWithNonFlags
[ OK ] FlagsTest.LoadFromCommandLineWithNonFlags (0 ms)
[ RUN ] FlagsTest.Stringification
[ OK ] FlagsTest.Stringification (0 ms)
[ RUN ] FlagsTest.DuplicatesFromEnvironment
[ OK ] FlagsTest.DuplicatesFromEnvironment (0 ms)
[ RUN ] FlagsTest.DuplicatesFromCommandLine
[ OK ] FlagsTest.DuplicatesFromCommandLine (0 ms)
[ RUN ] FlagsTest.Errors
[ OK ] FlagsTest.Errors (0 ms)
[ RUN ] FlagsTest.Usage
[ OK ] FlagsTest.Usage (0 ms)
[ RUN ] FlagsTest.Duration
[ OK ] FlagsTest.Duration (0 ms)
[----------] 12 tests from FlagsTest (1 ms total)
[----------] 1 test from GzipTest
[ RUN ] GzipTest.CompressDecompressString
[ OK ] GzipTest.CompressDecompressString (101 ms)
[----------] 1 test from GzipTest (101 ms total)
[----------] 2 tests from HashMapTest
[ RUN ] HashMapTest.Insert
[ OK ] HashMapTest.Insert (0 ms)
[ RUN ] HashMapTest.Contains
[ OK ] HashMapTest.Contains (0 ms)
[----------] 2 tests from HashMapTest (0 ms total)
[----------] 2 tests from HashsetTest
[ RUN ] HashsetTest.Insert
[ OK ] HashsetTest.Insert (0 ms)
[ RUN ] HashsetTest.Union
[ OK ] HashsetTest.Union (0 ms)
[----------] 2 tests from HashsetTest (0 ms total)
[----------] 8 tests from IntervalTest
[ RUN ] IntervalTest.Interval
[ OK ] IntervalTest.Interval (0 ms)
[ RUN ] IntervalTest.EmptyInterval
[ OK ] IntervalTest.EmptyInterval (0 ms)
[ RUN ] IntervalTest.Constructor
[ OK ] IntervalTest.Constructor (0 ms)
[ RUN ] IntervalTest.Addition
[ OK ] IntervalTest.Addition (0 ms)
[ RUN ] IntervalTest.Subtraction
[ OK ] IntervalTest.Subtraction (0 ms)
[ RUN ] IntervalTest.Intersection
[ OK ] IntervalTest.Intersection (0 ms)
[ RUN ] IntervalTest.LargeInterval
[ OK ] IntervalTest.LargeInterval (0 ms)
[ RUN ] IntervalTest.IntervalIteration
[ OK ] IntervalTest.IntervalIteration (0 ms)
[----------] 8 tests from IntervalTest (0 ms total)
[----------] 8 tests from JsonTest
[ RUN ] JsonTest.DefaultValueIsNull
[ OK ] JsonTest.DefaultValueIsNull (0 ms)
[ RUN ] JsonTest.BinaryData
[ OK ] JsonTest.BinaryData (0 ms)
[ RUN ] JsonTest.NumberFormat
[ OK ] JsonTest.NumberFormat (0 ms)
[ RUN ] JsonTest.BooleanFormat
[ OK ] JsonTest.BooleanFormat (0 ms)
[ RUN ] JsonTest.BooleanAssignement
[ OK ] JsonTest.BooleanAssignement (0 ms)
[ RUN ] JsonTest.CStringAssignment
[ OK ] JsonTest.CStringAssignment (0 ms)
[ RUN ] JsonTest.NumericAssignment
[ OK ] JsonTest.NumericAssignment (0 ms)
[ RUN ] JsonTest.parse
[ OK ] JsonTest.parse (1 ms)
[----------] 8 tests from JsonTest (1 ms total)
[----------] 5 tests from LinkedHashmapTest
[ RUN ] LinkedHashmapTest.Put
[ OK ] LinkedHashmapTest.Put (0 ms)
[ RUN ] LinkedHashmapTest.Contains
[ OK ] LinkedHashmapTest.Contains (0 ms)
[ RUN ] LinkedHashmapTest.Erase
[ OK ] LinkedHashmapTest.Erase (0 ms)
[ RUN ] LinkedHashmapTest.Keys
[ OK ] LinkedHashmapTest.Keys (0 ms)
[ RUN ] LinkedHashmapTest.Values
[ OK ] LinkedHashmapTest.Values (0 ms)
[----------] 5 tests from LinkedHashmapTest (0 ms total)
[----------] 6 tests from MultimapTest/0, where TypeParam = Multimap<std::string, unsigned short>
[ RUN ] MultimapTest/0.Put
[ OK ] MultimapTest/0.Put (0 ms)
[ RUN ] MultimapTest/0.Remove
[ OK ] MultimapTest/0.Remove (0 ms)
[ RUN ] MultimapTest/0.Size
[ OK ] MultimapTest/0.Size (0 ms)
[ RUN ] MultimapTest/0.Keys
[ OK ] MultimapTest/0.Keys (0 ms)
[ RUN ] MultimapTest/0.Iterator
[ OK ] MultimapTest/0.Iterator (0 ms)
[ RUN ] MultimapTest/0.Foreach
[ OK ] MultimapTest/0.Foreach (0 ms)
[----------] 6 tests from MultimapTest/0 (0 ms total)
[----------] 6 tests from MultimapTest/1, where TypeParam = multihashmap<std::string, unsigned short>
[ RUN ] MultimapTest/1.Put
[ OK ] MultimapTest/1.Put (0 ms)
[ RUN ] MultimapTest/1.Remove
[ OK ] MultimapTest/1.Remove (0 ms)
[ RUN ] MultimapTest/1.Size
[ OK ] MultimapTest/1.Size (0 ms)
[ RUN ] MultimapTest/1.Keys
[ OK ] MultimapTest/1.Keys (0 ms)
[ RUN ] MultimapTest/1.Iterator
[ OK ] MultimapTest/1.Iterator (0 ms)
[ RUN ] MultimapTest/1.Foreach
[ OK ] MultimapTest/1.Foreach (0 ms)
[----------] 6 tests from MultimapTest/1 (0 ms total)
[----------] 4 tests from NetTest
[ RUN ] NetTest.mac
[ OK ] NetTest.mac (116 ms)
[ RUN ] NetTest.ConstructMAC
[ OK ] NetTest.ConstructMAC (0 ms)
[ RUN ] NetTest.ip
[ OK ] NetTest.ip (1 ms)
[ RUN ] NetTest.ConstructIP
[ OK ] NetTest.ConstructIP (0 ms)
[----------] 4 tests from NetTest (117 ms total)
[----------] 1 test from NoneTest
[ RUN ] NoneTest.Test
[ OK ] NoneTest.Test (0 ms)
[----------] 1 test from NoneTest (0 ms total)
[----------] 3 tests from OptionTest
[ RUN ] OptionTest.Min
[ OK ] OptionTest.Min (0 ms)
[ RUN ] OptionTest.Max
[ OK ] OptionTest.Max (0 ms)
[ RUN ] OptionTest.Comparison
[ OK ] OptionTest.Comparison (0 ms)
[----------] 3 tests from OptionTest (0 ms total)
[----------] 18 tests from OsTest
[ RUN ] OsTest.environment
[ OK ] OsTest.environment (1 ms)
[ RUN ] OsTest.rmdir
[ OK ] OsTest.rmdir (0 ms)
[ RUN ] OsTest.system
sh: 1: invalid.command: not found
[ OK ] OsTest.system (23 ms)
[ RUN ] OsTest.nonblock
[ OK ] OsTest.nonblock (0 ms)
[ RUN ] OsTest.touch
[ OK ] OsTest.touch (1 ms)
[ RUN ] OsTest.readWriteString
[ OK ] OsTest.readWriteString (1 ms)
[ RUN ] OsTest.find
[ OK ] OsTest.find (1 ms)
[ RUN ] OsTest.bootId
[ OK ] OsTest.bootId (0 ms)
[ RUN ] OsTest.uname
[ OK ] OsTest.uname (0 ms)
[ RUN ] OsTest.sysname
[ OK ] OsTest.sysname (0 ms)
[ RUN ] OsTest.release
[ OK ] OsTest.release (0 ms)
[ RUN ] OsTest.sleep
[ OK ] OsTest.sleep (10 ms)
[ RUN ] OsTest.pids
[ OK ] OsTest.pids (27 ms)
[ RUN ] OsTest.children
[ OK ] OsTest.children (47 ms)
[ RUN ] OsTest.process
[ OK ] OsTest.process (0 ms)
[ RUN ] OsTest.processes
[ OK ] OsTest.processes (17 ms)
[ RUN ] OsTest.killtree
[ OK ] OsTest.killtree (210 ms)
[ RUN ] OsTest.pstree
[ OK ] OsTest.pstree (37 ms)
[----------] 18 tests from OsTest (377 ms total)
[----------] 1 test from ProtobufTest
[ RUN ] ProtobufTest.JSON
[ OK ] ProtobufTest.JSON (0 ms)
[----------] 1 test from ProtobufTest (0 ms total)
[----------] 1 test from OsSendfileTest
[ RUN ] OsSendfileTest.sendfile
[ OK ] OsSendfileTest.sendfile (0 ms)
[----------] 1 test from OsSendfileTest (0 ms total)
[----------] 1 test from OsSignalsTest
[ RUN ] OsSignalsTest.suppress
[ OK ] OsSignalsTest.suppress (0 ms)
[----------] 1 test from OsSignalsTest (0 ms total)
[----------] 22 tests from StringsTest
[ RUN ] StringsTest.Format
[ OK ] StringsTest.Format (0 ms)
[ RUN ] StringsTest.Remove
[ OK ] StringsTest.Remove (0 ms)
[ RUN ] StringsTest.Replace
[ OK ] StringsTest.Replace (1 ms)
[ RUN ] StringsTest.Trim
[ OK ] StringsTest.Trim (0 ms)
[ RUN ] StringsTest.Tokenize
[ OK ] StringsTest.Tokenize (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStart
[ OK ] StringsTest.TokenizeStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.TokenizeWithMultipleDelims
[ OK ] StringsTest.TokenizeWithMultipleDelims (0 ms)
[ RUN ] StringsTest.TokenizeEmptyString
[ OK ] StringsTest.TokenizeEmptyString (0 ms)
[ RUN ] StringsTest.TokenizeDelimOnlyString
[ OK ] StringsTest.TokenizeDelimOnlyString (0 ms)
[ RUN ] StringsTest.TokenizeNullByteDelim
[ OK ] StringsTest.TokenizeNullByteDelim (0 ms)
[ RUN ] StringsTest.SplitEmptyString
[ OK ] StringsTest.SplitEmptyString (0 ms)
[ RUN ] StringsTest.SplitDelimOnlyString
[ OK ] StringsTest.SplitDelimOnlyString (0 ms)
[ RUN ] StringsTest.Split
[ OK ] StringsTest.Split (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStart
[ OK ] StringsTest.SplitStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtEnd
[ OK ] StringsTest.SplitStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.SplitStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.SplitWithMultipleDelims
[ OK ] StringsTest.SplitWithMultipleDelims (0 ms)
[ RUN ] StringsTest.Pairs
[ OK ] StringsTest.Pairs (0 ms)
[ RUN ] StringsTest.StartsWith
[ OK ] StringsTest.StartsWith (0 ms)
[ RUN ] StringsTest.Contains
[ OK ] StringsTest.Contains (0 ms)
[----------] 22 tests from StringsTest (1 ms total)
[----------] 1 test from Thread
[ RUN ] Thread.local
[ OK ] Thread.local (0 ms)
[----------] 1 test from Thread (0 ms total)
[----------] 1 test from UUIDTest
[ RUN ] UUIDTest.test
[ OK ] UUIDTest.test (1 ms)
[----------] 1 test from UUIDTest (1 ms total)
[----------] 6 tests from ProcTest
[ RUN ] ProcTest.pids
[ OK ] ProcTest.pids (1 ms)
[ RUN ] ProcTest.cpus
[ OK ] ProcTest.cpus (1 ms)
[ RUN ] ProcTest.SystemStatus
[ OK ] ProcTest.SystemStatus (0 ms)
[ RUN ] ProcTest.ProcessStatus
[ OK ] ProcTest.ProcessStatus (1 ms)
[ RUN ] ProcTest.SingleThread
[ OK ] ProcTest.SingleThread (0 ms)
[ RUN ] ProcTest.MultipleThreads
[ OK ] ProcTest.MultipleThreads (1 ms)
[----------] 6 tests from ProcTest (4 ms total)
[----------] Global test environment tear-down
[==========] 121 tests from 24 test cases ran. (604 ms total)
[ PASSED ] 121 tests.
make[7]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[6]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[4]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
Making check in .
make[4]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make tests
make[5]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[5]: `tests' is up to date.
make[5]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make check-local
make[5]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
./tests
[==========] Running 93 tests from 16 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from Decoder
[ RUN ] Decoder.Request
[ OK ] Decoder.Request (0 ms)
[ RUN ] Decoder.RequestHeaderContinuation
[ OK ] Decoder.RequestHeaderContinuation (0 ms)
[ RUN ] Decoder.Response
[ OK ] Decoder.Response (0 ms)
[----------] 3 tests from Decoder (1 ms total)
[----------] 2 tests from Encoder
[ RUN ] Encoder.Response
[ OK ] Encoder.Response (0 ms)
[ RUN ] Encoder.AcceptableEncodings
[ OK ] Encoder.AcceptableEncodings (0 ms)
[----------] 2 tests from Encoder (0 ms total)
[----------] 5 tests from HTTP
[ RUN ] HTTP.Endpoints
[ OK ] HTTP.Endpoints (1 ms)
[ RUN ] HTTP.Encode
[ OK ] HTTP.Encode (0 ms)
[ RUN ] HTTP.PathParse
[ OK ] HTTP.PathParse (0 ms)
[ RUN ] HTTP.Get
[ OK ] HTTP.Get (1 ms)
[ RUN ] HTTP.Post
[ OK ] HTTP.Post (0 ms)
[----------] 5 tests from HTTP (2 ms total)
[----------] 5 tests from IO
[ RUN ] IO.Poll
[ OK ] IO.Poll (0 ms)
[ RUN ] IO.Read
[ OK ] IO.Read (0 ms)
[ RUN ] IO.BufferedRead
[ OK ] IO.BufferedRead (2 ms)
[ RUN ] IO.Write
[ OK ] IO.Write (0 ms)
[ RUN ] IO.splice
[ OK ] IO.splice (17 ms)
[----------] 5 tests from IO (19 ms total)
[----------] 3 tests from Mutex
[ RUN ] Mutex.lock
[ OK ] Mutex.lock (0 ms)
[ RUN ] Mutex.block
[ OK ] Mutex.block (0 ms)
[ RUN ] Mutex.queue
[ OK ] Mutex.queue (0 ms)
[----------] 3 tests from Mutex (0 ms total)
[----------] 2 tests from MetricsTest
[ RUN ] MetricsTest.Counter
[ OK ] MetricsTest.Counter (0 ms)
[ RUN ] MetricsTest.Gauge
[ OK ] MetricsTest.Gauge (1 ms)
[----------] 2 tests from MetricsTest (1 ms total)
[----------] 3 tests from Owned
[ RUN ] Owned.Access
[ OK ] Owned.Access (0 ms)
[ RUN ] Owned.Null
[ OK ] Owned.Null (0 ms)
[ RUN ] Owned.Share
[ OK ] Owned.Share (0 ms)
[----------] 3 tests from Owned (0 ms total)
[----------] 39 tests from Process
[ RUN ] Process.event
[ OK ] Process.event (0 ms)
[ RUN ] Process.future
[ OK ] Process.future (0 ms)
[ RUN ] Process.associate
[ OK ] Process.associate (0 ms)
[ RUN ] Process.onAny
[ OK ] Process.onAny (0 ms)
[ RUN ] Process.then
[ OK ] Process.then (0 ms)
[ RUN ] Process.after1
[ OK ] Process.after1 (10 ms)
[ RUN ] Process.after2
[ OK ] Process.after2 (11 ms)
[ RUN ] Process.chain
[ OK ] Process.chain (0 ms)
[ RUN ] Process.discard1
[ OK ] Process.discard1 (0 ms)
[ RUN ] Process.discard2
[ OK ] Process.discard2 (0 ms)
[ RUN ] Process.discard3
[ OK ] Process.discard3 (0 ms)
[ RUN ] Process.spawn
[ OK ] Process.spawn (0 ms)
[ RUN ] Process.dispatch
[ OK ] Process.dispatch (0 ms)
[ RUN ] Process.defer1
[ OK ] Process.defer1 (1 ms)
[ RUN ] Process.defer2
[ OK ] Process.defer2 (0 ms)
[ RUN ] Process.defer3
[ OK ] Process.defer3 (0 ms)
[ RUN ] Process.handlers
[ OK ] Process.handlers (0 ms)
[ RUN ] Process.expect
[ OK ] Process.expect (1 ms)
[ RUN ] Process.action
[ OK ] Process.action (0 ms)
[ RUN ] Process.inheritance
[ OK ] Process.inheritance (0 ms)
[ RUN ] Process.thunk
[ OK ] Process.thunk (0 ms)
[ RUN ] Process.delegate
[ OK ] Process.delegate (0 ms)
[ RUN ] Process.delay
[ OK ] Process.delay (0 ms)
[ RUN ] Process.order
[ OK ] Process.order (0 ms)
[ RUN ] Process.donate
[ OK ] Process.donate (1 ms)
[ RUN ] Process.exited
[ OK ] Process.exited (0 ms)
[ RUN ] Process.select
[ OK ] Process.select (0 ms)
[ RUN ] Process.collect
[ OK ] Process.collect (0 ms)
[ RUN ] Process.await1
[ OK ] Process.await1 (0 ms)
[ RUN ] Process.await2
[ OK ] Process.await2 (0 ms)
[ RUN ] Process.await3
[ OK ] Process.await3 (0 ms)
[ RUN ] Process.settle
[ OK ] Process.settle (41 ms)
[ RUN ] Process.pid
[ OK ] Process.pid (0 ms)
[ RUN ] Process.listener
[ OK ] Process.listener (0 ms)
[ RUN ] Process.executor
[ OK ] Process.executor (0 ms)
[ RUN ] Process.remote
[ OK ] Process.remote (0 ms)
[ RUN ] Process.async
[ OK ] Process.async (1 ms)
[ RUN ] Process.limiter
[ OK ] Process.limiter (7 ms)
[ RUN ] Process.provide
[ OK ] Process.provide (1 ms)
[----------] 39 tests from Process (74 ms total)
[----------] 1 test from Future
[ RUN ] Future.FromTry
[ OK ] Future.FromTry (0 ms)
[----------] 1 test from Future (0 ms total)
[----------] 3 tests from Reap
[ RUN ] Reap.NonChildProcess
[ OK ] Reap.NonChildProcess (41 ms)
[ RUN ] Reap.ChildProcess
[ OK ] Reap.ChildProcess (31 ms)
[ RUN ] Reap.TerminatedChildProcess
[ OK ] Reap.TerminatedChildProcess (23 ms)
[----------] 3 tests from Reap (95 ms total)
[----------] 4 tests from Sequence
[ RUN ] Sequence.Serialize
[ OK ] Sequence.Serialize (10 ms)
[ RUN ] Sequence.DiscardOne
[ OK ] Sequence.DiscardOne (11 ms)
[ RUN ] Sequence.DiscardAll
[ OK ] Sequence.DiscardAll (10 ms)
[ RUN ] Sequence.Random
[ OK ] Sequence.Random (11 ms)
[----------] 4 tests from Sequence (43 ms total)
[----------] 4 tests from Shared
[ RUN ] Shared.ConstAccess
[ OK ] Shared.ConstAccess (0 ms)
[ RUN ] Shared.Null
[ OK ] Shared.Null (0 ms)
[ RUN ] Shared.Reset
[ OK ] Shared.Reset (0 ms)
[ RUN ] Shared.Own
[ OK ] Shared.Own (0 ms)
[----------] 4 tests from Shared (0 ms total)
[----------] 3 tests from Statistics
[ RUN ] Statistics.set
[ OK ] Statistics.set (0 ms)
[ RUN ] Statistics.increment
[ OK ] Statistics.increment (1 ms)
[ RUN ] Statistics.decrement
[ OK ] Statistics.decrement (0 ms)
[----------] 3 tests from Statistics (1 ms total)
[----------] 10 tests from Subprocess
[ RUN ] Subprocess.status
[ OK ] Subprocess.status (125 ms)
[ RUN ] Subprocess.output
[ OK ] Subprocess.output (62 ms)
[ RUN ] Subprocess.input
[ OK ] Subprocess.input (31 ms)
[ RUN ] Subprocess.splice
[ OK ] Subprocess.splice (31 ms)
[ RUN ] Subprocess.environment
[ OK ] Subprocess.environment (63 ms)
[ RUN ] Subprocess.environmentWithSpaces
[ OK ] Subprocess.environmentWithSpaces (31 ms)
[ RUN ] Subprocess.environmentWithSpacesAndQuotes
[ OK ] Subprocess.environmentWithSpacesAndQuotes (31 ms)
[ RUN ] Subprocess.environmentOverride
[ OK ] Subprocess.environmentOverride (31 ms)
[ RUN ] Subprocess.setup
[ OK ] Subprocess.setup (31 ms)
[ RUN ] Subprocess.setupStatus
[ OK ] Subprocess.setupStatus (62 ms)
[----------] 10 tests from Subprocess (501 ms total)
[----------] 3 tests from TimeSeries
[ RUN ] TimeSeries.set
[ OK ] TimeSeries.set (0 ms)
[ RUN ] TimeSeries.sparsify
[ OK ] TimeSeries.sparsify (0 ms)
[ RUN ] TimeSeries.truncate
[ OK ] TimeSeries.truncate (0 ms)
[----------] 3 tests from TimeSeries (0 ms total)
[----------] 3 tests from TimeTest
[ RUN ] TimeTest.Arithmetic
[ OK ] TimeTest.Arithmetic (0 ms)
[ RUN ] TimeTest.Now
[ OK ] TimeTest.Now (1 ms)
[ RUN ] TimeTest.Output
[ OK ] TimeTest.Output (0 ms)
[----------] 3 tests from TimeTest (1 ms total)
[----------] Global test environment tear-down
[==========] 93 tests from 16 test cases ran. (738 ms total)
[ PASSED ] 93 tests.
YOU HAVE 2 DISABLED TESTS
make[5]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[4]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
cd leveldb && \
make CC="gcc" CXX="g++" OPT="-g -g2 -O2 -std=c++0x -fPIC"
make[4]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/leveldb'
make[4]: Nothing to be done for `default'.
make[4]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/leveldb'
make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
Making check in src
make[1]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make check-am
make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make test-framework test-executor long-lived-framework long-lived-executor no-executor-framework balloon-framework balloon-executor mesos-tests examples/python/test_framework.py examples/python/test-framework examples/python/test_executor.py examples/python/test-executor \
tests/balloon_framework_test.sh tests/test_framework_test.sh tests/no_executor_framework_test.sh tests/java_exception_test.sh tests/java_framework_test.sh tests/java_log_test.sh tests/python_framework_test.sh
make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[3]: `test-framework' is up to date.
make[3]: `test-executor' is up to date.
make[3]: `long-lived-framework' is up to date.
make[3]: `long-lived-executor' is up to date.
make[3]: `no-executor-framework' is up to date.
make[3]: `balloon-framework' is up to date.
make[3]: `balloon-executor' is up to date.
make[3]: `mesos-tests' is up to date.
make[3]: Nothing to be done for `examples/python/test_framework.py'.
make[3]: Nothing to be done for `examples/python/test-framework'.
make[3]: Nothing to be done for `examples/python/test_executor.py'.
make[3]: Nothing to be done for `examples/python/test-executor'.
make[3]: Nothing to be done for `tests/balloon_framework_test.sh'.
make[3]: Nothing to be done for `tests/test_framework_test.sh'.
make[3]: Nothing to be done for `tests/no_executor_framework_test.sh'.
make[3]: Nothing to be done for `tests/java_exception_test.sh'.
make[3]: Nothing to be done for `tests/java_framework_test.sh'.
make[3]: Nothing to be done for `tests/java_log_test.sh'.
make[3]: Nothing to be done for `tests/python_framework_test.sh'.
make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make check-local
make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
./mesos-tests
Source directory: /x1/jenkins/jenkins-slave/workspace/mesos-reviewbot
Build directory: /x1/jenkins/jenkins-slave/workspace/mesos-reviewbot
Note: Google Test filter = *-CpuIsolatorTest/1.UserCpuUsage:CpuIsolatorTest/1.SystemCpuUsage:LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs:LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota:MemIsolatorTest/0.MemUsage:MemIsolatorTest/1.MemUsage:ContainerizerTest.ROOT_CGROUPS_BalloonFramework:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Enabled:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Subsystems:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Mounted:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Get:CgroupsAnyHierarchyTest.ROOT_CGROUPS_NestedCgroups:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Tasks:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Read:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Cfs_Big_Quota:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Busy:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_SubsystemsHierarchy:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_MountedSubsystems:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_CreateRemove:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUP
S_Listen:CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy:CgroupsAnyHierarchyWithCpuAcctMemoryTest.ROOT_CGROUPS_Stat:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Freeze:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Kill:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Destroy:
[==========] Running 289 tests from 50 test cases.
[----------] Global test environment set-up.
[----------] 1 test from DRFAllocatorTest
[ RUN ] DRFAllocatorTest.DRFAllocatorProcess
[ OK ] DRFAllocatorTest.DRFAllocatorProcess (55 ms)
[----------] 1 test from DRFAllocatorTest (56 ms total)
[----------] 2 tests from ReservationAllocatorTest
[ RUN ] ReservationAllocatorTest.ReservedResources
[ OK ] ReservationAllocatorTest.ReservedResources (51 ms)
[ RUN ] ReservationAllocatorTest.ResourcesReturned
[ OK ] ReservationAllocatorTest.ResourcesReturned (111 ms)
[----------] 2 tests from ReservationAllocatorTest (162 ms total)
[----------] 10 tests from AllocatorTest/0, where TypeParam = mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter>
[ RUN ] AllocatorTest/0.MockAllocator
[ OK ] AllocatorTest/0.MockAllocator (46 ms)
[ RUN ] AllocatorTest/0.ResourcesUnused
[ OK ] AllocatorTest/0.ResourcesUnused (20 ms)
[ RUN ] AllocatorTest/0.OutOfOrderDispatch
[ OK ] AllocatorTest/0.OutOfOrderDispatch (1016 ms)
[ RUN ] AllocatorTest/0.SchedulerFailover
[ OK ] AllocatorTest/0.SchedulerFailover (32 ms)
[ RUN ] AllocatorTest/0.FrameworkExited
[ OK ] AllocatorTest/0.FrameworkExited (60 ms)
[ RUN ] AllocatorTest/0.SlaveLost
[ OK ] AllocatorTest/0.SlaveLost (37 ms)
[ RUN ] AllocatorTest/0.SlaveAdded
[ OK ] AllocatorTest/0.SlaveAdded (157 ms)
[ RUN ] AllocatorTest/0.TaskFinished
[ OK ] AllocatorTest/0.TaskFinished (59 ms)
[ RUN ] AllocatorTest/0.WhitelistSlave
[ OK ] AllocatorTest/0.WhitelistSlave (72 ms)
[ RUN ] AllocatorTest/0.RoleTest
[ OK ] AllocatorTest/0.RoleTest (5018 ms)
[----------] 10 tests from AllocatorTest/0 (6517 ms total)
[----------] 2 tests from AttributesTest
[ RUN ] AttributesTest.Parsing
[ OK ] AttributesTest.Parsing (0 ms)
[ RUN ] AttributesTest.Equality
[ OK ] AttributesTest.Equality (0 ms)
[----------] 2 tests from AttributesTest (0 ms total)
[----------] 9 tests from AuthenticationTest
[ RUN ] AuthenticationTest.UnauthenticatedFramework
[ OK ] AuthenticationTest.UnauthenticatedFramework (1008 ms)
[ RUN ] AuthenticationTest.DisableAuthentication
[ OK ] AuthenticationTest.DisableAuthentication (1012 ms)
[ RUN ] AuthenticationTest.AuthenticatedFramework
[ OK ] AuthenticationTest.AuthenticatedFramework (5007 ms)
[ RUN ] AuthenticationTest.RetryAuthentication
[ OK ] AuthenticationTest.RetryAuthentication (17 ms)
[ RUN ] AuthenticationTest.DropIntermediateSASLMessage
[ OK ] AuthenticationTest.DropIntermediateSASLMessage (5038 ms)
[ RUN ] AuthenticationTest.DropFinalSASLMessage
[ OK ] AuthenticationTest.DropFinalSASLMessage (5016 ms)
[ RUN ] AuthenticationTest.MasterFailover
[ OK ] AuthenticationTest.MasterFailover (5012 ms)
[ RUN ] AuthenticationTest.LeaderElection
[ OK ] AuthenticationTest.LeaderElection (5028 ms)
[ RUN ] AuthenticationTest.SchedulerFailover
[ OK ] AuthenticationTest.SchedulerFailover (19 ms)
[----------] 9 tests from AuthenticationTest (27158 ms total)
[----------] 5 tests from MesosContainerizerProcessTest
[ RUN ] MesosContainerizerProcessTest.Simple
[ OK ] MesosContainerizerProcessTest.Simple (0 ms)
[ RUN ] MesosContainerizerProcessTest.MultipleURIs
[ OK ] MesosContainerizerProcessTest.MultipleURIs (0 ms)
[ RUN ] MesosContainerizerProcessTest.NoUser
[ OK ] MesosContainerizerProcessTest.NoUser (0 ms)
[ RUN ] MesosContainerizerProcessTest.EmptyHadoop
[ OK ] MesosContainerizerProcessTest.EmptyHadoop (0 ms)
[ RUN ] MesosContainerizerProcessTest.NoHadoop
[ OK ] MesosContainerizerProcessTest.NoHadoop (1 ms)
[----------] 5 tests from MesosContainerizerProcessTest (1 ms total)
[----------] 6 tests from ExamplesTest
[ RUN ] ExamplesTest.TestFramework
[ OK ] ExamplesTest.TestFramework (2643 ms)
[ RUN ] ExamplesTest.NoExecutorFramework
[ OK ] ExamplesTest.NoExecutorFramework (2803 ms)
[ RUN ] ExamplesTest.JavaFramework
[ OK ] ExamplesTest.JavaFramework (2360 ms)
[ RUN ] ExamplesTest.JavaException
[ OK ] ExamplesTest.JavaException (224 ms)
[ RUN ] ExamplesTest.JavaLog
[ OK ] ExamplesTest.JavaLog (1814 ms)
[ RUN ] ExamplesTest.PythonFramework
tests/script.cpp:81: Failure
Failed
python_framework_test.sh terminated with signal 'Segmentation fault'
[ FAILED ] ExamplesTest.PythonFramework (4696 ms)
[----------] 6 tests from ExamplesTest (14541 ms total)
[----------] 3 tests from ExceptionTest
[ RUN ] ExceptionTest.DeactivateFrameworkOnAbort
[ OK ] ExceptionTest.DeactivateFrameworkOnAbort (16 ms)
[ RUN ] ExceptionTest.DisallowSchedulerActionsOnAbort
[ OK ] ExceptionTest.DisallowSchedulerActionsOnAbort (8 ms)
[ RUN ] ExceptionTest.DisallowSchedulerCallbacksOnAbort
[ OK ] ExceptionTest.DisallowSchedulerCallbacksOnAbort (27 ms)
[----------] 3 tests from ExceptionTest (52 ms total)
[----------] 24 tests from FaultToleranceTest
[ RUN ] FaultToleranceTest.SlaveLost
[ OK ] FaultToleranceTest.SlaveLost (24 ms)
[ RUN ] FaultToleranceTest.PartitionedSlave
[ OK ] FaultToleranceTest.PartitionedSlave (74 ms)
[ RUN ] FaultToleranceTest.PartitionedSlaveReregistration
[ OK ] FaultToleranceTest.PartitionedSlaveReregistration (175 ms)
[ RUN ] FaultToleranceTest.PartitionedSlaveStatusUpdates
[ OK ] FaultToleranceTest.PartitionedSlaveStatusUpdates (164 ms)
[ RUN ] FaultToleranceTest.PartitionedSlaveExitedExecutor
[ OK ] FaultToleranceTest.PartitionedSlaveExitedExecutor (169 ms)
[ RUN ] FaultToleranceTest.MasterFailover
[ OK ] FaultToleranceTest.MasterFailover (10011 ms)
[ RUN ] FaultToleranceTest.ReregisterCompletedFrameworks
[ OK ] FaultToleranceTest.ReregisterCompletedFrameworks (5062 ms)
[ RUN ] FaultToleranceTest.SchedulerFailover
[ OK ] FaultToleranceTest.SchedulerFailover (26 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[ OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (5040 ms)
[ RUN ] FaultToleranceTest.FrameworkReliableRegistration
[ OK ] FaultToleranceTest.FrameworkReliableRegistration (17 ms)
[ RUN ] FaultToleranceTest.FrameworkReregister
[ OK ] FaultToleranceTest.FrameworkReregister (20 ms)
[ RUN ] FaultToleranceTest.TaskLost
[ OK ] FaultToleranceTest.TaskLost (10 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[ OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (41 ms)
[ RUN ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[ OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1018 ms)
[ RUN ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[ OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (21 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverFrameworkMessage
[ OK ] FaultToleranceTest.SchedulerFailoverFrameworkMessage (1036 ms)
[ RUN ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[ OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (22 ms)
[ RUN ] FaultToleranceTest.SchedulerExit
[ OK ] FaultToleranceTest.SchedulerExit (17 ms)
[ RUN ] FaultToleranceTest.SlaveReliableRegistration
[ OK ] FaultToleranceTest.SlaveReliableRegistration (37 ms)
[ RUN ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[ OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (11 ms)
[ RUN ] FaultToleranceTest.SlaveReregisterTerminatedExecutor
[ OK ] FaultToleranceTest.SlaveReregisterTerminatedExecutor (22 ms)
[ RUN ] FaultToleranceTest.ReconcileLostTasks
[ OK ] FaultToleranceTest.ReconcileLostTasks (19 ms)
[ RUN ] FaultToleranceTest.ReconcileIncompleteTasks
[ OK ] FaultToleranceTest.ReconcileIncompleteTasks (64 ms)
[ RUN ] FaultToleranceTest.SplitBrainMasters
[ OK ] FaultToleranceTest.SplitBrainMasters (31 ms)
[----------] 24 tests from FaultToleranceTest (23132 ms total)
[----------] 6 tests from FilesTest
[ RUN ] FilesTest.AttachTest
[ OK ] FilesTest.AttachTest (2 ms)
[ RUN ] FilesTest.DetachTest
[ OK ] FilesTest.DetachTest (0 ms)
[ RUN ] FilesTest.ReadTest
[ OK ] FilesTest.ReadTest (4 ms)
[ RUN ] FilesTest.ResolveTest
[ OK ] FilesTest.ResolveTest (7 ms)
[ RUN ] FilesTest.BrowseTest
[ OK ] FilesTest.BrowseTest (5 ms)
[ RUN ] FilesTest.DownloadTest
[ OK ] FilesTest.DownloadTest (2 ms)
[----------] 6 tests from FilesTest (20 ms total)
[----------] 3 tests from GarbageCollectorTest
[ RUN ] GarbageCollectorTest.Schedule
[ OK ] GarbageCollectorTest.Schedule (94 ms)
[ RUN ] GarbageCollectorTest.Unschedule
[ OK ] GarbageCollectorTest.Unschedule (72 ms)
[ RUN ] GarbageCollectorTest.Prune
[ OK ] GarbageCollectorTest.Prune (53 ms)
[----------] 3 tests from GarbageCollectorTest (219 ms total)
[----------] 5 tests from GarbageCollectorIntegrationTest
[ RUN ] GarbageCollectorIntegrationTest.Restart
[ OK ] GarbageCollectorIntegrationTest.Restart (73 ms)
[ RUN ] GarbageCollectorIntegrationTest.ExitedFramework
[ OK ] GarbageCollectorIntegrationTest.ExitedFramework (1092 ms)
[ RUN ] GarbageCollectorIntegrationTest.ExitedExecutor
[ OK ] GarbageCollectorIntegrationTest.ExitedExecutor (60 ms)
[ RUN ] GarbageCollectorIntegrationTest.DiskUsage
[ OK ] GarbageCollectorIntegrationTest.DiskUsage (68 ms)
[ RUN ] GarbageCollectorIntegrationTest.Unschedule
[ OK ] GarbageCollectorIntegrationTest.Unschedule (79 ms)
[----------] 5 tests from GarbageCollectorIntegrationTest (1372 ms total)
[----------] 2 tests from CpuIsolatorTest/0, where TypeParam = mesos::internal::slave::PosixCpuIsolatorProcess
[ RUN ] CpuIsolatorTest/0.UserCpuUsage
[ OK ] CpuIsolatorTest/0.UserCpuUsage (1006 ms)
[ RUN ] CpuIsolatorTest/0.SystemCpuUsage
[ OK ] CpuIsolatorTest/0.SystemCpuUsage (1000 ms)
[----------] 2 tests from CpuIsolatorTest/0 (2006 ms total)
[----------] 1 test from NetworkTest
[ RUN ] NetworkTest.Watch
[ OK ] NetworkTest.Watch (2 ms)
[----------] 1 test from NetworkTest (2 ms total)
[----------] 3 tests from LogStorageTest/0, where TypeParam = mesos::internal::log::LevelDBStorage
[ RUN ] LogStorageTest/0.Truncate
[ OK ] LogStorageTest/0.Truncate (273 ms)
[ RUN ] LogStorageTest/0.TruncateWithEmptyLog
[ OK ] LogStorageTest/0.TruncateWithEmptyLog (78 ms)
[ RUN ] LogStorageTest/0.TruncateWithManyHoles
[ OK ] LogStorageTest/0.TruncateWithManyHoles (70 ms)
[----------] 3 tests from LogStorageTest/0 (421 ms total)
[----------] 4 tests from ReplicaTest
[ RUN ] ReplicaTest.Promise
[ OK ] ReplicaTest.Promise (213 ms)
[ RUN ] ReplicaTest.Append
[ OK ] ReplicaTest.Append (251 ms)
[ RUN ] ReplicaTest.Restore
[ OK ] ReplicaTest.Restore (356 ms)
[ RUN ] ReplicaTest.NonVoting
[ OK ] ReplicaTest.NonVoting (81 ms)
[----------] 4 tests from ReplicaTest (901 ms total)
[----------] 21 tests from CoordinatorTest
[ RUN ] CoordinatorTest.Elect
[ OK ] CoordinatorTest.Elect (441 ms)
[ RUN ] CoordinatorTest.ElectWithClockPaused
[ OK ] CoordinatorTest.ElectWithClockPaused (438 ms)
[ RUN ] CoordinatorTest.AppendRead
[ OK ] CoordinatorTest.AppendRead (496 ms)
[ RUN ] CoordinatorTest.AppendReadError
[ OK ] CoordinatorTest.AppendReadError (516 ms)
[ RUN ] CoordinatorTest.AppendDiscarded
[ OK ] CoordinatorTest.AppendDiscarded (453 ms)
[ RUN ] CoordinatorTest.ElectNoQuorum
[ OK ] CoordinatorTest.ElectNoQuorum (187 ms)
[ RUN ] CoordinatorTest.AppendNoQuorum
[ OK ] CoordinatorTest.AppendNoQuorum (452 ms)
[ RUN ] CoordinatorTest.Failover
[ OK ] CoordinatorTest.Failover (468 ms)
[ RUN ] CoordinatorTest.Demoted
[ OK ] CoordinatorTest.Demoted (513 ms)
[ RUN ] CoordinatorTest.Fill
[ OK ] CoordinatorTest.Fill (790 ms)
[ RUN ] CoordinatorTest.NotLearnedFill
[ OK ] CoordinatorTest.NotLearnedFill (818 ms)
[ RUN ] CoordinatorTest.MultipleAppends
[ OK ] CoordinatorTest.MultipleAppends (823 ms)
[ RUN ] CoordinatorTest.MultipleAppendsNotLearnedFill
[ OK ] CoordinatorTest.MultipleAppendsNotLearnedFill (2300 ms)
[ RUN ] CoordinatorTest.Truncate
[ OK ] CoordinatorTest.Truncate (4093 ms)
[ RUN ] CoordinatorTest.TruncateNotLearnedFill
[ OK ] CoordinatorTest.TruncateNotLearnedFill (5136 ms)
[ RUN ] CoordinatorTest.TruncateLearnedFill
[ OK ] CoordinatorTest.TruncateLearnedFill (6109 ms)
[ RUN ] CoordinatorTest.RacingElect
[ OK ] CoordinatorTest.RacingElect (0 ms)
[ RUN ] CoordinatorTest.FillNoQuorum
[ OK ] CoordinatorTest.FillNoQuorum (0 ms)
[ RUN ] CoordinatorTest.FillInconsistent
[ OK ] CoordinatorTest.FillInconsistent (0 ms)
[ RUN ] CoordinatorTest.LearnedOnOneReplica_NotLearnedOnAnother
[ OK ] CoordinatorTest.LearnedOnOneReplica_NotLearnedOnAnother (0 ms)
[ RUN ] CoordinatorTest.LearnedOnOneReplica_NotLearnedOnAnother_AnotherFailsAndRecovers
[ OK ] CoordinatorTest.LearnedOnOneReplica_NotLearnedOnAnother_AnotherFailsAndRecovers (1 ms)
[----------] 21 tests from CoordinatorTest (24035 ms total)
[----------] 2 tests from RecoverTest
[ RUN ] RecoverTest.RacingCatchup
[ OK ] RecoverTest.RacingCatchup (10154 ms)
[ RUN ] RecoverTest.CatchupRetry
[ OK ] RecoverTest.CatchupRetry (12101 ms)
[----------] 2 tests from RecoverTest (22255 ms total)
[----------] 2 tests from LogTest
[ RUN ] LogTest.WriteRead
[ OK ] LogTest.WriteRead (2419 ms)
[ RUN ] LogTest.Position
[ OK ] LogTest.Position (671 ms)
[----------] 2 tests from LogTest (3091 ms total)
[----------] 1 test from LogZooKeeperTest
[ RUN ] LogZooKeeperTest.WriteRead
[ OK ] LogZooKeeperTest.WriteRead (1061 ms)
[----------] 1 test from LogZooKeeperTest (1061 ms total)
[----------] 1 test from LoggingTest
[ RUN ] LoggingTest.Toggle
[ OK ] LoggingTest.Toggle (3 ms)
[----------] 1 test from LoggingTest (3 ms total)
[----------] 1 test from MasterContenderDetectorTest
[ RUN ] MasterContenderDetectorTest.File
[ OK ] MasterContenderDetectorTest.File (11 ms)
[----------] 1 test from MasterContenderDetectorTest (11 ms total)
[----------] 2 tests from BasicMasterContenderDetectorTest
[ RUN ] BasicMasterContenderDetectorTest.Contender
[ OK ] BasicMasterContenderDetectorTest.Contender (5413 ms)
[ RUN ] BasicMasterContenderDetectorTest.Detector
[ OK ] BasicMasterContenderDetectorTest.Detector (5005 ms)
[----------] 2 tests from BasicMasterContenderDetectorTest (10418 ms total)
[----------] 9 tests from ZooKeeperMasterContenderDetectorTest
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterContender
2014-04-14 08:51:58,017:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:52160] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:01,353:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:52160] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f6f7b660000 has expired.
2014-04-14 08:52:01,372:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterContender (8577 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.ContenderPendingElection
2014-04-14 08:52:04,708:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.ContenderPendingElection (5043 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterContenders
2014-04-14 08:52:08,044:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:11,380:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:14,716:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterContenders (10674 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors
2014-04-14 08:52:18,052:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:21,388:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:24,724:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:28,060:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (13841 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork
2014-04-14 08:52:31,396:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:34,732:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:36,248:26043(0x2b9f09560700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:57368] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:36,249:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:57368] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:36,250:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:57368] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:36,250:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:57368] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:38,068:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (8678 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterDetectorTimedoutSession
2014-04-14 08:52:41,404:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:44,740:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:48,077:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:49,709:26043(0x2b9f0a5a5700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:56036] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:49,709:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:56036] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:49,709:26043(0x2b9f09560700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:56036] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:52:49,723:26043(0x2b9f0a7a6700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:56036] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:49,724:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:56036] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:49,724:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:56036] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorTimedoutSession (10123 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireMasterZKSession
2014-04-14 08:52:51,412:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:54,752:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:58,088:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:52:59,858:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:52691] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:01,424:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:03,195:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:52691] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f7059ce0000 has expired.
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireMasterZKSession (13481 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession
2014-04-14 08:53:04,760:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:08,096:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:08,296:26043(0x2b9f0a5a5700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:44759] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:11,432:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:11,632:26043(0x2b9f0a5a5700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:44759] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f708e780001 has expired.
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSession (8435 ms)
[ RUN ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster
2014-04-14 08:53:14,768:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:18,104:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:21,440:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:21,728:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:59583] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:21,732:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:59583] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:21,737:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:59583] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f70af6a0000 has expired.
2014-04-14 08:53:24,776:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:25,064:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:59583] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f70af6a0002 has expired.
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (13431 ms)
[----------] 9 tests from ZooKeeperMasterContenderDetectorTest (92283 ms total)
[----------] 14 tests from MasterTest
[ RUN ] MasterTest.TaskRunning
[ OK ] MasterTest.TaskRunning (35 ms)
[ RUN ] MasterTest.ShutdownFrameworkWhileTaskRunning
[ OK ] MasterTest.ShutdownFrameworkWhileTaskRunning (23 ms)
[ RUN ] MasterTest.KillTask
[ OK ] MasterTest.KillTask (1040 ms)
[ RUN ] MasterTest.StatusUpdateAck
[ OK ] MasterTest.StatusUpdateAck (25 ms)
[ RUN ] MasterTest.RecoverResources
2014-04-14 08:53:28,112:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] MasterTest.RecoverResources (2003 ms)
[ RUN ] MasterTest.FrameworkMessage
[ OK ] MasterTest.FrameworkMessage (23 ms)
[ RUN ] MasterTest.MultipleExecutors
2014-04-14 08:53:31,448:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] MasterTest.MultipleExecutors (5035 ms)
[ RUN ] MasterTest.MasterInfo
[ OK ] MasterTest.MasterInfo (13 ms)
[ RUN ] MasterTest.MasterInfoOnReElection
[ OK ] MasterTest.MasterInfoOnReElection (16 ms)
[ RUN ] MasterTest.MasterLost
[ OK ] MasterTest.MasterLost (14 ms)
[ RUN ] MasterTest.ReconcileTaskTest
[ OK ] MasterTest.ReconcileTaskTest (1029 ms)
[ RUN ] MasterTest.LaunchCombinedOfferTest
2014-04-14 08:53:34,784:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] MasterTest.LaunchCombinedOfferTest (2008 ms)
[ RUN ] MasterTest.LaunchAcrossSlavesTest
[ OK ] MasterTest.LaunchAcrossSlavesTest (23 ms)
[ RUN ] MasterTest.LaunchDuplicateOfferTest
[ OK ] MasterTest.LaunchDuplicateOfferTest (1028 ms)
[----------] 14 tests from MasterTest (12317 ms total)
[----------] 1 test from WhitelistTest
[ RUN ] WhitelistTest.WhitelistSlave
[ OK ] WhitelistTest.WhitelistSlave (14 ms)
[----------] 1 test from WhitelistTest (14 ms total)
[----------] 1 test from MasterZooKeeperTest
[ RUN ] MasterZooKeeperTest.LostZooKeeperCluster
2014-04-14 08:53:37,479:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:51940] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:37,479:26043(0x2b9f0a5a5700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:51940] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:37,480:26043(0x2b9f09560700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:51940] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:37,480:26043(0x2b9f0a7a6700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:51940] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:53:37,482:26043(0x2b9f0a5a5700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:51940] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:37,482:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:51940] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:37,482:26043(0x2b9f09560700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:51940] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:53:37,502:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:51940] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] MasterZooKeeperTest.LostZooKeeperCluster (89 ms)
[----------] 1 test from MasterZooKeeperTest (89 ms total)
[----------] 2 tests from MonitorTest
[ RUN ] MonitorTest.Collection
[ OK ] MonitorTest.Collection (122 ms)
[ RUN ] MonitorTest.Statistics
[ OK ] MonitorTest.Statistics (102 ms)
[----------] 2 tests from MonitorTest (224 ms total)
[----------] 2 tests from PathsTest
[ RUN ] PathsTest.CreateExecutorDirectory
[ OK ] PathsTest.CreateExecutorDirectory (2 ms)
[ RUN ] PathsTest.format
[ OK ] PathsTest.format (2 ms)
[----------] 2 tests from PathsTest (4 ms total)
[----------] 1 test from ProtobufIOTest
[ RUN ] ProtobufIOTest.Basic
2014-04-14 08:53:38,120:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ProtobufIOTest.Basic (547 ms)
[----------] 1 test from ProtobufIOTest (547 ms total)
[----------] 1 test from HealthTest
[ RUN ] HealthTest.ObserveEndpoint
[ OK ] HealthTest.ObserveEndpoint (10 ms)
[----------] 1 test from HealthTest (10 ms total)
[----------] 8 tests from ResourceOffersTest
[ RUN ] ResourceOffersTest.ResourceOfferWithMultipleSlaves
[ OK ] ResourceOffersTest.ResourceOfferWithMultipleSlaves (61 ms)
[ RUN ] ResourceOffersTest.TaskUsesNoResources
[ OK ] ResourceOffersTest.TaskUsesNoResources (1013 ms)
[ RUN ] ResourceOffersTest.TaskUsesInvalidResources
[ OK ] ResourceOffersTest.TaskUsesInvalidResources (1012 ms)
[ RUN ] ResourceOffersTest.TaskUsesMoreResourcesThanOffered
[ OK ] ResourceOffersTest.TaskUsesMoreResourcesThanOffered (11 ms)
[ RUN ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops
[ OK ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops (13 ms)
[ RUN ] ResourceOffersTest.ResourcesGetReofferedWhenUnused
[ OK ] ResourceOffersTest.ResourcesGetReofferedWhenUnused (1015 ms)
[ RUN ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError
[ OK ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError (23 ms)
[ RUN ] ResourceOffersTest.Request
2014-04-14 08:53:41,456:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ResourceOffersTest.Request (15 ms)
[----------] 8 tests from ResourceOffersTest (3164 ms total)
[----------] 1 test from MultipleExecutorsTest
[ RUN ] MultipleExecutorsTest.TasksExecutorInfoDiffers
[ OK ] MultipleExecutorsTest.TasksExecutorInfoDiffers (1020 ms)
[----------] 1 test from MultipleExecutorsTest (1020 ms total)
[----------] 34 tests from ResourcesTest
[ RUN ] ResourcesTest.Parsing
[ OK ] ResourcesTest.Parsing (0 ms)
[ RUN ] ResourcesTest.ParsingWithRoles
[ OK ] ResourcesTest.ParsingWithRoles (0 ms)
[ RUN ] ResourcesTest.ParseError
[ OK ] ResourcesTest.ParseError (0 ms)
[ RUN ] ResourcesTest.Resources
[ OK ] ResourcesTest.Resources (0 ms)
[ RUN ] ResourcesTest.Printing
[ OK ] ResourcesTest.Printing (0 ms)
[ RUN ] ResourcesTest.InitializedIsEmpty
[ OK ] ResourcesTest.InitializedIsEmpty (0 ms)
[ RUN ] ResourcesTest.BadResourcesNotAllocatable
[ OK ] ResourcesTest.BadResourcesNotAllocatable (0 ms)
[ RUN ] ResourcesTest.ScalarEquals
[ OK ] ResourcesTest.ScalarEquals (0 ms)
[ RUN ] ResourcesTest.ScalarSubset
[ OK ] ResourcesTest.ScalarSubset (0 ms)
[ RUN ] ResourcesTest.ScalarSubset2
[ OK ] ResourcesTest.ScalarSubset2 (0 ms)
[ RUN ] ResourcesTest.ScalarAddition
[ OK ] ResourcesTest.ScalarAddition (0 ms)
[ RUN ] ResourcesTest.ScalarAddition2
[ OK ] ResourcesTest.ScalarAddition2 (0 ms)
[ RUN ] ResourcesTest.ScalarSubtraction
[ OK ] ResourcesTest.ScalarSubtraction (0 ms)
[ RUN ] ResourcesTest.ScalarSubtraction2
[ OK ] ResourcesTest.ScalarSubtraction2 (0 ms)
[ RUN ] ResourcesTest.RangesEquals
[ OK ] ResourcesTest.RangesEquals (0 ms)
[ RUN ] ResourcesTest.RangesSubset
[ OK ] ResourcesTest.RangesSubset (0 ms)
[ RUN ] ResourcesTest.RangesAddition
[ OK ] ResourcesTest.RangesAddition (0 ms)
[ RUN ] ResourcesTest.RangesAddition2
[ OK ] ResourcesTest.RangesAddition2 (0 ms)
[ RUN ] ResourcesTest.RangesAdditon3
[ OK ] ResourcesTest.RangesAdditon3 (0 ms)
[ RUN ] ResourcesTest.RangesAddition4
[ OK ] ResourcesTest.RangesAddition4 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction
[ OK ] ResourcesTest.RangesSubtraction (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction1
[ OK ] ResourcesTest.RangesSubtraction1 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction2
[ OK ] ResourcesTest.RangesSubtraction2 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction3
[ OK ] ResourcesTest.RangesSubtraction3 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction4
[ OK ] ResourcesTest.RangesSubtraction4 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction5
[ OK ] ResourcesTest.RangesSubtraction5 (0 ms)
[ RUN ] ResourcesTest.RangesSubtraction6
[ OK ] ResourcesTest.RangesSubtraction6 (0 ms)
[ RUN ] ResourcesTest.SetEquals
[ OK ] ResourcesTest.SetEquals (0 ms)
[ RUN ] ResourcesTest.SetSubset
[ OK ] ResourcesTest.SetSubset (0 ms)
[ RUN ] ResourcesTest.SetAddition
[ OK ] ResourcesTest.SetAddition (0 ms)
[ RUN ] ResourcesTest.SetSubtraction
[ OK ] ResourcesTest.SetSubtraction (0 ms)
[ RUN ] ResourcesTest.EmptyUnequal
[ OK ] ResourcesTest.EmptyUnequal (0 ms)
[ RUN ] ResourcesTest.FlattenRoles
[ OK ] ResourcesTest.FlattenRoles (0 ms)
[ RUN ] ResourcesTest.Find
[ OK ] ResourcesTest.Find (0 ms)
[----------] 34 tests from ResourcesTest (1 ms total)
[----------] 3 tests from SASL
[ RUN ] SASL.success
[ OK ] SASL.success (1 ms)
[ RUN ] SASL.failed1
[ OK ] SASL.failed1 (1 ms)
[ RUN ] SASL.failed2
[ OK ] SASL.failed2 (1 ms)
[----------] 3 tests from SASL (3 ms total)
[----------] 2 tests from SlaveStateTest
[ RUN ] SlaveStateTest.CheckpointProtobuf
[ OK ] SlaveStateTest.CheckpointProtobuf (1 ms)
[ RUN ] SlaveStateTest.CheckpointString
[ OK ] SlaveStateTest.CheckpointString (0 ms)
[----------] 2 tests from SlaveStateTest (1 ms total)
[----------] 23 tests from SlaveRecoveryTest/0, where TypeParam = mesos::internal::slave::MesosContainerizer
[ RUN ] SlaveRecoveryTest/0.RecoverSlaveState
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:43.689877 25467 exec.cpp:131] Version: 0.19.0
I0414 08:53:43.700997 25503 exec.cpp:205] Executor registered on slave 20140414-085342-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 38a35f80-01de-4f25-9398-f055e14d7beb
sh -c 'sleep 1000'
Forked command at 25508
I0414 08:53:43.758008 25503 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 25508
[ OK ] SlaveRecoveryTest/0.RecoverSlaveState (1274 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverStatusUpdateManager
Killing the following process trees:
[
-+- 25508 sh -c sleep 1000
\--- 25509 sleep 1000
]
Command terminated with signal Terminated (pid: 25508)
2014-04-14 08:53:44,792:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:45.669348 25623 exec.cpp:131] Version: 0.19.0
I0414 08:53:45.674710 25651 exec.cpp:205] Executor registered on slave 20140414-085343-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 7e540911-f5a8-46ab-a1d6-9f0bbf4501a0
sh -c 'sleep 1000'
Forked command at 25673
I0414 08:53:45.686954 25651 exec.cpp:251] Received reconnect request from slave 20140414-085343-453759884-36637-26043-0
I0414 08:53:45.687556 25651 exec.cpp:228] Executor re-registered on slave 20140414-085343-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
I0414 08:53:47.692384 25668 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 25673
Killing the following process trees:
[
-+- 25673 sh -c sleep 1000
\--- 25674 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.RecoverStatusUpdateManager (3992 ms)
[ RUN ] SlaveRecoveryTest/0.ReconnectExecutor
2014-04-14 08:53:48,128:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Command terminated with signal Terminated (pid: 25673)
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:49.686183 25811 exec.cpp:131] Version: 0.19.0
I0414 08:53:49.688866 25833 exec.cpp:205] Executor registered on slave 20140414-085347-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 58ce3c1b-ca21-4c10-b587-b406427524d9
sh -c 'sleep 1000'
Forked command at 25850
I0414 08:53:49.712666 25848 exec.cpp:251] Received reconnect request from slave 20140414-085347-453759884-36637-26043-0
I0414 08:53:49.713330 25833 exec.cpp:228] Executor re-registered on slave 20140414-085347-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
2014-04-14 08:53:51,465:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
I0414 08:53:51.716037 25836 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 25850
[ OK ] SlaveRecoveryTest/0.ReconnectExecutor (4000 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverUnregisteredExecutor
Killing the following process trees:
[
-+- 25850 sh -c sleep 1000
\--- 25851 sleep 1000
]
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:52.690428 26124 exec.cpp:131] Version: 0.19.0
Command terminated with signal Terminated (pid: 25850)
[ OK ] SlaveRecoveryTest/0.RecoverUnregisteredExecutor (1201 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverTerminatedExecutor
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:53.751847 26188 exec.cpp:131] Version: 0.19.0
I0414 08:53:53.754268 26217 exec.cpp:205] Executor registered on slave 20140414-085352-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 79d3f6cc-e6b0-4799-87e5-1da6779d648f
Forked command at 26227
sh -c 'sleep 1000'
I0414 08:53:53.829651 26221 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 26227
Killing the following process trees:
[
-+- 26227 sh -c sleep 1000
\--- 26228 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.RecoverTerminatedExecutor (1147 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverCompletedExecutor
2014-04-14 08:53:54,800:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:54.876122 26521 exec.cpp:131] Version: 0.19.0
I0414 08:53:54.887670 26553 exec.cpp:205] Executor registered on slave 20140414-085354-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task ffd11cba-eba3-4cf6-a297-e1e2013fc377
sh -c 'exit 0'
Forked command at 26560
Command exited with status 0 (pid: 26560)
[ OK ] SlaveRecoveryTest/0.RecoverCompletedExecutor (4011 ms)
[ RUN ] SlaveRecoveryTest/0.CleanupExecutor
2014-04-14 08:53:58,140:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:53:58.872355 26609 exec.cpp:131] Version: 0.19.0
I0414 08:53:58.874706 26635 exec.cpp:205] Executor registered on slave 20140414-085358-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 7be7b2e3-67f0-4881-9134-4c12b783d311
sh -c 'sleep 1000'
Forked command at 26648
I0414 08:53:58.963979 26633 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 26648
Killing the following process trees:
[
-+- 26648 sh -c sleep 1000
\--- 26649 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.CleanupExecutor (1212 ms)
[ RUN ] SlaveRecoveryTest/0.RemoveNonCheckpointingFramework
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:01.007161 26828 exec.cpp:131] Version: 0.19.0
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:01.007647 26829 exec.cpp:131] Version: 0.19.0
I0414 08:54:01.012826 26856 exec.cpp:205] Executor registered on slave 20140414-085359-453759884-36637-26043-0
I0414 08:54:01.013104 26884 exec.cpp:205] Executor registered on slave 20140414-085359-453759884-36637-26043-0
Registered executor on hemera.apache.org
Registered executor on hemera.apache.org
Starting task 9f35f250-008d-4db5-9c7b-a7b90193c307
Starting task b496cf9c-aab2-4b1f-9ad1-5f3f78813659
Forked command at 26935
sh -c 'sleep 1000'
sh -c 'sleep 1000'
Forked command at 26931
I0414 08:54:01.017786 26872 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 26935
I0414 08:54:01.018056 26887 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 26931
[ OK ] SlaveRecoveryTest/0.RemoveNonCheckpointingFramework (1698 ms)
[ RUN ] SlaveRecoveryTest/0.NonCheckpointingFramework
Killing the following process trees:
[
-+- 26935 sh -c sleep 1000
\--- 26936 sleep 1000
]
Killing the following process trees:
[
-+- 26931 sh -c sleep 1000
\--- 26937 sleep 1000
]
2014-04-14 08:54:01,476:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Command terminated with signal Terminated (pid: 26935)
Command terminated with signal Terminated (pid: 26931)
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:03.005062 27100 exec.cpp:131] Version: 0.19.0
I0414 08:54:03.007941 27127 exec.cpp:205] Executor registered on slave 20140414-085401-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 95c8b4d8-3db5-4bea-99ba-2e207db0d8b7
sh -c 'sleep 1000'
Forked command at 27139
I0414 08:54:03.034631 27118 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 27139
[ OK ] SlaveRecoveryTest/0.NonCheckpointingFramework (2013 ms)
[ RUN ] SlaveRecoveryTest/0.NonCheckpointingSlave
Killing the following process trees:
[
-+- 27139 sh -c sleep 1000
\--- 27140 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.NonCheckpointingSlave (38 ms)
[ RUN ] SlaveRecoveryTest/0.KillTask
Command terminated with signal Terminated (pid: 27139)
2014-04-14 08:54:04,812:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:05.012635 27166 exec.cpp:131] Version: 0.19.0
I0414 08:54:05.015588 27184 exec.cpp:205] Executor registered on slave 20140414-085403-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 6c5ebcc8-a27a-428f-978c-e410b6ff3083
sh -c 'sleep 1000'
Forked command at 27205
I0414 08:54:05.077924 27192 exec.cpp:251] Received reconnect request from slave 20140414-085403-453759884-36637-26043-0
I0414 08:54:05.078389 27181 exec.cpp:228] Executor re-registered on slave 20140414-085403-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
Shutting down
Sending SIGTERM to process tree at pid 27205
Killing the following process trees:
[
-+- 27205 sh -c sleep 1000
\--- 27206 sleep 1000
]
Command terminated with signal Terminated (pid: 27205)
[ OK ] SlaveRecoveryTest/0.KillTask (3085 ms)
[ RUN ] SlaveRecoveryTest/0.Reboot
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:07.160512 27501 exec.cpp:131] Version: 0.19.0
I0414 08:54:07.163074 27520 exec.cpp:205] Executor registered on slave 20140414-085406-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task bd664840-651d-4292-84df-5d8e7f1b0d56
Forked command at 27541
sh -c 'sleep 1000'
I0414 08:54:07.225210 27518 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 27541
[ OK ] SlaveRecoveryTest/0.Reboot (1081 ms)
[ RUN ] SlaveRecoveryTest/0.GCExecutor
Killing the following process trees:
[
-+- 27541 sh -c sleep 1000
\--- 27542 sleep 1000
]
2014-04-14 08:54:08,148:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:08.164682 27568 exec.cpp:131] Version: 0.19.0
Command terminated with signal Terminated (pid: 27541)
I0414 08:54:08.167659 27597 exec.cpp:205] Executor registered on slave 20140414-085407-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task c80bfece-1399-451e-b32b-63f0d0c0648e
sh -c 'sleep 1000'
Forked command at 27607
I0414 08:54:08.230312 27597 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 27607
Killing the following process trees:
[
-+- 27607 sh -c sleep 1000
\--- 27608 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.GCExecutor (1057 ms)
[ RUN ] SlaveRecoveryTest/0.ShutdownSlave
Command terminated with signal Terminated (pid: 27607)
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:09.277227 27656 exec.cpp:131] Version: 0.19.0
I0414 08:54:09.280292 27680 exec.cpp:205] Executor registered on slave 20140414-085408-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 8c84afcc-8325-4f39-baed-6ff988c81fb9
sh -c 'sleep 1000'
Forked command at 27695
I0414 08:54:09.315440 27691 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 27695
Killing the following process trees:
[
-+- 27695 sh -c sleep 1000
\--- 27696 sleep 1000
]
Command terminated with signal Terminated (pid: 27695)
[ OK ] SlaveRecoveryTest/0.ShutdownSlave (3121 ms)
[ RUN ] SlaveRecoveryTest/0.RegisterDisconnectedSlave
2014-04-14 08:54:11,484:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:12.452249 28050 exec.cpp:131] Version: 0.19.0
I0414 08:54:12.455927 28083 exec.cpp:205] Executor registered on slave 20140414-085411-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task b583a74d-159e-4a0d-8309-916238cc7947
sh -c 'sleep 1000'
Forked command at 28089
I0414 08:54:12.541412 28083 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 28089
[ OK ] SlaveRecoveryTest/0.RegisterDisconnectedSlave (1127 ms)
[ RUN ] SlaveRecoveryTest/0.ReconcileKillTask
Killing the following process trees:
[
-+- 28089 sh -c sleep 1000
\--- 28090 sleep 1000
]
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:13.447602 28327 exec.cpp:131] Version: 0.19.0
I0414 08:54:13.449823 28379 exec.cpp:205] Executor registered on slave 20140414-085412-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task ac56de77-1cbd-4abe-bf72-b954c2b1bc19
sh -c 'sleep 1000'
Forked command at 28399
Command terminated with signal Terminated (pid: 28089)
I0414 08:54:13.526600 28371 exec.cpp:251] Received reconnect request from slave 20140414-085412-453759884-36637-26043-0
I0414 08:54:13.527184 28379 exec.cpp:228] Executor re-registered on slave 20140414-085412-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
2014-04-14 08:54:14,820:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Shutting down
Sending SIGTERM to process tree at pid 28399
Killing the following process trees:
[
-+- 28399 sh -c sleep 1000
\--- 28400 sleep 1000
]
Command terminated with signal Terminated (pid: 28399)
[ OK ] SlaveRecoveryTest/0.ReconcileKillTask (5013 ms)
[ RUN ] SlaveRecoveryTest/0.ReconcileShutdownFramework
2014-04-14 08:54:18,156:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:19.451314 28836 exec.cpp:131] Version: 0.19.0
I0414 08:54:19.457083 28870 exec.cpp:205] Executor registered on slave 20140414-085417-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task b9b2b381-e6f0-48c4-8831-fcd303f186ef
Forked command at 28880
sh -c 'sleep 1000'
I0414 08:54:19.536293 28877 exec.cpp:251] Received reconnect request from slave 20140414-085417-453759884-36637-26043-0
I0414 08:54:19.536861 28874 exec.cpp:228] Executor re-registered on slave 20140414-085417-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
2014-04-14 08:54:21,492:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
I0414 08:54:21.537737 28855 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 28880
Killing the following process trees:
[
-+- 28880 sh -c sleep 1000
\--- 28881 sleep 1000
]
Command terminated with signal Terminated (pid: 28880)
[ OK ] SlaveRecoveryTest/0.ReconcileShutdownFramework (6880 ms)
[ RUN ] SlaveRecoveryTest/0.ReconcileTasksMissingFromSlave
2014-04-14 08:54:24,828:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:26.475428 29098 exec.cpp:131] Version: 0.19.0
I0414 08:54:26.477978 29123 exec.cpp:205] Executor registered on slave 20140414-085424-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task bd57855e-8e86-4f76-a5a4-b1267e83c2f5
Forked command at 29137
sh -c 'sleep 10'
[ OK ] SlaveRecoveryTest/0.ReconcileTasksMissingFromSlave (2244 ms)
[ RUN ] SlaveRecoveryTest/0.SchedulerFailover
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:27.680088 29161 exec.cpp:131] Version: 0.19.0
I0414 08:54:27.682752 29194 exec.cpp:205] Executor registered on slave 20140414-085426-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task b457c26b-8a9e-4ed1-a888-0c291ab455f1
Forked command at 29200
sh -c 'sleep 1000'
I0414 08:54:27.768344 29192 exec.cpp:251] Received reconnect request from slave 20140414-085426-453759884-36637-26043-0
I0414 08:54:27.774251 29192 exec.cpp:228] Executor re-registered on slave 20140414-085426-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
Shutting down
Sending SIGTERM to process tree at pid 29200
Killing the following process trees:
[
-+- 29200 sh -c sleep 1000
\--- 29201 sleep 1000
]
2014-04-14 08:54:28,164:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Command terminated with signal Terminated (pid: 29200)
[ OK ] SlaveRecoveryTest/0.SchedulerFailover (2117 ms)
[ RUN ] SlaveRecoveryTest/0.PartitionedSlave
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:29.817461 29224 exec.cpp:131] Version: 0.19.0
I0414 08:54:29.819918 29238 exec.cpp:205] Executor registered on slave 20140414-085428-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task f66b4507-70de-4fbd-9fa0-687288b2cd84
sh -c 'sleep 1000'
Forked command at 29263
I0414 08:54:30.035326 29259 exec.cpp:378] Executor asked to shutdown
Shutting down
Sending SIGTERM to process tree at pid 29263
Killing the following process trees:
[
-+- 29263 sh -c sleep 1000
\--- 29264 sleep 1000
]
[ OK ] SlaveRecoveryTest/0.PartitionedSlave (1522 ms)
[ RUN ] SlaveRecoveryTest/0.MasterFailover
2014-04-14 08:54:31,500:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:31.939115 29287 exec.cpp:131] Version: 0.19.0
I0414 08:54:31.942083 29307 exec.cpp:205] Executor registered on slave 20140414-085430-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 09c08e92-754e-4aeb-857e-d248e2764740
Forked command at 29326
sh -c 'sleep 1000'
2014-04-14 08:54:34,836:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
I0414 08:54:37.030678 29324 exec.cpp:251] Received reconnect request from slave 20140414-085430-453759884-36637-26043-0
I0414 08:54:37.031190 29309 exec.cpp:228] Executor re-registered on slave 20140414-085430-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
Shutting down
Sending SIGTERM to process tree at pid 29326
Killing the following process trees:
[
-+- 29326 sh -c sleep 1000
\--- 29327 sleep 1000
]
Command terminated with signal Terminated (pid: 29326)
2014-04-14 08:54:38,172:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] SlaveRecoveryTest/0.MasterFailover (8728 ms)
[ RUN ] SlaveRecoveryTest/0.MultipleFrameworks
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:40.060968 29350 exec.cpp:131] Version: 0.19.0
I0414 08:54:40.063446 29373 exec.cpp:205] Executor registered on slave 20140414-085439-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 8e4e602b-ca57-43e2-ae31-6a8f93b97951
sh -c 'sleep 1000'
Forked command at 29389
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:41.061483 29414 exec.cpp:131] Version: 0.19.0
I0414 08:54:41.067380 29431 exec.cpp:205] Executor registered on slave 20140414-085439-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 84bebe58-a2b6-4abb-ab98-fc21ea8e889b
Forked command at 29453
sh -c 'sleep 1000'
I0414 08:54:41.150735 29431 exec.cpp:251] Received reconnect request from slave 20140414-085439-453759884-36637-26043-0
I0414 08:54:41.150734 29373 exec.cpp:251] Received reconnect request from slave 20140414-085439-453759884-36637-26043-0
I0414 08:54:41.151165 29373 exec.cpp:228] Executor re-registered on slave 20140414-085439-453759884-36637-26043-0
I0414 08:54:41.151320 29430 exec.cpp:228] Executor re-registered on slave 20140414-085439-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
Re-registered executor on hemera.apache.org
Shutting down
Sending SIGTERM to process tree at pid 29389
Killing the following process trees:
[
-+- 29389 sh -c sleep 1000
\--- 29390 sleep 1000
]
2014-04-14 08:54:41,508:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Command terminated with signal Terminated (pid: 29389)
Shutting down
Sending SIGTERM to process tree at pid 29453
Killing the following process trees:
[
-+- 29453 sh -c sleep 1000
\--- 29454 sleep 1000
]
Command terminated with signal Terminated (pid: 29453)
[ OK ] SlaveRecoveryTest/0.MultipleFrameworks (5121 ms)
[ RUN ] SlaveRecoveryTest/0.MultipleSlaves
2014-04-14 08:54:44,844:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:54:48,180:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:50.188988 29477 exec.cpp:131] Version: 0.19.0
I0414 08:54:50.192054 29501 exec.cpp:205] Executor registered on slave 20140414-085444-453759884-36637-26043-0
Registered executor on hemera.apache.org
Starting task 87b3977f-adbb-4432-9dfd-aed6c00f684a
Forked command at 29516
sh -c 'sleep 1000'
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0414 08:54:51.194082 29540 exec.cpp:131] Version: 0.19.0
I0414 08:54:51.197876 29569 exec.cpp:205] Executor registered on slave 20140414-085444-453759884-36637-26043-1
Registered executor on hemera.apache.org
Starting task 769ac0a9-1236-42bc-a398-2d2ba9589b83
Forked command at 29579
sh -c 'sleep 1000'
I0414 08:54:51.276893 29495 exec.cpp:251] Received reconnect request from slave 20140414-085444-453759884-36637-26043-0
I0414 08:54:51.277494 29495 exec.cpp:228] Executor re-registered on slave 20140414-085444-453759884-36637-26043-0
Re-registered executor on hemera.apache.org
I0414 08:54:51.279206 29575 exec.cpp:251] Received reconnect request from slave 20140414-085444-453759884-36637-26043-1
I0414 08:54:51.284173 29554 exec.cpp:228] Executor re-registered on slave 20140414-085444-453759884-36637-26043-1
Re-registered executor on hemera.apache.org
Shutting down
Sending SIGTERM to process tree at pid 29516
Shutting down
Sending SIGTERM to process tree at pid 29579
Killing the following process trees:
Killing the following process trees:
[
-+- 29579 sh -c sleep 1000
\--- 29580 sleep 1000
[
-+- 29516 sh -c sleep 1000
\--- 29517 sleep 1000
]
]
2014-04-14 08:54:51,516:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
Command terminated with signal Terminated (pid: 29516)
Command terminated with signal Terminated (pid: 29579)
[ OK ] SlaveRecoveryTest/0.MultipleSlaves (9125 ms)
[----------] 23 tests from SlaveRecoveryTest/0 (70810 ms total)
[----------] 2 tests from SlaveTest
[ RUN ] SlaveTest.ShutdownUnregisteredExecutor
2014-04-14 08:54:54,853:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] SlaveTest.ShutdownUnregisteredExecutor (2149 ms)
[ RUN ] SlaveTest.RemoveUnregisteredTerminatedExecutor
[ OK ] SlaveTest.RemoveUnregisteredTerminatedExecutor (25 ms)
[----------] 2 tests from SlaveTest (2174 ms total)
[----------] 2 tests from SorterTest
[ RUN ] SorterTest.DRFSorter
[ OK ] SorterTest.DRFSorter (1 ms)
[ RUN ] SorterTest.WDRFSorter
[ OK ] SorterTest.WDRFSorter (0 ms)
[----------] 2 tests from SorterTest (1 ms total)
[----------] 7 tests from InMemoryStateTest
[ RUN ] InMemoryStateTest.FetchAndStoreAndFetch
[ OK ] InMemoryStateTest.FetchAndStoreAndFetch (4 ms)
[ RUN ] InMemoryStateTest.FetchAndStoreAndStoreAndFetch
[ OK ] InMemoryStateTest.FetchAndStoreAndStoreAndFetch (22 ms)
[ RUN ] InMemoryStateTest.FetchAndStoreAndStoreFailAndFetch
[ OK ] InMemoryStateTest.FetchAndStoreAndStoreFailAndFetch (6 ms)
[ RUN ] InMemoryStateTest.FetchAndStoreAndExpungeAndFetch
[ OK ] InMemoryStateTest.FetchAndStoreAndExpungeAndFetch (25 ms)
[ RUN ] InMemoryStateTest.FetchAndStoreAndExpungeAndExpunge
[ OK ] InMemoryStateTest.FetchAndStoreAndExpungeAndExpunge (3 ms)
[ RUN ] InMemoryStateTest.FetchAndStoreAndExpungeAndStoreAndFetch
[ OK ] InMemoryStateTest.FetchAndStoreAndExpungeAndStoreAndFetch (17 ms)
[ RUN ] InMemoryStateTest.Names
[ OK ] InMemoryStateTest.Names (8 ms)
[----------] 7 tests from InMemoryStateTest (86 ms total)
[----------] 7 tests from LevelDBStateTest
[ RUN ] LevelDBStateTest.FetchAndStoreAndFetch
[ OK ] LevelDBStateTest.FetchAndStoreAndFetch (200 ms)
[ RUN ] LevelDBStateTest.FetchAndStoreAndStoreAndFetch
[ OK ] LevelDBStateTest.FetchAndStoreAndStoreAndFetch (250 ms)
[ RUN ] LevelDBStateTest.FetchAndStoreAndStoreFailAndFetch
[ OK ] LevelDBStateTest.FetchAndStoreAndStoreFailAndFetch (231 ms)
[ RUN ] LevelDBStateTest.FetchAndStoreAndExpungeAndFetch
[ OK ] LevelDBStateTest.FetchAndStoreAndExpungeAndFetch (222 ms)
[ RUN ] LevelDBStateTest.FetchAndStoreAndExpungeAndExpunge
[ OK ] LevelDBStateTest.FetchAndStoreAndExpungeAndExpunge (185 ms)
[ RUN ] LevelDBStateTest.FetchAndStoreAndExpungeAndStoreAndFetch
[ OK ] LevelDBStateTest.FetchAndStoreAndExpungeAndStoreAndFetch (263 ms)
[ RUN ] LevelDBStateTest.Names
[ OK ] LevelDBStateTest.Names (162 ms)
[----------] 7 tests from LevelDBStateTest (1514 ms total)
[----------] 8 tests from LogStateTest
[ RUN ] LogStateTest.FetchAndStoreAndFetch
[ OK ] LogStateTest.FetchAndStoreAndFetch (532 ms)
[ RUN ] LogStateTest.FetchAndStoreAndStoreAndFetch
[ OK ] LogStateTest.FetchAndStoreAndStoreAndFetch (516 ms)
[ RUN ] LogStateTest.FetchAndStoreAndStoreFailAndFetch
2014-04-14 08:54:58,188:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] LogStateTest.FetchAndStoreAndStoreFailAndFetch (511 ms)
[ RUN ] LogStateTest.FetchAndStoreAndExpungeAndFetch
[ OK ] LogStateTest.FetchAndStoreAndExpungeAndFetch (515 ms)
[ RUN ] LogStateTest.FetchAndStoreAndExpungeAndExpunge
[ OK ] LogStateTest.FetchAndStoreAndExpungeAndExpunge (472 ms)
[ RUN ] LogStateTest.FetchAndStoreAndExpungeAndStoreAndFetch
[ OK ] LogStateTest.FetchAndStoreAndExpungeAndStoreAndFetch (617 ms)
[ RUN ] LogStateTest.Names
[ OK ] LogStateTest.Names (489 ms)
[ RUN ] LogStateTest.Timeout
[ OK ] LogStateTest.Timeout (474 ms)
[----------] 8 tests from LogStateTest (4126 ms total)
[----------] 7 tests from ZooKeeperStateTest
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndFetch
[ OK ] ZooKeeperStateTest.FetchAndStoreAndFetch (74 ms)
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndStoreAndFetch
[ OK ] ZooKeeperStateTest.FetchAndStoreAndStoreAndFetch (48 ms)
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndStoreFailAndFetch
[ OK ] ZooKeeperStateTest.FetchAndStoreAndStoreFailAndFetch (96 ms)
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndFetch
2014-04-14 08:55:01,524:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndFetch (146 ms)
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndExpunge
[ OK ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndExpunge (46 ms)
[ RUN ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndStoreAndFetch
[ OK ] ZooKeeperStateTest.FetchAndStoreAndExpungeAndStoreAndFetch (99 ms)
[ RUN ] ZooKeeperStateTest.Names
[ OK ] ZooKeeperStateTest.Names (44 ms)
[----------] 7 tests from ZooKeeperStateTest (553 ms total)
[----------] 7 tests from StatusUpdateManagerTest
[ RUN ] StatusUpdateManagerTest.CheckpointStatusUpdate
[ OK ] StatusUpdateManagerTest.CheckpointStatusUpdate (104 ms)
[ RUN ] StatusUpdateManagerTest.RetryStatusUpdate
[ OK ] StatusUpdateManagerTest.RetryStatusUpdate (212 ms)
[ RUN ] StatusUpdateManagerTest.IgnoreDuplicateStatusUpdateAck
[ OK ] StatusUpdateManagerTest.IgnoreDuplicateStatusUpdateAck (1169 ms)
[ RUN ] StatusUpdateManagerTest.IgnoreUnexpectedStatusUpdateAck
[ OK ] StatusUpdateManagerTest.IgnoreUnexpectedStatusUpdateAck (55 ms)
[ RUN ] StatusUpdateManagerTest.DuplicateTerminalUpdateBeforeAck
[ OK ] StatusUpdateManagerTest.DuplicateTerminalUpdateBeforeAck (149 ms)
[ RUN ] StatusUpdateManagerTest.DuplicateTerminalUpdateAfterAck
[ OK ] StatusUpdateManagerTest.DuplicateTerminalUpdateAfterAck (1120 ms)
[ RUN ] StatusUpdateManagerTest.DuplicateUpdateBeforeAck
2014-04-14 08:55:04,860:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] StatusUpdateManagerTest.DuplicateUpdateBeforeAck (1133 ms)
[----------] 7 tests from StatusUpdateManagerTest (3942 ms total)
[----------] 1 test from ZooKeeper
[ RUN ] ZooKeeper.URL
[ OK ] ZooKeeper.URL (0 ms)
[----------] 1 test from ZooKeeper (0 ms total)
[----------] 3 tests from FsTest
[ RUN ] FsTest.MountTableRead
[ OK ] FsTest.MountTableRead (0 ms)
[ RUN ] FsTest.MountTableHasOption
[ OK ] FsTest.MountTableHasOption (1 ms)
[ RUN ] FsTest.FileSystemTableRead
[ OK ] FsTest.FileSystemTableRead (5 ms)
[----------] 3 tests from FsTest (6 ms total)
[----------] 6 tests from ZooKeeperTest
[ RUN ] ZooKeeperTest.Auth
2014-04-14 08:55:08,196:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperTest.Auth (4042 ms)
[ RUN ] ZooKeeperTest.SessionTimeoutNegotiation
[ OK ] ZooKeeperTest.SessionTimeoutNegotiation (33 ms)
[ RUN ] ZooKeeperTest.Create
2014-04-14 08:55:11,532:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperTest.Create (4105 ms)
[ RUN ] ZooKeeperTest.LeaderDetector
[ OK ] ZooKeeperTest.LeaderDetector (70 ms)
[ RUN ] ZooKeeperTest.LeaderDetectorTimeoutHandling
2014-04-14 08:55:14,005:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:40529] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:14,016:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:40529] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:14,868:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:18,204:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:21,540:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:24,876:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperTest.LeaderDetectorTimeoutHandling (13079 ms)
[ RUN ] ZooKeeperTest.LeaderContender
2014-04-14 08:55:27,106:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:57407] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:28,212:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:30,443:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:57407] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f72c0340000 has expired.
2014-04-14 08:55:30,462:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:57407] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:30,470:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:57407] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f72c0340001 has expired.
2014-04-14 08:55:30,655:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:57407] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:30,669:26043(0x2b9f0935f700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:57407] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:31,548:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] ZooKeeperTest.LeaderContender (7120 ms)
[----------] 6 tests from ZooKeeperTest (28449 ms total)
[----------] 9 tests from GroupTest
[ RUN ] GroupTest.Group
[ OK ] GroupTest.Group (149 ms)
[ RUN ] GroupTest.GroupJoinWithDisconnect
2014-04-14 08:55:34,299:26043(0x2b9f08d48700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:49923] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:34,884:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] GroupTest.GroupJoinWithDisconnect (1716 ms)
[ RUN ] GroupTest.GroupDataWithDisconnect
2014-04-14 08:55:36,060:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:54859] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:36,061:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:54859] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] GroupTest.GroupDataWithDisconnect (2064 ms)
[ RUN ] GroupTest.GroupCancelWithDisconnect
2014-04-14 08:55:38,121:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:59518] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:38,127:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:59518] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:38,220:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] GroupTest.GroupCancelWithDisconnect (2061 ms)
[ RUN ] GroupTest.GroupWatchWithSessionExpiration
2014-04-14 08:55:40,181:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:49206] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:41,556:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:42,183:26043(0x2b9f0a3a4700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:49206] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f72f36a0000 has expired.
[ OK ] GroupTest.GroupWatchWithSessionExpiration (2053 ms)
[ RUN ] GroupTest.MultipleGroups
2014-04-14 08:55:42,250:26043(0x2b9f09560700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:51377] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
[ OK ] GroupTest.MultipleGroups (65 ms)
[ RUN ] GroupTest.GroupPathWithRestrictivePerms
2014-04-14 08:55:44,892:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:48,228:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] GroupTest.GroupPathWithRestrictivePerms (8247 ms)
[ RUN ] GroupTest.RetryableErrors
2014-04-14 08:55:51,564:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:52,518:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:47578] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:54,520:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:47578] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f731be70000 has expired.
2014-04-14 08:55:54,900:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:56,534:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:47578] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:55:56,535:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:47578] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f731be70001 has expired.
2014-04-14 08:55:58,236:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:55:58,811:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:47578] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:56:00,812:26043(0x2b9f09962700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:47578] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f731be70002 has expired.
2014-04-14 08:56:01,572:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:56:02,830:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1721: Socket [127.0.0.1:47578] zk retcode=-4, errno=112(Host is down): failed while receiving a server response
2014-04-14 08:56:04,833:26043(0x2b9f08b47700):ZOO_ERROR@handle_socket_error_msg@1739: Socket [127.0.0.1:47578] zk retcode=-112, errno=116(Stale NFS file handle): sessionId=0x1455f731be70003 has expired.
2014-04-14 08:56:04,908:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] GroupTest.RetryableErrors (16346 ms)
[ RUN ] GroupTest.LabelledGroup
[ OK ] GroupTest.LabelledGroup (59 ms)
[----------] 9 tests from GroupTest (32760 ms total)
[----------] 2 tests from AllocatorZooKeeperTest/0, where TypeParam = mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter>
[ RUN ] AllocatorZooKeeperTest/0.FrameworkReregistersFirst
2014-04-14 08:56:08,244:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
2014-04-14 08:56:11,580:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] AllocatorZooKeeperTest/0.FrameworkReregistersFirst (5100 ms)
[ RUN ] AllocatorZooKeeperTest/0.SlaveReregistersFirst
2014-04-14 08:56:14,916:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] AllocatorZooKeeperTest/0.SlaveReregistersFirst (5103 ms)
[----------] 2 tests from AllocatorZooKeeperTest/0 (10203 ms total)
[----------] 10 tests from Strict/RegistrarTest
[ RUN ] Strict/RegistrarTest.recover/0
[ OK ] Strict/RegistrarTest.recover/0 (306 ms)
[ RUN ] Strict/RegistrarTest.recover/1
[ OK ] Strict/RegistrarTest.recover/1 (234 ms)
[ RUN ] Strict/RegistrarTest.admit/0
[ OK ] Strict/RegistrarTest.admit/0 (244 ms)
[ RUN ] Strict/RegistrarTest.admit/1
[ OK ] Strict/RegistrarTest.admit/1 (208 ms)
[ RUN ] Strict/RegistrarTest.readmit/0
2014-04-14 08:56:18,252:26043(0x2b9f08f49700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:52160] zk retcode=-4, errno=111(Connection refused): server refused to accept the client
[ OK ] Strict/RegistrarTest.readmit/0 (285 ms)
[ RUN ] Strict/RegistrarTest.readmit/1
[ OK ] Strict/RegistrarTest.readmit/1 (256 ms)
[ RUN ] Strict/RegistrarTest.remove/0
[ OK ] Strict/RegistrarTest.remove/0 (462 ms)
[ RUN ] Strict/RegistrarTest.remove/1
[ OK ] Strict/RegistrarTest.remove/1 (480 ms)
[ RUN ] Strict/RegistrarTest.bootstrap/0
[ OK ] Strict/RegistrarTest.bootstrap/0 (237 ms)
[ RUN ] Strict/RegistrarTest.bootstrap/1
[ OK ] Strict/RegistrarTest.bootstrap/1 (229 ms)
[----------] 10 tests from Strict/RegistrarTest (2942 ms total)
[----------] Global test environment tear-down
[==========] 289 tests from 50 test cases ran. (404866 ms total)
[ PASSED ] 288 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ExamplesTest.PythonFramework
1 FAILED TEST
YOU HAVE 1 DISABLED TEST
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On April 14, 2014, 8 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 8 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review40254
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 14, 2014, 1 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 1 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix mesos command parsing help
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> The root cause is the directory contains available mesos commands are
> added more than one times when recursive to main() again.
>
> Idea comes from Adam B.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: Fix mesos command parsing help
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
(Updated April 14, 2014, 4 p.m.)
Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone.
Changes
-------
takes Adam B's solution
Summary (updated)
-----------------
Fix mesos command parsing help
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description (updated)
-------
Fix mesos command parsing help
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
The root cause is the directory contains available mesos commands are
added more than one times when recursive to main() again.
Idea comes from Adam B.
Review: https://reviews.apache.org/r/19180
Diffs (updated)
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
(Updated April 1, 2014, 1:53 p.m.)
Review request for mesos, Adam B, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description
-------
cli: only add local bin direcotry to PATH at first through
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
Review: https://reviews.apache.org/r/19180
Diffs
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Chengwei Yang <ch...@gmail.com>.
> On March 28, 2014, 3:41 p.m., Adam B wrote:
> > src/cli/mesos.cpp, lines 89-92
> > <https://reviews.apache.org/r/19180/diff/2/?file=519554#file519554line89>
> >
> > This code is the real problem. Don't recurse back into main or the paths will get doubly-added. There's actually nothing above here that we need to do again, so don't recurse at all. Drop line 92 "return main(argc, argv);"
> > and to make it fall through, just change line 94 from
> > "} else if (...) {" to
> > "}
> > if (...) {"
> > Now "mesos help foo" will just turn into "mesos foo --help" and keep going.
> > This solves everything except "mesos help help", which can be fixed by replacing line 85 "if (argc == 2) {" with "if (argc == 2 || string(argv[2]) == "help") {".
This is another alternative solution, not recurse anything but introduce a special case (argv[2] is "help"). I'd say there maybe the 3rd, 4th alternative solutions, I'm waiting for a committer to decide. I'm not going to waste time on creating several patches to fix such a small problem.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review38880
-----------------------------------------------------------
On March 26, 2014, 9:32 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 9:32 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review38880
-----------------------------------------------------------
Found the real problem. Let's stop recursing into main().
src/cli/mesos.cpp
<https://reviews.apache.org/r/19180/#comment71211>
This code is the real problem. Don't recurse back into main or the paths will get doubly-added. There's actually nothing above here that we need to do again, so don't recurse at all. Drop line 92 "return main(argc, argv);"
and to make it fall through, just change line 94 from
"} else if (...) {" to
"}
if (...) {"
Now "mesos help foo" will just turn into "mesos foo --help" and keep going.
This solves everything except "mesos help help", which can be fixed by replacing line 85 "if (argc == 2) {" with "if (argc == 2 || string(argv[2]) == "help") {".
- Adam B
On March 25, 2014, 6:32 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 6:32 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Niklas Nielsen <ni...@qni.dk>.
> On March 27, 2014, 10:04 a.m., Niklas Nielsen wrote:
> > src/cli/mesos.cpp, line 61
> > <https://reviews.apache.org/r/19180/diff/2/?file=519554#file519554line61>
> >
> > How about moving this block to a helper we call once? For instance:
> >
> > static Try<Nothing> result = addPath(argv[0]);
> >
> > Or else, just rename firstThrough. It doesn't capture much context on the problem it solves; How about pathAdded and initialize with false?
>
> Chengwei Yang wrote:
> Why I think firstThrough is much readable than pathAdded because we only *try to add* it to $PATH at first through, regardless whether it was added or not.
>
> However, pathAdded means, if it didn't been added in first through, pathAdded should be false, then we'll try again. That's not what I want, because nothing changed after first through, so the later tries just fail again and again.
Still not convinced and think we would need a third opinion here.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review38756
-----------------------------------------------------------
On March 25, 2014, 6:32 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 6:32 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Chengwei Yang <ch...@gmail.com>.
> On March 28, 2014, 1:04 a.m., Niklas Nielsen wrote:
> > src/cli/mesos.cpp, line 61
> > <https://reviews.apache.org/r/19180/diff/2/?file=519554#file519554line61>
> >
> > How about moving this block to a helper we call once? For instance:
> >
> > static Try<Nothing> result = addPath(argv[0]);
> >
> > Or else, just rename firstThrough. It doesn't capture much context on the problem it solves; How about pathAdded and initialize with false?
Why I think firstThrough is much readable than pathAdded because we only *try to add* it to $PATH at first through, regardless whether it was added or not.
However, pathAdded means, if it didn't been added in first through, pathAdded should be false, then we'll try again. That's not what I want, because nothing changed after first through, so the later tries just fail again and again.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review38756
-----------------------------------------------------------
On March 26, 2014, 9:32 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 9:32 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review38756
-----------------------------------------------------------
src/cli/mesos.cpp
<https://reviews.apache.org/r/19180/#comment71028>
How about moving this block to a helper we call once? For instance:
static Try<Nothing> result = addPath(argv[0]);
Or else, just rename firstThrough. It doesn't capture much context on the problem it solves; How about pathAdded and initialize with false?
- Niklas Nielsen
On March 25, 2014, 6:32 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 6:32 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
(Updated March 26, 2014, 9:32 a.m.)
Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description
-------
cli: only add local bin direcotry to PATH at first through
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
Review: https://reviews.apache.org/r/19180
Diffs
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/#review37340
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19180]
All tests passed.
- Mesos ReviewBot
On March 15, 2014, 7:13 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19180/
> -----------------------------------------------------------
>
> (Updated March 15, 2014, 7:13 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1093
> https://issues.apache.org/jira/browse/MESOS-1093
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> cli: only add local bin direcotry to PATH at first through
>
> Without this patch, "mesos help --help" will output below
>
> Not expecting '--help' before command
> Usage: mesos <command> [OPTIONS]
>
> Available commands:
> help
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
> resolve
> cat
> scp
> log
> tail
> execute
> ps
> local
>
> Apparently all available commands printed twice, the "mesos help help"
> will print available commands 3 times.
>
> Review: https://reviews.apache.org/r/19180
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
>
> Diff: https://reviews.apache.org/r/19180/diff/
>
>
> Testing
> -------
>
> done?
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19180: cli: only add local bin direcotry to PATH at first
through
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19180/
-----------------------------------------------------------
(Updated March 15, 2014, 3:13 p.m.)
Review request for mesos.
Changes
-------
comply with coding style. first_through --> firstThrough.
Bugs: MESOS-1093
https://issues.apache.org/jira/browse/MESOS-1093
Repository: mesos-git
Description (updated)
-------
cli: only add local bin direcotry to PATH at first through
Without this patch, "mesos help --help" will output below
Not expecting '--help' before command
Usage: mesos <command> [OPTIONS]
Available commands:
help
resolve
cat
scp
log
tail
execute
ps
local
resolve
cat
scp
log
tail
execute
ps
local
Apparently all available commands printed twice, the "mesos help help"
will print available commands 3 times.
Review: https://reviews.apache.org/r/19180
Diffs (updated)
-----
src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86
Diff: https://reviews.apache.org/r/19180/diff/
Testing
-------
done?
Thanks,
Chengwei Yang