You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by Prashant Pogde <pp...@cloudera.com.INVALID> on 2023/01/27 01:09:43 UTC
[RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
We are concluding the vote thread with 7 +votes and 0 objections.
We will go ahead and merge the Snapshot branch into master.
Thank you
Prashant
> On Jan 24, 2023, at 7:07 PM, Neil Joshi <ne...@gmail.com> wrote:
>
> Hi guys,
>
> Great work. Thanks. +1 for merge.
>
> Regards,
> Neil
>
> On Mon, Jan 23, 2023 at 5:28 AM Ayush Saxena <ay...@gmail.com> wrote:
>
>> +1
>>
>> -Ayush
>>
>>> On 23-Jan-2023, at 3:27 PM, Sadanand Shenoy <ss...@apache.org> wrote:
>>>
>>> +1 for the merge.
>>>
>>> Thanks,
>>> Sadanand
>>>
>>>> On Mon, Jan 23, 2023 at 3:06 PM NILOTPAL NANDI <
>> nilotpal.apache@gmail.com>
>>>> wrote:
>>>>
>>>> +1 for the merge.
>>>>
>>>> Thanks,
>>>> Nilotpal Nandi
>>>>
>>>>> On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
>>>>>
>>>>> +1
>>>>> Tsz-Wo
>>>>>
>>>>> On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org>
>>>> wrote:
>>>>>
>>>>>> +1 for the merge.
>>>>>>
>>>>>> - Sid
>>>>>>
>>>>>> On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
>>>>>> umagangumalla@gmail.com> wrote:
>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> Regards,
>>>>>>> Uma
>>>>>>>
>>>>>>> On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
>>>>>>> <pp...@cloudera.com.invalid>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> We would like to start this Vote thread for the proposal to merge
>>>>>>>> https://issues.apache.org/jira/browse/HDDS-6517 <
>>>>>>>> https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
>>>>>>>>
>>>>>>>> Ozone Snapshot feature allows us to take a point in time frozen
>>>> image
>>>>>> of
>>>>>>>> the Ozone dataset. Initially this feature would allow snapshots to
>>>> be
>>>>>>> taken
>>>>>>>> at bucket granularity. Subsequently the feature can support
>>>> Snapshots
>>>>>>>> at Volume level as well as the whole Ozone Namespace level.
>>>>>>>>
>>>>>>>> Note that HDDS-6517 is a new feature such that it is mainly adding
>>>>> new
>>>>>>>> code. Therefore, the risk is very low to the existing
>>>>> functionalities
>>>>>>> and
>>>>>>>> features in Ozone.
>>>>>>>>
>>>>>>>> When the Snapshot feature is not used, it should cause no impact to
>>>>> the
>>>>>>>> master.
>>>>>>>> For more information, please check out Ozone Snapshot feature Jira
>>>>>>>> (HDDS-6517) and feature wiki page here:
>>>>>>>>
>>>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
>>>> <
>>>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Ozone Snapshot Team
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>> For additional commands, e-mail: dev-help@ozone.apache.org
>>
>>
>
> --
> NJ
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
clap clap. Great job team!!!
Regards,
Uma
On Wed, Feb 1, 2023 at 9:21 PM Siyao Meng <si...@apache.org> wrote:
> Hi Ozone devs,
>
> Thanks everyone. Snapshot feature branch merge is now *complete*.
> Snapshot feature dev from Milestone 2 will continue on the master branch.
> The wiki page
> <
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240880760
> >
> has also been updated to reflect this.
>
> Previously mentioned flakiness has been addressed and remediated by
> HDDS-7845 <https://issues.apache.org/jira/browse/HDDS-7845> and HDDS-7861
> <https://issues.apache.org/jira/browse/HDDS-7861>. Big thanks to Hemant
> for
> working on them. A follow-up jira HDDS-7871
> <https://issues.apache.org/jira/browse/HDDS-7871> has been filed for
> discussion and a potential fix in KeyManagerImpl.
>
>
> To devs working on master branch:
>
> - This branch merge may lead to new conflicts in pending PRs targeting
> the master branch, as we *moved* read path implementations from
> OzoneManager
> to OmMetadataReader (as they are shared by active DB and snapshot
> checkpoint DB).
> - In that case, fetch the latest master branch (e.g. git fetch asf
> master), merge it into your dev branch (e.g. git merge asf/master), resolve
> the conflicts accordingly and commit. Please feel free to reach out if you
> need help.
> - Future new OM read path would need to be implemented in
> OmMetadataReader
> then called from OzoneManager. If that new OM read path is applicable to
> snapshots, it needs to be implemented in OmSnapshot as well.
>
>
> To devs that has open PRs against snapshot feature branch:
>
> - Please re-target your PRs' base branch by clicking "Edit" to the right
> of the PR title, select "base: master" then "Change base".
>
>
> Thanks,
> Siyao
>
> On Jan 27, 2023 at 10:03:16 AM, Uma Maheswara Rao Gangumalla <
> umagangumalla@gmail.com> wrote:
>
> > +1 Let's address the test failure before merge. It's a blocker for the
> > merge.
> >
> > Regards,
> > Uma
> >
> > On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde
> <ppogde@cloudera.com.invalid
> > >
> > wrote:
> >
> > Yup, we are on top of it.
> >
> >
> > Thanks,
> >
> > Prashant
> >
> >
> > > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
> >
> > wrote:
> >
> > >
> >
> > > Hi Prashant,
> >
> > >
> >
> > >> We will go ahead and merge the Snapshot branch into master.
> >
> > >
> >
> > > There is a new integration test that has been failing consistently
> >
> > > since it was introduced on the feature branch (last 3 commits and a
> >
> > > new PR). Please only merge to master after it is fixed.
> >
> > >
> >
> > > https://issues.apache.org/jira/browse/HDDS-7846
> >
> > >
> >
> > > -Attila
> >
> > >
> >
> > > ---------------------------------------------------------------------
> >
> > > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> >
> > > For additional commands, e-mail: dev-help@ozone.apache.org
> >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> >
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> >
> > For additional commands, e-mail: dev-help@ozone.apache.org
> >
> >
> >
> >
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Siyao Meng <si...@apache.org>.
Hi Ozone devs,
Thanks everyone. Snapshot feature branch merge is now *complete*.
Snapshot feature dev from Milestone 2 will continue on the master branch.
The wiki page
<https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240880760>
has also been updated to reflect this.
Previously mentioned flakiness has been addressed and remediated by
HDDS-7845 <https://issues.apache.org/jira/browse/HDDS-7845> and HDDS-7861
<https://issues.apache.org/jira/browse/HDDS-7861>. Big thanks to Hemant for
working on them. A follow-up jira HDDS-7871
<https://issues.apache.org/jira/browse/HDDS-7871> has been filed for
discussion and a potential fix in KeyManagerImpl.
To devs working on master branch:
- This branch merge may lead to new conflicts in pending PRs targeting
the master branch, as we *moved* read path implementations from OzoneManager
to OmMetadataReader (as they are shared by active DB and snapshot
checkpoint DB).
- In that case, fetch the latest master branch (e.g. git fetch asf
master), merge it into your dev branch (e.g. git merge asf/master), resolve
the conflicts accordingly and commit. Please feel free to reach out if you
need help.
- Future new OM read path would need to be implemented in OmMetadataReader
then called from OzoneManager. If that new OM read path is applicable to
snapshots, it needs to be implemented in OmSnapshot as well.
To devs that has open PRs against snapshot feature branch:
- Please re-target your PRs' base branch by clicking "Edit" to the right
of the PR title, select "base: master" then "Change base".
Thanks,
Siyao
On Jan 27, 2023 at 10:03:16 AM, Uma Maheswara Rao Gangumalla <
umagangumalla@gmail.com> wrote:
> +1 Let's address the test failure before merge. It's a blocker for the
> merge.
>
> Regards,
> Uma
>
> On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde <ppogde@cloudera.com.invalid
> >
> wrote:
>
> Yup, we are on top of it.
>
>
> Thanks,
>
> Prashant
>
>
> > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
>
> wrote:
>
> >
>
> > Hi Prashant,
>
> >
>
> >> We will go ahead and merge the Snapshot branch into master.
>
> >
>
> > There is a new integration test that has been failing consistently
>
> > since it was introduced on the feature branch (last 3 commits and a
>
> > new PR). Please only merge to master after it is fixed.
>
> >
>
> > https://issues.apache.org/jira/browse/HDDS-7846
>
> >
>
> > -Attila
>
> >
>
> > ---------------------------------------------------------------------
>
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>
> > For additional commands, e-mail: dev-help@ozone.apache.org
>
> >
>
>
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
>
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
+1 Let's address the test failure before merge. It's a blocker for the
merge.
Regards,
Uma
On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
> Yup, we are on top of it.
>
> Thanks,
> Prashant
>
> > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
> wrote:
> >
> > Hi Prashant,
> >
> >> We will go ahead and merge the Snapshot branch into master.
> >
> > There is a new integration test that has been failing consistently
> > since it was introduced on the feature branch (last 3 commits and a
> > new PR). Please only merge to master after it is fixed.
> >
> > https://issues.apache.org/jira/browse/HDDS-7846
> >
> > -Attila
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> > For additional commands, e-mail: dev-help@ozone.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Prashant Pogde <pp...@cloudera.com.INVALID>.
Yup, we are on top of it.
Thanks,
Prashant
> On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org> wrote:
>
> Hi Prashant,
>
>> We will go ahead and merge the Snapshot branch into master.
>
> There is a new integration test that has been failing consistently
> since it was introduced on the feature branch (last 3 commits and a
> new PR). Please only merge to master after it is fixed.
>
> https://issues.apache.org/jira/browse/HDDS-7846
>
> -Attila
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Attila Doroszlai <ad...@apache.org>.
Hi Prashant,
> We will go ahead and merge the Snapshot branch into master.
There is a new integration test that has been failing consistently
since it was introduced on the feature branch (last 3 commits and a
new PR). Please only merge to master after it is fixed.
https://issues.apache.org/jira/browse/HDDS-7846
-Attila
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org