You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "vernedeng (via GitHub)" <gi...@apache.org> on 2023/04/03 09:05:55 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #7770: [INLONG-7769][DataProxy] Fix NPE when request Inlong Manager failed
vernedeng opened a new pull request, #7770:
URL: https://github.com/apache/inlong/pull/7770
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #7769
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7770: [INLONG-7769][DataProxy] Fix NPE when request Inlong Manager failed
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7770:
URL: https://github.com/apache/inlong/pull/7770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7770: [INLONG-7769][DataProxy] Fix NPE when request Inlong Manager failed
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7770:
URL: https://github.com/apache/inlong/pull/7770#discussion_r1156662208
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/RemoteConfigManager.java:
##########
@@ -205,6 +205,12 @@ private boolean reloadDataProxyConfig(String clusterName, String clusterTag, Str
LOGGER.info("start to request {} to get config info with params {}", url, request);
CloseableHttpResponse response = httpClient.execute(httpPost);
String returnStr = EntityUtils.toString(response.getEntity());
+
+ if (response.getStatusLine().getStatusCode() != 200) {
Review Comment:
Will the `response.getStatusLine()` be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #7770: [INLONG-7769][DataProxy] Fix NPE when request Inlong Manager failed
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #7770:
URL: https://github.com/apache/inlong/pull/7770#discussion_r1157012026
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/RemoteConfigManager.java:
##########
@@ -205,6 +205,12 @@ private boolean reloadDataProxyConfig(String clusterName, String clusterTag, Str
LOGGER.info("start to request {} to get config info with params {}", url, request);
CloseableHttpResponse response = httpClient.execute(httpPost);
String returnStr = EntityUtils.toString(response.getEntity());
+
+ if (response.getStatusLine().getStatusCode() != 200) {
Review Comment:
<img width="981" alt="image" src="https://user-images.githubusercontent.com/45282474/229756142-71345078-3034-4d0b-81e7-efb84ef11e4b.png">
The constuctor of HttpResponse requires statusline not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org