You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/07/19 12:52:36 UTC
[GitHub] [dubbo-go] Howie66 opened a new pull request #664: Imp: Some improvements related to annotation
Howie66 opened a new pull request #664:
URL: https://github.com/apache/dubbo-go/pull/664
**What this PR does**:
Some improvements related to annotation,issue https://github.com/apache/dubbo-go/issues/661
**Special notes for your reviewer**:
if the annotation i added have any problems, please email haoweili35@gmail.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #664: Imp: Some improvements related to annotation
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #664:
URL: https://github.com/apache/dubbo-go/pull/664#discussion_r456908294
##########
File path: cluster/cluster_impl/broadcast_cluster.go
##########
@@ -39,6 +39,7 @@ func NewBroadcastCluster() cluster.Cluster {
return &broadcastCluster{}
}
+// Join would return baseClusterInvoker instance
Review comment:
the comment should be `Join returns a baseClusterInvoker instance`.
And the following comment should change as the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #664: Imp: Some improvements related to annotation
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #664:
URL: https://github.com/apache/dubbo-go/pull/664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org