You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/16 16:10:16 UTC
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4438
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
The comments on https://issues.apache.org/jira/browse/LEGAL-64 seem to
indicate that Artistic License might not be allowed in ASF
projects. Bootstrap distributes it, and Bootstrap itself is
MIT-licensed, but that doesn't mean ASF projects can distribute
npm.js.
Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
---
M LICENSE.txt
M bin/rat_exclude_files.txt
D tests/comparison/leopard/static/js/npm.js
M tests/comparison/leopard/templates/custom_run.template
M tests/comparison/leopard/templates/index.template
M tests/comparison/leopard/templates/report.template
D www/bootstrap/js/npm.js
7 files changed, 70 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/4438/1
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1: Code-Review+1
> Let me run the Leopard front end and do a sanity test.
It's fine. +1 for the Leopard changes.
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
The comments on https://issues.apache.org/jira/browse/LEGAL-64 seem to
indicate that Artistic License might not be allowed in ASF
projects. Bootstrap distributes it, and Bootstrap itself is
MIT-licensed, but that doesn't mean ASF projects can distribute
npm.js.
Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Reviewed-on: http://gerrit.cloudera.org:8080/4438
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M LICENSE.txt
M bin/rat_exclude_files.txt
D tests/comparison/leopard/static/js/npm.js
M tests/comparison/leopard/templates/custom_run.template
M tests/comparison/leopard/templates/index.template
M tests/comparison/leopard/templates/report.template
D www/bootstrap/js/npm.js
7 files changed, 70 insertions(+), 31 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1: Code-Review+2
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1:
Let me run the Leopard front end and do a sanity test.
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4438/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
Line 2
Did you check that the Impala webpage still works after deleting this file?
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4438/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
Line 2
> Yes, exactly. Check that the webpage works on the local minicluster. I woul
OK, tested. Looks fine to me.
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4438/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
Line 2
> Did you check that the Impala webpage still works after deleting this file?
No. How would you suggest I test - maybe start up Impala minicluster and load the basic webpage that appears on localhost:25000 (or whatever port it is)?
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/213/
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4438/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
Line 2
> No. How would you suggest I test - maybe start up Impala minicluster and lo
Yes, exactly. Check that the webpage works on the local minicluster. I would click on a few buttons to make sure everything is in order.
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4110, IMPALA-3853: npm.js uses Artistic License 2.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcbeeb6e8552894803315967b95f365227d7505
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No