You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "harshilv17 (via GitHub)" <gi...@apache.org> on 2026/09/22 17:38:55 UTC
[PR] Fix #6840: stop passing a Printf arg to the structured digest log [camel-k]
harshilv17 opened a new pull request, #6842:
URL: https://github.com/apache/camel-k/pull/6842
Fixes #6840
`Logger.Info` takes key-value pairs, not a format string — `Infof` is the Printf variant. The digest-changed log in `build_kit.go` passed `"...%s...", integration.Name` to `Info`, so zap saw a key with no value and raised `dpanic`, and the `%s` never interpolated.
Dropped the argument rather than switching to `Infof`: the action's logger is built by `rlog.ForIntegration(target)`, so `ns` and `name` are already on every record.
Checked the rest of the repo with an AST pass over all `Info`/`Debug`/`Error` call sites — this was the only parity violation. Existing tests already cover this branch.
_Claude Code on behalf of Harshil Valecha_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #6840: stop passing a Printf arg to the structured digest log [camel-k]
Posted by "harshilv17 (via GitHub)" <gi...@apache.org>.
harshilv17 commented on PR #6842:
URL: https://github.com/apache/camel-k/pull/6842#issuecomment-5790807727
@squakez ig no issues, right?
and ready to merge...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #6840: stop passing a Printf arg to the structured digest log [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6842:
URL: https://github.com/apache/camel-k/pull/6842#issuecomment-5789973109
:warning: Unit test coverage report - coverage decreased from 63.8% to 63.7% (**-0.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #6840: stop passing a Printf arg to the structured digest log [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #6842:
URL: https://github.com/apache/camel-k/pull/6842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org