You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/29 06:09:21 UTC
[GitHub] [dubbo] AlbumenJ commented on pull request #11046: Add NPE and empty list check in AwareClusterInvoker#doInvoke.
AlbumenJ commented on PR #11046:
URL: https://github.com/apache/dubbo/pull/11046#issuecomment-1330134107
> > 
> > Revert this change in #6343 is enough
>
> <img alt="Screenshot 2022-11-29 at 13 02 31" width="815" src="https://user-images.githubusercontent.com/44674562/204443536-f49b0b6d-bade-4e7b-aaf5-26a7f263147b.png">
>
> I think if we simply throw RpcException if there is no invoker match the first 3 strategy, it might be against the 4th spec we given in the documentation of ZoneAwareClusterInvoker.
The spec is wrong. We should not pick one if none available. This violates the general rules of Dubbo Cluster Invoker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org