You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/29 02:40:22 UTC

[GitHub] [incubator-superset] zuzana-vej opened a new issue #11096: SQL Lab doesn't display query history

zuzana-vej opened a new issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096


   SQL Lab query history is broken. This bug is as a regression which was introduced some time between 1-2 weeks before 9/23.
   
   ### Expected results
   
   After user runs a query in SQL Lab, it should show in the Query History tab.
   
   ### Actual results
   
   The Query history is blank.
   
   #### Screenshots
   
   <img width="1286" alt="Screen Shot 2020-09-28 at 7 35 14 PM" src="https://user-images.githubusercontent.com/61221714/94506430-3cc8ae00-01c2-11eb-930b-27ec2a0061fe.png">
   
   
   #### How to reproduce the bug
   
   1. Go to SQL lab
   2. Run a simple query
   3. Click on Query history
   4. See there are no records
   
   ### Environment
   - superset version: latest master
   
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] graceguo-supercat commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-701875771


   For async queries, we should be able to see old queries' results by clicking VIEW RESULTS link. this feature is not working right now:
   ![EXx44bCHu0](https://user-images.githubusercontent.com/27990562/94768030-1726da80-0363-11eb-89db-680992938c48.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-702273608


   @graceguo-supercat that looks like a separate issue, would you mind filing another ticket? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-700391292


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch edited a comment on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-702520071


   `react-bootstrap`'s Popover + emotions break! We need to migrate all Popovers to antd quickly. I fixed the `SpatialControl` yesterday and I bet this is the same root cause...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-700409642


   @dpgaspar, Daniel, could you please take a quick look, thanks! 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai closed issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
nytai closed issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-702520071


   Popover + emotions break! We need to migrate all Popovers to antd quickly. I fixed the `SpatialControl` yesterday and I bet this is the same root cause...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] graceguo-supercat commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-705058222


   @nytai After the revert (or maybe have other fixes at the same time?), `VIEW RESULTS` link in query history works good now:
   ![rJgWdqoKBT](https://user-images.githubusercontent.com/27990562/95361098-25a05500-0881-11eb-9043-92eb1907ea27.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #11096: SQL Lab doesn't display query history

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11096:
URL: https://github.com/apache/incubator-superset/issues/11096#issuecomment-701821531


   Looks like this was introduced in https://github.com/apache/incubator-superset/pull/10981


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org