You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/09 08:55:43 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6964: test: add nic validation in import vm test
shwstppr opened a new pull request, #6964:
URL: https://github.com/apache/cloudstack/pull/6964
### Description
Add smoke test to prevent any regression such as #6951.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
```
[root@pr6953-t5437-vmware-67u3-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr6953-t5437-vmware-67u3-advanced-cfg -s -a tags=advanced --hypervisor=VMware tests/smoke/test_vm_lifecycle_unmanage_import.py
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography and will be removed in a future release.
from cryptography.hazmat.backends import default_backend
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /marvin/MarvinLogs/Dec_09_2022_08_44_09_MWLXVV All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_01_unmanage_vm_cycle | Status : SUCCESS ===
=== Final results are now copied to: /marvin//MarvinLogs/test_vm_lifecycle_unmanage_import_PWF31S ===
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344848805
<b>Trillian test result (tid-5438)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39179 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6964-t5438-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 574.64 | test_kubernetes_clusters.py
test_01_unmanage_vm_cycle | `Error` | 33.93 | test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown | `Error` | 33.97 | test_vm_lifecycle_unmanage_import.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344028378
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344174600
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344027627
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1345158402
> Trillian test result (tid-5438) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39179 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6964-t5438-kvm-centos7.zip Smoke tests completed. 99 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
> Test Result Time (s) Test File
> test_08_upgrade_kubernetes_ha_cluster `Failure` 574.64 test_kubernetes_clusters.py
> test_01_unmanage_vm_cycle `Error` 33.93 test_vm_lifecycle_unmanage_import.py
> ContextSuite context=TestUnmanageVM>:teardown `Error` 33.97 test_vm_lifecycle_unmanage_import.py
@rohityadavcloud I introduced an issue with test in this PR. I've fixed this in #6969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344206590
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6964?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6964](https://codecov.io/gh/apache/cloudstack/pull/6964?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ed02ce) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/d182eacf8622d3ef462b6ef56fb95b78028877b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d182eac) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #6964 +/- ##
============================================
+ Coverage 10.34% 10.36% +0.02%
- Complexity 6612 6631 +19
============================================
Files 2451 2451
Lines 242356 242357 +1
Branches 37926 37928 +2
============================================
+ Hits 25067 25127 +60
+ Misses 214199 214126 -73
- Partials 3090 3104 +14
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3ZtL1VubWFuYWdlZFZNc01hbmFnZXJJbXBsLmphdmE=) | `31.50% <0.00%> (-0.13%)` | :arrow_down: |
| [...oud/hypervisor/vmware/mo/HypervisorHostHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vSHlwZXJ2aXNvckhvc3RIZWxwZXIuamF2YQ==) | `15.55% <0.00%> (+0.22%)` | :arrow_up: |
| [...com/cloud/hypervisor/vmware/util/VmwareHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvdXRpbC9WbXdhcmVIZWxwZXIuamF2YQ==) | `2.34% <0.00%> (+0.52%)` | :arrow_up: |
| [...va/com/cloud/hypervisor/vmware/mo/DatastoreMO.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vRGF0YXN0b3JlTU8uamF2YQ==) | `2.40% <0.00%> (+2.40%)` | :arrow_up: |
| [...visor/vmware/manager/VmwareStorageManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbWFuYWdlci9WbXdhcmVTdG9yYWdlTWFuYWdlckltcGwuamF2YQ==) | `6.23% <0.00%> (+5.17%)` | :arrow_up: |
| [...d/hypervisor/vmware/mo/HostDatastoreBrowserMO.java](https://codecov.io/gh/apache/cloudstack/pull/6964/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vSG9zdERhdGFzdG9yZUJyb3dzZXJNTy5qYXZh) | `17.07% <0.00%> (+14.63%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344095226
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6964: test: add nic validation in import vm test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6964:
URL: https://github.com/apache/cloudstack/pull/6964#issuecomment-1344177036
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org