You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/24 17:58:31 UTC
[kudu-CR] [security] fix const-correctness of some ACL methods
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17496
Change subject: [security] fix const-correctness of some ACL methods
......................................................................
[security] fix const-correctness of some ACL methods
This patch fixes a few methods in simple_acl and server_base to be
const-correct.
This patch doesn't introduce any functional changes.
Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
---
M src/kudu/security/simple_acl.cc
M src/kudu/security/simple_acl.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
4 files changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/17496/1
--
To view, visit http://gerrit.cloudera.org:8080/17496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Gerrit-Change-Number: 17496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] fix const-correctness of some ACL methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17496 )
Change subject: [security] fix const-correctness of some ACL methods
......................................................................
[security] fix const-correctness of some ACL methods
This patch fixes a few methods in simple_acl and server_base to be
const-correct.
This patch doesn't introduce any functional changes.
Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Reviewed-on: http://gerrit.cloudera.org:8080/17496
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/security/simple_acl.cc
M src/kudu/security/simple_acl.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
4 files changed, 9 insertions(+), 10 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Gerrit-Change-Number: 17496
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] fix const-correctness of some ACL methods
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17496 )
Change subject: [security] fix const-correctness of some ACL methods
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Gerrit-Change-Number: 17496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 May 2021 18:18:38 +0000
Gerrit-HasComments: No
[kudu-CR] [security] fix const-correctness of some ACL methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [security] fix const-correctness of some ACL methods
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Gerrit-Change-Number: 17496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] fix const-correctness of some ACL methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17496 )
Change subject: [security] fix const-correctness of some ACL methods
......................................................................
Patch Set 1: Verified+1
unrelated test failure:
* ToolTest.TestReplaceTablet
--
To view, visit http://gerrit.cloudera.org:8080/17496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0052528865c877354d5fdfa2e069a6daf716336d
Gerrit-Change-Number: 17496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 May 2021 18:45:05 +0000
Gerrit-HasComments: No