[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #7680: [HUDI-5548] spark sql show | update hudi's table properties

["XuQianJin-Stars (via GitHub)" <gi...@apache.org>]

XuQianJin-Stars commented on code in PR #7680:
URL: https://github.com/apache/hudi/pull/7680#discussion_r1133184491


##########
hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterTableCommand.scala:
##########
@@ -179,37 +184,6 @@ case class AlterTableCommand(table: CatalogTable, changes: Seq[TableChange], cha
     logInfo("column update finished")
   }
 
-  // to do support unset default value to columns, and apply them to internalSchema

Review Comment:
   > Are we essentially moving this part in Spark 3.1 and 3.2 to AlterHoodieTable[Un]Set class ? What are the side effects here ? Are we disallowing existing mechanisms to set/unset props with this change ?
   
   There are no side effects, which can simplify and unify the original code logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org