You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/22 10:43:33 UTC

[GitHub] [incubator-nuttx-apps] davids5 edited a comment on pull request #369: Don't save the command again in the history buffer if it's at the top

davids5 edited a comment on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678625000


   > Hi @davids5
   > There was a bunch of globals all related to the history feature, I just grouped them in a struct. Long names were also used there which contributed to some nxstyle long line issues.
   
   Ok Got it. 
   
   Is it ready to go then? Has this be built and tested with all the variants of the Kconfig knob in it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org