You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/17 16:05:13 UTC

[GitHub] [incubator-superset] mistercrunch commented on pull request #10084: fix: Fixed bug for issue #9967 ( Hive date functions for group functions in charts )

mistercrunch commented on pull request #10084:
URL: https://github.com/apache/incubator-superset/pull/10084#issuecomment-645466832


   Thanks for bearing with us, having tests will prevent the regression like the one that this PR is fixing!
   
   Also about `black`, we recommend installing pre-commit hooks:
   https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#git-hooks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org