[GitHub] [airflow] ashb commented on a change in pull request #21877: AIP-45 Remove dag parsing in airflow run local

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #21877:
URL: https://github.com/apache/airflow/pull/21877#discussion_r837279794



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -779,6 +779,22 @@ def _execute(self) -> None:
                 self.log.exception("Exception when executing DagFileProcessorAgent.end")
             self.log.info("Exited execute loop")
 
+    def _update_dag_run_state_for_paused_dags(self):

Review comment:
       Why did this have to move out of LocalTaskJob?

##########
File path: airflow/models/taskinstance.py
##########
@@ -710,6 +670,26 @@ def mark_success_url(self):
             "&state=success"
         )
 
+    def current_pid(self) -> str:

Review comment:
       This needs to look at hostname too otherwise the pid on different hosts could clash

##########
File path: airflow/models/serialized_dag.py
##########
@@ -250,6 +250,13 @@ def has_dag(cls, dag_id: str, session: Session = None) -> bool:
         """
         return session.query(literal(True)).filter(cls.dag_id == dag_id).first() is not None
 
+    @classmethod
+    def get_dag(cls, dag_id: str) -> Optional['SerializedDAG']:

Review comment:
       This should take a session argument




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org