You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/04 17:37:55 UTC
[GitHub] [hive] saihemanth-cloudera opened a new pull request #2246: HIVE-24448: Support case-sensitivity for tables in REMOTE database
saihemanth-cloudera opened a new pull request #2246:
URL: https://github.com/apache/hive/pull/2246
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Supporting case-sensitivity for tables in REMOTE database. We need the preserve the case sensitivity in remote databases.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
We would get TableAlreadyExistsException if we don't support case sensitivity in remote databases.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Local machine
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on a change in pull request #2246: HIVE-24448: Support case-sensitivity for tables in REMOTE database
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on a change in pull request #2246:
URL: https://github.com/apache/hive/pull/2246#discussion_r629562048
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
##########
@@ -135,6 +136,7 @@
protected Context ctx;
protected Map<String, String> idToTableNameMap;
protected QueryProperties queryProperties;
+ protected static boolean isRemoteType = false;
Review comment:
Why is this variable static? Wouldnt we have an issue if multiple queries were being processed at a time?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
##########
@@ -493,6 +495,10 @@ public static String getUnescapedUnqualifiedTableName(ASTNode node) throws Seman
return getUnescapedName(node);
}
+ public static boolean getIsRemoteType(){
Review comment:
a) I think we should call this method isDbRemote() or isDatabaseRemote() instead of getIsRemoteType()
b) this should be either a protected method so its only used by its sub-classes? being doesnt make much sense given the return value is specific to a database but it doesnt take any arguments. Or if we want to make it static, we can add a isDatabaseRemote(Database db) method to a utils function.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -1096,7 +1096,7 @@ private String processTable(QB qb, ASTNode tabref) throws SemanticException {
ASTNode tableTree = (ASTNode) (tabref.getChild(0));
- String tabIdName = getUnescapedName(tableTree).toLowerCase();
+ String tabIdName = BaseSemanticAnalyzer.getIsRemoteType()?getUnescapedName(tableTree): getUnescapedName(tableTree).toLowerCase();
Review comment:
if we make it an instance method, we will not need the classname to invoke it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2246: HIVE-24448: Support case-sensitivity for tables in REMOTE database
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2246:
URL: https://github.com/apache/hive/pull/2246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2246: HIVE-24448: Support case-sensitivity for tables in REMOTE database
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2246:
URL: https://github.com/apache/hive/pull/2246#issuecomment-883785199
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org