You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2012/09/21 15:27:07 UTC
[jira] [Created] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
ramkrishna.s.vasudevan created HBASE-6854:
---------------------------------------------
Summary: Deletion of SPLITTING node on split rollback should clear the region from RIT
Key: HBASE-6854
URL: https://issues.apache.org/jira/browse/HBASE-6854
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Fix For: 0.94.2
If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461202#comment-13461202 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
Not applicable to trunk.. Just verified. In trunk we are not populating RIT for SPLITTING state.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469902#comment-13469902 ]
Hudson commented on HBASE-6854:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #8 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/8/])
HBASE-6854 Deletion of SPLITTING node on split rollback should clear the region from RIT (Ram)
Submitted by:Ram
Reviewed by:Bijieshan, Stack (Revision 1391074)
Result = FAILURE
ramkrishna :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.2
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464465#comment-13464465 ]
stack commented on HBASE-6854:
------------------------------
Looking at the patch, why we do this:
{code}
- LOG.debug("Ephemeral node deleted, regionserver crashed?, " +
- "clearing from RIT; rs=" + rs);
+ LOG.debug("Ephemeral node deleted, regionserver crashed?, offlining the region"
+ + rs.getRegion() + "clearing from RIT; rs=" + rs);
{code}
The lone 'rs' will become rs.toString. rs is a RegionState. When I look at RegionState.toString, it includes region name so why add the rs.getRegion?
The above can be fixed on commit because otherwise, this looks like a good bug fix.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-6854:
------------------------------------------
Attachment: HBASE-6854.patch
Patch for 0.94
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461597#comment-13461597 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
@Jieshan
Is it ok if i address these 2 comments on commit ?
If not i can prepare another patch from home.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464443#comment-13464443 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
Found the problem. It is a testcase related issue. The RIT that was got in the testcase should be updated everytime.
Will update the patch and commit it once i reach home.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461936#comment-13461936 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
Am planning to commit this...
Reviews welcome.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-6854:
------------------------------------------
Attachment: HBASE-6854.patch
This is what i committed.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471153#comment-13471153 ]
Lars Hofhansl commented on HBASE-6854:
--------------------------------------
The test introduced here (testShouldClearRITWhenNodeFoundInSplittingState) fails frequently in the 0.94 tests.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.2
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6854:
---------------------------------
Fix Version/s: (was: 0.94.3)
0.94.2
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.2
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan reassigned HBASE-6854:
---------------------------------------------
Assignee: ramkrishna.s.vasudevan
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461217#comment-13461217 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
Pls review and provide your comments.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463037#comment-13463037 ]
ramkrishna.s.vasudevan commented on HBASE-6854:
-----------------------------------------------
I found that the testcase added with this is sometimes failing. Seems there is something in the AM and the way the watcher is set.
I will debug it and then commit the patch though it is only a testcase change.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471294#comment-13471294 ]
Lars Hofhansl commented on HBASE-6854:
--------------------------------------
related to env issues on the ubuntu2 jenkins machine. Sorry for the noise
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.2
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464892#comment-13464892 ]
Hudson commented on HBASE-6854:
-------------------------------
Integrated in HBase-0.94 #492 (See [https://builds.apache.org/job/HBase-0.94/492/])
HBASE-6854 Deletion of SPLITTING node on split rollback should clear the region from RIT (Ram)
Submitted by:Ram
Reviewed by:Bijieshan, Stack (Revision 1391074)
Result = FAILURE
ramkrishna :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6854:
---------------------------------
Fix Version/s: (was: 0.94.2)
0.94.3
Unless there's patch today, let's move it to 0.94.3.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467517#comment-13467517 ]
Hudson commented on HBASE-6854:
-------------------------------
Integrated in HBase-0.94-security #58 (See [https://builds.apache.org/job/HBase-0.94-security/58/])
HBASE-6854 Deletion of SPLITTING node on split rollback should clear the region from RIT (Ram)
Submitted by:Ram
Reviewed by:Bijieshan, Stack (Revision 1391074)
Result = SUCCESS
ramkrishna :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461565#comment-13461565 ]
Jieshan Bean commented on HBASE-6854:
-------------------------------------
We also found the same problem. Only 2 minor comments:
1.
{code}
LOG.debug("Ephemeral node deleted. Found in SPLIITING state. " + "Removing from RIT "
{code}
SPLIITING should be SPLITTING.
2. HBaseAdmin in testShouldClearRITWhenNodeFoundInSplittingState should be closed in finally block.
Otherwise, I'm +1 on this patch.
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan resolved HBASE-6854.
-------------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed to 0.94.
Thanks for the review Stack and Bijieshan
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch, HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6854) Deletion of SPLITTING node on split
rollback should clear the region from RIT
Posted by "Jieshan Bean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461613#comment-13461613 ]
Jieshan Bean commented on HBASE-6854:
-------------------------------------
I think it's ok:)
> Deletion of SPLITTING node on split rollback should clear the region from RIT
> -----------------------------------------------------------------------------
>
> Key: HBASE-6854
> URL: https://issues.apache.org/jira/browse/HBASE-6854
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.3
>
> Attachments: HBASE-6854.patch
>
>
> If a failure happens in split before OFFLINING_PARENT, we tend to rollback the split including deleting the znodes created.
> On deletion of the RS_ZK_SPLITTING node we are getting a callback but not remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well guarded in case the delete event comes due to RS down scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira