You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/02 00:00:37 UTC
[GitHub] [arrow] jonkeane opened a new pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
jonkeane opened a new pull request #10849:
URL: https://github.com/apache/arrow/pull/10849
A test to see if we can (for now) build r-debug before using it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892051274
Revision: 02bd56a82ff42565d9db8a788452b4d6eb4a1264
Submitted crossbow builds: [ursacomputing/crossbow @ actions-707](https://github.com/ursacomputing/crossbow/branches/all?query=actions-707)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-707-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891905407
Revision: d27fd38a6c0fbd21e5b89add514158c5516ed3b5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-703](https://github.com/ursacomputing/crossbow/branches/all?query=actions-703)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-703-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892707281
Revision: 2a8fc1942e491b0d0eec248ebe9c3196c143b6c6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-713](https://github.com/ursacomputing/crossbow/branches/all?query=actions-713)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-713-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891205205
Revision: e278e8ac2a8d3c922794f38a5ff1f96e20b96449
Submitted crossbow builds: [ursacomputing/crossbow @ actions-693](https://github.com/ursacomputing/crossbow/branches/all?query=actions-693)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-693-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891904675
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892690042
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r681984940
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -75,6 +79,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON \
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-ON} \
+ -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${ARROW_LTO:-ON} \
Review comment:
I've changed this to `-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${ARROW_LTO:-OFF}` Confusingly, `$ARROW_DEFAULT_PARAM` here is about adding extra features like compression libraries (based on `$LIBARROW_MINIMAL` above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892050606
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892690042
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-890611289
https://issues.apache.org/jira/browse/ARROW-13507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892193858
Revision: 6f2f0f77d4ce62a966b537dd85d6e32e28d1648f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-711](https://github.com/ursacomputing/crossbow/branches/all?query=actions-711)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-711-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cpcloud commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
cpcloud commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r681967419
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -45,6 +45,10 @@ else
ARROW_DEFAULT_PARAM="OFF"
fi
+if echo "$ARROW_R_CXXFLAGS" | grep -q "flto"; then
+ ARROW_LTO="ON"
Review comment:
Should this have an `else` clause setting `ARROW_LTO` to `"OFF"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892707281
Revision: 2a8fc1942e491b0d0eec248ebe9c3196c143b6c6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-713](https://github.com/ursacomputing/crossbow/branches/all?query=actions-713)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-713-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892103644
Revision: 6f2f0f77d4ce62a966b537dd85d6e32e28d1648f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-709](https://github.com/ursacomputing/crossbow/branches/all?query=actions-709)
|Task|Status|
|----|------|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-709-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cpcloud commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
cpcloud commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r681966121
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -75,6 +79,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON \
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-ON} \
+ -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${ARROW_LTO:-ON} \
Review comment:
Should this be `${ARROW_LTO:-$ARROW_DEFAULT_PARAM}`? As it currently is, it looks like LTO will always be turned on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891176359
@github-actions crossbow submit test-r-r_hub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891943880
I also ran this locally removing all of the `-fno-lto` flags that were added in ARROW-13199, and I get a segfault there as well (this is at the same point as the crossbow build above which tries to remove that flag only when we know we're on LTO):
```
16: tools:::.test_load_package("arrow", "/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new")
An irrecoverable exception occurred. R is aborting now ...
Segmentation fault
ERROR: loading failed
```
So it looks like we need to do something more to be able to build/link on the CRAN LTO check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10849:
URL: https://github.com/apache/arrow/pull/10849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r681031142
##########
File path: dev/tasks/docker-tests/azure.linux.yml
##########
@@ -45,6 +45,15 @@ jobs:
git -C arrow submodule update --init --recursive
displayName: Clone arrow
+ # only needed for r-lto job to use until https://github.com/wch/r-debug/pull/22 is merged
+ - script: |
+ git clone https://github.com/nealrichardson/r-debug.git
+ git checkout lto
+ cd r-debug
+ ./buildall.sh
Review comment:
Actually, turns out R-hub has a docker image already: https://github.com/r-hub/rhub-linux-builders/blob/master/debian-gcc-devel-lto/Dockerfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-891204690
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
This should fail with the CRAN error at https://www.stats.ox.ac.uk/pub/bdr/LTO/arrow.out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892193399
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r680894618
##########
File path: dev/tasks/docker-tests/azure.linux.yml
##########
@@ -45,6 +45,15 @@ jobs:
git -C arrow submodule update --init --recursive
displayName: Clone arrow
+ # only needed for r-lto job to use until https://github.com/wch/r-debug/pull/22 is merged
+ - script: |
+ git clone https://github.com/nealrichardson/r-debug.git
+ git checkout lto
+ cd r-debug
+ ./buildall.sh
Review comment:
A possibly faster way to do this is to add a new job like for the r-sanitizer, and add dockerfile like https://github.com/nealrichardson/r-debug/blob/lto/r-debug-5/Dockerfile:
```
FROM wch1/r-debug
# RDlto: R built with --enable-lto
RUN wget https://raw.githubusercontent.com/nealrichardson/r-debug/lto/r-devel/buildR.sh
RUN buildR.sh lto
RUN RDlto -q -e 'install.packages("pak", repos = "https://r-lib.github.io/p/pak/dev")'
RUN RDlto -q -e 'pak::pkg_install(c("devtools", "Rcpp", "roxygen2", "testthat", "memoise", "rmarkdown"))'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10849:
URL: https://github.com/apache/arrow/pull/10849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10849: ARROW-13507: [R] LTO job on CRAN fails
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#issuecomment-892103043
@github-actions crossbow submit test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org