You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2021/10/21 13:39:25 UTC
[GitHub] [incubator-streampipes-extensions] Hrushi20 opened a new pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Hrushi20 opened a new pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52
Hi,
My bad for creating a new pull request. Got a bit confused with the git branching. I added the required changes for ValueChange class.
Hrushikesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949355809
Hi @tenthe
I updated the code. I didn't add the image. I added the user input in the declare model as mentioned.
Hrushikesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949658092
Hi @tenthe
Do I squash my commits into a single commit or is it fine?
I'll start working on the other issue and update all the processors in the module streampipes-processors-filters-jvm.
Hrushikesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949644218
Thanks for updating the code.
I will add an image and merge the PR.
I created a new issue [1] to update all the processors in module streampipes-processors-filters-jvm.
If you want you can start with that. I think this is a good way to learn more about the StreamPipes API, because the different processors use different functions from the API.
My suggestion would be to update the processors one after the other instead of all at once.
What do you think?
[1] https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949849737
Should I create a new branch consisting PR #52 code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe merged pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe merged pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 removed a comment on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 removed a comment on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948936284
Hi @tenthe
In what way can the user input the values? Should the user select the input from given options or should enter they the value in text field?
Do I use **Free-Text Parameters** to let the user input a value?
Also, should I put a random image for now or will you provide a url to an img?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 edited a comment on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 edited a comment on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948936284
Hi @tenthe
In what way can the user input the values? Should the user select the input from given options or should enter they the value in text field?
Do I use **Free-Text Parameters** to let the user input a value?
Also, should I put a random image for now or will you provide a url to an img?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe edited a comment on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe edited a comment on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949912338
No, I would suggest to make a new PR from dev, because the code it affects is independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948936284
What are the required user inputs?
I provided a user input which needs to have a number as an input.
`requiredPropertyWithUnaryMapping(EpRequirements.numberReq(),`
Also, should I put a random image for now or will you provide a url to an img?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948906594
Hi, thanks for updating the pull request.
Here are a few comments to the current state of the implementation.
- Can you also create a folder for the resources with an icon, documentation and the string values (have a look at the other processors for examples)
- In the declare model, the configuration for the user input are missing, examples for that can be found in the documentation [1]
- To forward the event to the next processor you need to call the spOutputCollector.collect
It might also be a good task to get to know the structure of the processor to select one of the existing once and refactor it to the new API (StreamPipesDataProcessor).
[1] https://streampipes.apache.org/docs/docs/extend-sdk-static-properties.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] Hrushi20 edited a comment on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
Hrushi20 edited a comment on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948936284
What are the required user inputs?
I provided a user input which needs to have a number as an input.
`requiredPropertyWithUnaryMapping(EpRequirements.numberReq(),`
Do we need a **Free-Text Parameters** mapping property or **Unary mapping property**?
Also, should I put a random image for now or will you provide a url to an img?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949784394
You can leave the commits as they are, but please make a separate PR for the new changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change
Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-949912338
No, I would suggest to make a new PR, because the code it affects is independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org