[jira] [Commented] (THRIFT-5128) Swift TFramedTransport does not work using present code

["Jano Svitok (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073667#comment-17073667 ] 

Jano Svitok commented on THRIFT-5128:
-------------------------------------

CI passed (except flaky ThreadManager load test in appveyor), it's ready to review/merge.

> Swift TFramedTransport does not work using present code
> -------------------------------------------------------
>
>                 Key: THRIFT-5128
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5128
>             Project: Thrift
>          Issue Type: Bug
>          Components: Swift - Compiler, Swift - Library
>    Affects Versions: 0.14.0
>            Reporter: Jano Svitok
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> These are TFrameTransport related issues from THRIFT-5125.
>  
>  # _TFramedTransport.flush_ is not called anywhere; therefore, the message is never sent. _outProtocol.transport.flush_ should be added to generated processors after _outProtocol.writeMessageEnd_, and also after writeException.
>  # _TFramedTransport.remainingBytes_ are not reset anywhere, thus the header of second and further messages are not processed properly
>  # _TFramedTransport.flush_ incorrectly checks if buffer >= headerSize (got there by incorrectly porting code COCOA lib)
>  # _TFramedTransport_ does not read the whole message from the underlaying transport at once (that I understand is the whole point of TFramedTransport)
> Notes:
>  * 1. needs compiler changes
> PR: https://github.com/apache/thrift/pull/2047



--
This message was sent by Atlassian Jira
(v8.3.4#803005)