You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/22 23:46:07 UTC
[GitHub] [tvm] areusch opened a new pull request, #12551: Add instructions on how to add a new CI docker image
areusch opened a new pull request, #12551:
URL: https://github.com/apache/tvm/pull/12551
This PR documents the steps to introducing a new CI docker image, which we've been doing a lot lately.
@driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #12551: Add instructions on how to add a new CI docker image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12551:
URL: https://github.com/apache/tvm/pull/12551#issuecomment-1223394723
<!---docs-bot-comment-->
Built docs for commit c852c6d3c73912e1dd96b16176e87d58431c412c can be found [here](https://pr-docs.tlcpack.ai/PR-12551/1/docs/index.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12551: Add instructions on how to add a new CI docker image
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12551:
URL: https://github.com/apache/tvm/pull/12551#discussion_r952024632
##########
docs/contribute/ci.rst:
##########
@@ -174,6 +174,29 @@ The images for these containers are hosted in the `tlcpack Docker Hub <https://h
and referenced in the `Jenkinsfile.j2 <https://github.com/apache/tvm/tree/main/Jenkinsfile.j2>`_. These can be inspected and run
locally via standard Docker commands.
+Adding a new Docker image
+"""""""""""""""""""""""""
+
+New docker images can be added to test TVM on a variety of platforms. Here are the steps for adding
+a new CI image:
+
+1. Define the ``docker/Dockerfile.ci_foo`` and associated scripts in ``docker/install``. Create a PR containing only these changes (no ``Jenkinsfile`` changes).
+
+ Example: https://github.com/apache/tvm/pull/12230/files
+
+2. A committer verifies the image builds locally and then reviews/approves this PR.
+3. A committer creates the ci-foo repos in https://hub.docker.com/u/tlcpack and https://hub.docker.com/u/tlcpackstaging.
+4. Create a PR to create an ECR repo for the image in tlcpack/ci: https://github.com/tlc-pack/ci/pull/46/files
+5. A committer creates and gets merged a PR to add the image to the ``Jenkinsfile``
+
+ Example: https://github.com/apache/tvm/pull/12369/files.
Review Comment:
```suggestion
Example: https://github.com/apache/tvm/pull/12369/files
```
##########
docs/contribute/ci.rst:
##########
@@ -174,6 +174,29 @@ The images for these containers are hosted in the `tlcpack Docker Hub <https://h
and referenced in the `Jenkinsfile.j2 <https://github.com/apache/tvm/tree/main/Jenkinsfile.j2>`_. These can be inspected and run
locally via standard Docker commands.
+Adding a new Docker image
+"""""""""""""""""""""""""
+
+New docker images can be added to test TVM on a variety of platforms. Here are the steps for adding
+a new CI image:
+
+1. Define the ``docker/Dockerfile.ci_foo`` and associated scripts in ``docker/install``. Create a PR containing only these changes (no ``Jenkinsfile`` changes).
+
+ Example: https://github.com/apache/tvm/pull/12230/files
+
+2. A committer verifies the image builds locally and then reviews/approves this PR.
+3. A committer creates the ci-foo repos in https://hub.docker.com/u/tlcpack and https://hub.docker.com/u/tlcpackstaging.
+4. Create a PR to create an ECR repo for the image in tlcpack/ci: https://github.com/tlc-pack/ci/pull/46/files
+5. A committer creates and gets merged a PR to add the image to the ``Jenkinsfile``
+
+ Example: https://github.com/apache/tvm/pull/12369/files.
+
+ **NOTE**: The PR must be opened from a branch in apache/tvm, not from a branch in a forked repo.
Review Comment:
```suggestion
**NOTE**: The PR must be opened from a branch in apache/tvm, not from a branch in a forked repo, or else any ``Jenkinsfile`` changes will be ignored by CI.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #12551: Add instructions on how to add a new CI docker image
Posted by GitBox <gi...@apache.org>.
driazati merged PR #12551:
URL: https://github.com/apache/tvm/pull/12551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org