You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 15:03:20 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
kgabryje opened a new pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868
### SUMMARY
Re-enable ESLint rule `default-props-match-prop-types`, which was disabled in PR #10839. Code was refactored to fix the errors raised by the rule.
### TEST PLAN
Run `npm run lint`, verify that there are no new Javascript/Typescript errors.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-698493904
@kgabryje we just found this PR broke Dashboard tab switch:
i can't find exactly which line of change is wrong. But since dashboard tab switch is very critical function, i will have to revert this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488807652
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder.jsx
##########
@@ -64,7 +64,6 @@ const propTypes = {
};
const defaultProps = {
- showBuilderPane: false,
Review comment:
It seems that not only `showBuilderPane` was unused, but also `colorScheme` and `setColorSchemeAndUnsavedChanges`. I removed references from this file, containers/DashboardBuilder and the spec file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-696519981
@mistercrunch Can we merge it now? I made the changes that you asked for
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488797700
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder.jsx
##########
@@ -64,7 +64,6 @@ const propTypes = {
};
const defaultProps = {
- showBuilderPane: false,
Review comment:
I was confused about the type here and tracked it into the child component, and it looks unused there. Can you double check and remove all references to it here if that's the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488505032
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder.jsx
##########
@@ -64,7 +64,6 @@ const propTypes = {
};
const defaultProps = {
- showBuilderPane: false,
Review comment:
I did, but you're right, let's keep the default and remove isRequired
##########
File path: superset-frontend/src/dashboard/components/SliceAdder.jsx
##########
@@ -45,7 +45,6 @@ const propTypes = {
};
const defaultProps = {
- selectedSliceIds: [],
Review comment:
I did, but you're right, let's keep the default and remove isRequired
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-698493904
@kgabryje we just found this PR broke Dashboard tab switch:
i can't find exactly which line of change is wrong. But since dashboard tab switch is very critical function, i will have to revert this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488504768
##########
File path: superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
##########
@@ -30,7 +30,6 @@ const propTypes = {
const defaultProps = {
colorScheme: undefined,
- onChange: () => {},
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-696519981
@mistercrunch Can we merge it now? I made the changes that you asked for
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-698497223
@graceguo-supercat I'm sorry to hear that! I'll try to look into it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488409236
##########
File path: superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
##########
@@ -30,7 +30,6 @@ const propTypes = {
const defaultProps = {
colorScheme: undefined,
- onChange: () => {},
Review comment:
this one is making me nervous, can we remove the `.isRequired` instead?
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder.jsx
##########
@@ -64,7 +64,6 @@ const propTypes = {
};
const defaultProps = {
- showBuilderPane: false,
Review comment:
seems less risky to remove the `.isRequired` here too (unless you can confirm you checked all the calls)
##########
File path: superset-frontend/src/dashboard/components/SliceAdder.jsx
##########
@@ -45,7 +45,6 @@ const propTypes = {
};
const defaultProps = {
- selectedSliceIds: [],
Review comment:
let's remove `.isRequired` here to (unless you can confirm you checked all the calls)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10868: ESLint: Re-enable rule default-props-match-prop-types
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#issuecomment-698497223
@graceguo-supercat I'm sorry to hear that! I'll try to look into it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org