You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kalle Olavi Niemitalo <ko...@iki.fi> on 2005/08/03 12:17:48 UTC
[PATCH] psvn: Bind a free variable,
and mark an intentionally dynamic binding as such.
This patch is for r15394, I don't know if it still applies.
The changes are basically OK but I'd like to try the defvar
approach in XEmacs before committing this.
Re: [PATCH] psvn: Bind a free variable, and mark an intentionally
dynamic binding as such.
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Kalle Olavi Niemitalo wrote:
>>>This patch is for r15394, I don't know if it still applies.
>>>The changes are basically OK but I'd like to try the defvar
>>>approach in XEmacs before committing this.
>>
>>Thanks for the patch. I noticed this patch hasn't been reviewed or
>>applied. Is it still relevant?
>
> It is relevant, but I intend to test and commit a cleaner patch
> during the weekend. Please do not file an issue yet.
Okay, thanks! I'll hold off on that.
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] psvn: Bind a free variable,
and mark an intentionally dynamic binding as such.
Posted by Kalle Olavi Niemitalo <ko...@iki.fi>.
Stefan Reichör <st...@xsteve.at> writes:
> ui-status was also meant as documentation. It should keep the user interface.
> We could add some more data that is tracked for the user interface.
> That would be stored also in this list.
>
> You can remove that variable if you want. But please put add some
> documentation to describe, that this part holds the user interface state.
I've now done that in r16419.
Re: [PATCH] psvn: Bind a free variable, and mark an intentionally dynamic binding as such.
Posted by Stefan Reichör <st...@xsteve.at>.
Kalle Olavi Niemitalo <ko...@iki.fi> writes:
> Erik Huelsmann <eh...@gmail.com> writes:
>
>> Please include xsteve@tigris.org (the author) in your next submission.
>> He isn't monitoring dev@ closely.
>
> I did when I posted the patch, but I don't think he'd care about
> discussions on whether to file an issue, especially if the issue
> will not be filed.
>
> I have now committed the better changes as revision 15841.
Thanks. And thanks also for your other patches that improved the code
quality.
> There is still something odd about svn-parse-status-result.
> It binds user-mark and user-elide to nil, and then possibly
> stores (list user-mark user-elide) to ui-status. However, it
> never changes user-mark and user-elide; they remain nil at all
> times. Is there a hidden meaning here, or should I just remove
> those variables and use (list nil nil) instead?
The variables just serve as documentation. You could use (list nil
nil) and put a comment that the values have the meaning of user-mark
and user-elide.
> I'd also like to remove the ui-status variable (to eliminate the
> excessive scope and the misleadingly literal initial value) and
> replace its sole use with the (or ...) expression from which the
> true value always comes.
ui-status was also meant as documentation. It should keep the user interface.
We could add some more data that is tracked for the user interface.
That would be stored also in this list.
You can remove that variable if you want. But please put add some
documentation to describe, that this part holds the user interface state.
Stefan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] psvn: Bind a free variable,
and mark an intentionally dynamic binding as such.
Posted by Kalle Olavi Niemitalo <ko...@iki.fi>.
Erik Huelsmann <eh...@gmail.com> writes:
> Please include xsteve@tigris.org (the author) in your next submission.
> He isn't monitoring dev@ closely.
I did when I posted the patch, but I don't think he'd care about
discussions on whether to file an issue, especially if the issue
will not be filed.
I have now committed the better changes as revision 15841.
There is still something odd about svn-parse-status-result.
It binds user-mark and user-elide to nil, and then possibly
stores (list user-mark user-elide) to ui-status. However, it
never changes user-mark and user-elide; they remain nil at all
times. Is there a hidden meaning here, or should I just remove
those variables and use (list nil nil) instead?
I'd also like to remove the ui-status variable (to eliminate the
excessive scope and the misleadingly literal initial value) and
replace its sole use with the (or ...) expression from which the
true value always comes.
Re: [PATCH] psvn: Bind a free variable, and mark an intentionally dynamic binding as such.
Posted by Erik Huelsmann <eh...@gmail.com>.
Please include xsteve@tigris.org (the author) in your next submission.
He isn't monitoring dev@ closely.
Thanks in advance,
Erik.
On 8/19/05, Kalle Olavi Niemitalo <ko...@iki.fi> wrote:
> Michael W Thelen <mi...@pietdepsi.com> writes:
>
> > Kalle Olavi Niemitalo wrote:
> >> This patch is for r15394, I don't know if it still applies.
> >> The changes are basically OK but I'd like to try the defvar
> >> approach in XEmacs before committing this.
> >
> > Thanks for the patch. I noticed this patch hasn't been reviewed or
> > applied. Is it still relevant?
>
> It is relevant, but I intend to test and commit a cleaner patch
> during the weekend. Please do not file an issue yet.
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] psvn: Bind a free variable,
and mark an intentionally dynamic binding as such.
Posted by Kalle Olavi Niemitalo <ko...@iki.fi>.
Michael W Thelen <mi...@pietdepsi.com> writes:
> Kalle Olavi Niemitalo wrote:
>> This patch is for r15394, I don't know if it still applies.
>> The changes are basically OK but I'd like to try the defvar
>> approach in XEmacs before committing this.
>
> Thanks for the patch. I noticed this patch hasn't been reviewed or
> applied. Is it still relevant?
It is relevant, but I intend to test and commit a cleaner patch
during the weekend. Please do not file an issue yet.
Re: [PATCH] psvn: Bind a free variable, and mark an intentionally
dynamic binding as such.
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Kalle Olavi Niemitalo wrote:
> This patch is for r15394, I don't know if it still applies.
> The changes are basically OK but I'd like to try the defvar
> approach in XEmacs before committing this.
Thanks for the patch. I noticed this patch hasn't been reviewed or
applied. Is it still relevant? If it is, and if it hasn't been
addressed within a few days, I will file an issue for it in the issue
tracker.
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org