You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2024/11/27 23:46:26 UTC
[PR] Docs: Add guidelines for contributors to become committers [iceberg]
rdblue opened a new pull request, #11670:
URL: https://github.com/apache/iceberg/pull/11670
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue merged PR #11670:
URL: https://github.com/apache/iceberg/pull/11670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1876978196
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
+
+### What does the PMC look for?
+
+PMC members typically look for candidates to have demonstrated a few qualities:
+
+* **Conduct** — Committers are representatives of the project and are expected to follow the [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+* **Judgment** — Committers should know the areas where they are qualified to evaluate a change and when to bring in other opinions.
+* **Quality** — Personal contributions are a strong signal. Contributions that don’t require major help demonstrate the context and understanding needed to reliably review changes from others. If a contributor often needs guidance, they are probably not ready to guide others.
+* **Consistency** — Reviewing is the primary responsibility of a committer. A committer should demonstrate they will consistently apply their context and understanding to help contributors get changes in and ensure those changes are high quality.
+
+### How do I demonstrate those qualities?
+
+To be a committer, a candidate should act like a committer so that PMC members can evaluate the qualities above. PMC members will ask questions like these:
+
+* Has the candidate been a good representative of the project in mailing lists, Slack, github, and other discussion forums?
+* Has the candidate followed the ASF Code of Conduct when working with others?
+* Has the candidate made independent material contributions to the community that show expertise?
+* Have the candidate’s contributions been stable and maintainable?
+* Has the candidate’s work required extensive review or significant refactoring due to misunderstandings of the project’s objectives?
+* Does the candidate apply the standards and conventions of the project by following existing patterns and using already included libraries?
+* Has the candidate participated in design discussions for new features?
+* Has the candidate asked for help when reviewing changes outside their area of expertise?
+* How diverse are the contributors that the candidate reviewed?
+* Does the candidate raise potentially problematic changes to the dev list?
+
+### How can I be a committer?
+
+You can always reach out to PMC members for feedback and guidance if you have questions.
+
+There is no single path to becoming a committer. For example, people contributing to Python are often implicitly trusted not to start reviewing changes to other languages. Similarly, some areas of a project require more context than others.
+
+Keep in mind that it’s best not to compare your contributions to others. Instead, focus on demonstrating quality and judgment.
+
+### How many contributions does it take to become a committer?
+
+The number of contributions is not what matters — the quality of those contributions (including reviews!) is what demonstrates that a contributor is ready to be a committer.
+
+You can always reach out to PMC members directly or using private@iceberg.apache.org for feedback and guidance if you have questions.
Review Comment:
This was just to reiterate in this section. It is duplicative, but I think it's better to make sure people know it and reach out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1872799444
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
+
+### What does the PMC look for?
+
+PMC members typically look for candidates to have demonstrated a few qualities:
+
+* **Conduct** — Committers are representatives of the project and are expected to follow the [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+* **Judgment** — Committers should know the areas where they are qualified to evaluate a change and when to bring in other opinions.
+* **Quality** — Personal contributions are a strong signal. Contributions that don’t require major help demonstrate the context and understanding needed to reliably review changes from others. If a contributor often needs guidance, they are probably not ready to guide others.
+* **Consistency** — Reviewing is the primary responsibility of a committer. A committer should demonstrate they will consistently apply their context and understanding to help contributors get changes in and ensure those changes are high quality.
+
+### How do I demonstrate those qualities?
+
+To be a committer, a candidate should act like a committer so that PMC members can evaluate the qualities above. PMC members will ask questions like these:
+
+* Has the candidate been a good representative of the project in mailing lists, Slack, github, and other discussion forums?
+* Has the candidate followed the ASF Code of Conduct when working with others?
+* Has the candidate made independent material contributions to the community that show expertise?
+* Have the candidate’s contributions been stable and maintainable?
+* Has the candidate’s work required extensive review or significant refactoring due to misunderstandings of the project’s objectives?
+* Does the candidate apply the standards and conventions of the project by following existing patterns and using already included libraries?
+* Has the candidate participated in design discussions for new features?
+* Has the candidate asked for help when reviewing changes outside their area of expertise?
+* How diverse are the contributors that the candidate reviewed?
Review Comment:
Just for my understanding: What do we mean by "diverse contributors" here? Diverse by the company they work for or diverse by the area of code they contribute to or something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1861603745
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
That's OK to say it's one of the main criteria (it's up to the PMC). I would just mention https://community.apache.org/pmc/adding-committers.html as comdev good practice.
Generally speaking, I think it's good to have a fairly low committtership bar (there is no risk for the project, as we always have two reviews at least on PR before the merge), and it's a reward for the contributor (as you said, trust from the PMC).
I would add "Someone who loves the project and helping the community" as criteria (committer criteria should include non code contributions, see again the comdev guideline mentioned above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1861566021
##########
site/docs/community.md:
##########
@@ -76,7 +76,9 @@ Iceberg has four mailing lists:
The Apache Iceberg community is built on the principles described in the [Apache Way](https://www.apache.org/theapacheway/index.html)
and all who engage with the community are expected to be respectful, open, come with the best interests of the community in mind,
-and abide by the Apache Foundation [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+and abide by the Apache Foundation [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+
+More information specific to the Apache Iceberg community is in the next section, [the Path from Contributor to Committer](#the-path-from-contributor-to-committer)
Review Comment:
```suggestion
More information specific to the Apache Iceberg community is in the next section, [the Path from Contributor to Committer](#the-path-from-contributor-to-committer).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1876439601
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
+
+### What does the PMC look for?
+
+PMC members typically look for candidates to have demonstrated a few qualities:
+
+* **Conduct** — Committers are representatives of the project and are expected to follow the [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+* **Judgment** — Committers should know the areas where they are qualified to evaluate a change and when to bring in other opinions.
+* **Quality** — Personal contributions are a strong signal. Contributions that don’t require major help demonstrate the context and understanding needed to reliably review changes from others. If a contributor often needs guidance, they are probably not ready to guide others.
+* **Consistency** — Reviewing is the primary responsibility of a committer. A committer should demonstrate they will consistently apply their context and understanding to help contributors get changes in and ensure those changes are high quality.
+
+### How do I demonstrate those qualities?
+
+To be a committer, a candidate should act like a committer so that PMC members can evaluate the qualities above. PMC members will ask questions like these:
+
+* Has the candidate been a good representative of the project in mailing lists, Slack, github, and other discussion forums?
+* Has the candidate followed the ASF Code of Conduct when working with others?
+* Has the candidate made independent material contributions to the community that show expertise?
+* Have the candidate’s contributions been stable and maintainable?
+* Has the candidate’s work required extensive review or significant refactoring due to misunderstandings of the project’s objectives?
+* Does the candidate apply the standards and conventions of the project by following existing patterns and using already included libraries?
+* Has the candidate participated in design discussions for new features?
+* Has the candidate asked for help when reviewing changes outside their area of expertise?
+* How diverse are the contributors that the candidate reviewed?
Review Comment:
My take about "diverse" here is in the number of different contributors reviewed by the candidate (not affiliation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#issuecomment-2505348525
thanks @rdblue for writing this up. This will be very helpful for people in the Iceberg community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1876446066
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
Yes, sure, each PMC is defining the criteria, and expectations. As soon as it's consistent across the project, that's totally fine (I think it's important that the criteria is the same on iceberg, iceberg-rust, iceberg-python, ... else it's not fair for contributors).
@Fokko I don't see why Iceberg would be different compared to other mission critical projects we have at Apache (like ActiveMQ, Kafka, ...). Your proposal is fine to me and it's what I meant. It's basically a statement that we value non-code contributions.
I just linked the page as information (not as "strong guideline" or template to use).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1863168496
##########
site/docs/community.md:
##########
@@ -76,7 +76,9 @@ Iceberg has four mailing lists:
The Apache Iceberg community is built on the principles described in the [Apache Way](https://www.apache.org/theapacheway/index.html)
and all who engage with the community are expected to be respectful, open, come with the best interests of the community in mind,
-and abide by the Apache Foundation [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+and abide by the Apache Foundation [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
Review Comment:
```suggestion
and abide by the Apache Software Foundation [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
```
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
Hey JB, thanks for linking that page. I was surprised that this page changed so substantially to how it was before, as an effort of deduplication: https://github.com/apache/comdev-site/pull/191/files#diff-f61968335feadda8b65024fba3abbee7ffe36f56ad106968f47927a9b286f290
This is my take. It depends on the project. For another project I worked on, the risk of accidentally committing a bug is fairly low, while on Iceberg there is a chance of data loss or incorrectness. Which would be a real threat to the project. As always, wording is subjective, and also cultural. If we feel like extending this, I would rather go with something like:
> Someone who's committed to the project and helping the community.
But I would leave it as it is now as it boils down to the essence, and it isn't set in stone either (in git actually).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#issuecomment-2529162334
Thanks for the reviews, everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1872080000
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
Thanks for the feedback, JB. Right now, we're focusing on describing how the community operates, rather than discussing how it might operate in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1861603745
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
That's OK to say it's one of the main criteria (it's up to the PMC). I would just mention https://community.apache.org/pmc/adding-committers.html as comdev good practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1861603745
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
Review Comment:
That's OK to say it's one of the main criteria (it's up to the PMC). I would just mention https://community.apache.org/pmc/adding-committers.html as comdev good practive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#issuecomment-2521586689
I think this is a clear expression of the things the Iceberg PMC is currently looking for, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Add guidelines for contributors to become committers [iceberg]
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1874095478
##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted through direct messages
related to contributing to or using Iceberg can be posted to the `#jobs` channel.
For questions regarding any of the guidelines above, please contact a PMC member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and discussed by the PMC, which uses a consensus vote to confirm a new committer. This vote is the only formal requirement in the Iceberg community — there are no other requirements, such as a minimum period of time or a minimum number of contributions. Similarly, there is no length of time or number of commits that automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they have good judgment and are a reliable reviewer.
+
+### What does the PMC look for?
+
+PMC members typically look for candidates to have demonstrated a few qualities:
+
+* **Conduct** — Committers are representatives of the project and are expected to follow the [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
+* **Judgment** — Committers should know the areas where they are qualified to evaluate a change and when to bring in other opinions.
+* **Quality** — Personal contributions are a strong signal. Contributions that don’t require major help demonstrate the context and understanding needed to reliably review changes from others. If a contributor often needs guidance, they are probably not ready to guide others.
+* **Consistency** — Reviewing is the primary responsibility of a committer. A committer should demonstrate they will consistently apply their context and understanding to help contributors get changes in and ensure those changes are high quality.
+
+### How do I demonstrate those qualities?
+
+To be a committer, a candidate should act like a committer so that PMC members can evaluate the qualities above. PMC members will ask questions like these:
+
+* Has the candidate been a good representative of the project in mailing lists, Slack, github, and other discussion forums?
+* Has the candidate followed the ASF Code of Conduct when working with others?
+* Has the candidate made independent material contributions to the community that show expertise?
+* Have the candidate’s contributions been stable and maintainable?
+* Has the candidate’s work required extensive review or significant refactoring due to misunderstandings of the project’s objectives?
+* Does the candidate apply the standards and conventions of the project by following existing patterns and using already included libraries?
+* Has the candidate participated in design discussions for new features?
+* Has the candidate asked for help when reviewing changes outside their area of expertise?
+* How diverse are the contributors that the candidate reviewed?
+* Does the candidate raise potentially problematic changes to the dev list?
+
+### How can I be a committer?
+
+You can always reach out to PMC members for feedback and guidance if you have questions.
+
+There is no single path to becoming a committer. For example, people contributing to Python are often implicitly trusted not to start reviewing changes to other languages. Similarly, some areas of a project require more context than others.
+
+Keep in mind that it’s best not to compare your contributions to others. Instead, focus on demonstrating quality and judgment.
+
+### How many contributions does it take to become a committer?
+
+The number of contributions is not what matters — the quality of those contributions (including reviews!) is what demonstrates that a contributor is ready to be a committer.
+
+You can always reach out to PMC members directly or using private@iceberg.apache.org for feedback and guidance if you have questions.
Review Comment:
I feel this line can probably combined with line 146, both focus on how to seek PMC guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org