You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Toshiaki Hatano <to...@verio.net> on 2013/07/05 22:14:51 UTC
Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between
0-4096. Should be 0-'4095'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/
-----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
But it allows VLAN range between 0-4096.
VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
CloudStack should return error when someone try to assign VLAN ID 4096 to network.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java 05df742
Diff: https://reviews.apache.org/r/12278/diff/
Testing
-------
Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
updatePhysicalNetwork returns error correctly.
Thanks,
Toshiaki Hatano
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22807
-----------------------------------------------------------
Commit 814630c5428862aa247914e5bc04c3bcbc00c501 in branch refs/heads/master from toshiaki.hatano
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=814630c ]
CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
- ASF Subversion and Git Services
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
RE: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
Posted by Toshiaki Hatano <to...@verio.net>.
My apology for sending review request in HTML format...
How can I change this behavior of Review Board? (Is there setting?)
--
Toshiaki
From: Toshiaki Hatano [mailto:noreply@reviews.apache.org] On Behalf Of Toshiaki Hatano
Sent: Friday, July 05, 2013 14:15
To: Hugo Trippaers; Sheng Yang; Chiradeep Vittal; Alena Prokharchyk; Murali Reddy
Cc: cloudstack; Toshiaki Hatano
Subject: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12278/
Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
By Toshiaki Hatano.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
Repository: cloudstack-git
Description
CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
But it allows VLAN range between 0-4096.
VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
CloudStack should return error when someone try to assign VLAN ID 4096 to network.
Testing
Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
updatePhysicalNetwork returns error correctly.
Diffs
• server/src/com/cloud/network/NetworkServiceImpl.java (05df742)
View Diff
This email message is intended for the use of the person to whom it has been sent, and may contain information that is confidential or legally protected. If you are not the intended recipient or have received this message in error, you are not authorized to copy, distribute, or otherwise use this message or its attachments. Please notify the sender immediately by return e-mail and permanently delete this message and any attachments. Verio Inc. makes no warranty that this email is error or virus free. Thank you.
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22993
-----------------------------------------------------------
Commit 4d4bd8a263b974daf53a60a1590f22c96bdd5e48 in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d4bd8a ]
CLOUDSTACK-3384: Fix the vlan range < 4096
VLAN ranges beyond 4095 are properly handled. Fix the test to accomdate
this change
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 3f5c1c6da3d2152fdc966603f929c3ea880d8b60)
- ASF Subversion and Git Services
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22991
-----------------------------------------------------------
Commit b4cd6f097fcac7033ca8a07143e9e2592369945b in branch refs/heads/master-6-17-stable from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4cd6f0 ]
CLOUDSTACK-3384: Fix the vlan range < 4096
VLAN ranges beyond 4095 are properly handled. Fix the test to accomdate
this change
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 3f5c1c6da3d2152fdc966603f929c3ea880d8b60)
- ASF Subversion and Git Services
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22808
-----------------------------------------------------------
Commit a93042674134ded31d0dea2d006fac881743ab91 in branch refs/heads/4.2 from toshiaki.hatano
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a930426 ]
CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
- ASF Subversion and Git Services
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22809
-----------------------------------------------------------
Ship it!
Branch: refs/heads/master
Commit: 814630c5428862aa247914e5bc04c3bcbc00c501
Branch: refs/heads/4.2
Commit: a93042674134ded31d0dea2d006fac881743ab91
- Murali Reddy
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range
between 0-4096. Should be 0-'4095'.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22992
-----------------------------------------------------------
Commit 3f5c1c6da3d2152fdc966603f929c3ea880d8b60 in branch refs/heads/master from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3f5c1c6 ]
CLOUDSTACK-3384: Fix the vlan range < 4096
VLAN ranges beyond 4095 are properly handled. Fix the test to accomdate
this change
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 8:14 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
>
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl.
> But it allows VLAN range between 0-4096.
>
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) .
> CloudStack should return error when someone try to assign VLAN ID 4096 to network.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05df742
>
> Diff: https://reviews.apache.org/r/12278/diff/
>
>
> Testing
> -------
>
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
>
> updatePhysicalNetwork returns error correctly.
>
>
> Thanks,
>
> Toshiaki Hatano
>
>